All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lee Jones <lee@kernel.org>
To: Yaozhong Li <yaozhonguwl@gmail.com>
Cc: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Heiko Stuebner <heiko@sntech.de>,
	Chris Zhong <zyw@rock-chips.com>,
	Zhang Qing <zhangqing@rock-chips.com>,
	Joseph Chen <chenjh@rock-chips.com>,
	Sebastian Reichel <sebastian.reichel@collabora.com>,
	mfd@lists.linux.dev, devicetree@vger.kernel.org,
	linux-rockchip@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 1/3] dt-bindings: mfd: rk8xx: add board level power hold GPIOs
Date: Tue, 27 Oct 2026 09:27:14 +0000	[thread overview]
Message-ID: <20261027092714.GH2195460@google.com> (raw)
In-Reply-To: <20261027084511.1992-2-yaozhonguwl@gmail.com>

On Tue, 27 Oct 2026, Yaozhong Li wrote:

> Some boards route "power hold" lines from the SoC into the board's power
> circuitry. Those lines have to be held asserted while the system is
> running and released before the PMIC shutdown request is written,
> otherwise the rails can drop and come back up instead of staying off.
> 
> Add power-hold-gpios to describe those lines and power-hold-delay-ms for
> the settle time. The driver reads them for every RK8xx variant that is
> the system power controller, so add them to all seven RK8xx schemas.
> 
> The array is bounded at two entries. Firefly's vendor kernel handles
> exactly two such lines, pmic,hold-gpio and pmic,stby-gpio, and its board
> files use one or both of them, with an RK808 and with an RK818.
> 
> The lines are released from the PMIC's power-off path, so they are only
> meaningful when the PMIC is the system power controller. Require that.
> A board adding these lines is expected to switch to the generic
> system-power-controller property at the same time, so the deprecated
> rockchip,system-power-controller spelling is not accepted here.
> 
> Assisted-by: LLM
> Signed-off-by: Yaozhong Li <yaozhonguwl@gmail.com>
> ---
>  .../bindings/mfd/rockchip,rk801.yaml          | 24 +++++++++++++++++++
>  .../bindings/mfd/rockchip,rk805.yaml          | 24 +++++++++++++++++++
>  .../bindings/mfd/rockchip,rk806.yaml          | 24 +++++++++++++++++++
>  .../bindings/mfd/rockchip,rk808.yaml          | 24 +++++++++++++++++++
>  .../bindings/mfd/rockchip,rk816.yaml          | 24 +++++++++++++++++++
>  .../bindings/mfd/rockchip,rk817.yaml          | 24 +++++++++++++++++++
>  .../bindings/mfd/rockchip,rk818.yaml          | 24 +++++++++++++++++++

Whoa! Is duplicating 200 lines really the best solution?

-- 
Lee Jones


WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee@kernel.org>
To: Yaozhong Li <yaozhonguwl@gmail.com>
Cc: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Heiko Stuebner <heiko@sntech.de>,
	Chris Zhong <zyw@rock-chips.com>,
	Zhang Qing <zhangqing@rock-chips.com>,
	Joseph Chen <chenjh@rock-chips.com>,
	Sebastian Reichel <sebastian.reichel@collabora.com>,
	mfd@lists.linux.dev, devicetree@vger.kernel.org,
	linux-rockchip@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 1/3] dt-bindings: mfd: rk8xx: add board level power hold GPIOs
Date: Tue, 27 Oct 2026 09:27:14 +0000	[thread overview]
Message-ID: <20261027092714.GH2195460@google.com> (raw)
In-Reply-To: <20261027084511.1992-2-yaozhonguwl@gmail.com>

On Tue, 27 Oct 2026, Yaozhong Li wrote:

> Some boards route "power hold" lines from the SoC into the board's power
> circuitry. Those lines have to be held asserted while the system is
> running and released before the PMIC shutdown request is written,
> otherwise the rails can drop and come back up instead of staying off.
> 
> Add power-hold-gpios to describe those lines and power-hold-delay-ms for
> the settle time. The driver reads them for every RK8xx variant that is
> the system power controller, so add them to all seven RK8xx schemas.
> 
> The array is bounded at two entries. Firefly's vendor kernel handles
> exactly two such lines, pmic,hold-gpio and pmic,stby-gpio, and its board
> files use one or both of them, with an RK808 and with an RK818.
> 
> The lines are released from the PMIC's power-off path, so they are only
> meaningful when the PMIC is the system power controller. Require that.
> A board adding these lines is expected to switch to the generic
> system-power-controller property at the same time, so the deprecated
> rockchip,system-power-controller spelling is not accepted here.
> 
> Assisted-by: LLM
> Signed-off-by: Yaozhong Li <yaozhonguwl@gmail.com>
> ---
>  .../bindings/mfd/rockchip,rk801.yaml          | 24 +++++++++++++++++++
>  .../bindings/mfd/rockchip,rk805.yaml          | 24 +++++++++++++++++++
>  .../bindings/mfd/rockchip,rk806.yaml          | 24 +++++++++++++++++++
>  .../bindings/mfd/rockchip,rk808.yaml          | 24 +++++++++++++++++++
>  .../bindings/mfd/rockchip,rk816.yaml          | 24 +++++++++++++++++++
>  .../bindings/mfd/rockchip,rk817.yaml          | 24 +++++++++++++++++++
>  .../bindings/mfd/rockchip,rk818.yaml          | 24 +++++++++++++++++++

Whoa! Is duplicating 200 lines really the best solution?

-- 
Lee Jones

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

  parent reply	other threads:[~2026-10-27  9:27 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-27  8:45 [PATCH v5 0/3] Fix poweroff restarting the board on Firefly-RK3399 Yaozhong Li
2026-10-27  8:45 ` Yaozhong Li
2026-10-27  8:45 ` [PATCH v5 1/3] dt-bindings: mfd: rk8xx: add board level power hold GPIOs Yaozhong Li
2026-10-27  8:45   ` Yaozhong Li
2026-10-27  8:55   ` sashiko-bot
2026-10-27  9:27   ` Lee Jones [this message]
2026-10-27  9:27     ` Lee Jones
2026-10-27  8:45 ` [PATCH v5 2/3] mfd: rk8xx: Release the power hold GPIOs before powering off Yaozhong Li
2026-10-27  8:45   ` Yaozhong Li
2026-10-27  8:45 ` [PATCH v5 3/3] arm64: dts: rockchip: fix power-off on Firefly-RK3399 Yaozhong Li
2026-10-27  8:45   ` Yaozhong Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261027092714.GH2195460@google.com \
    --to=lee@kernel.org \
    --cc=chenjh@rock-chips.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=heiko@sntech.de \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=mfd@lists.linux.dev \
    --cc=robh@kernel.org \
    --cc=sebastian.reichel@collabora.com \
    --cc=yaozhonguwl@gmail.com \
    --cc=zhangqing@rock-chips.com \
    --cc=zyw@rock-chips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.