All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Igor Velkov <iav@iav.lv>
Cc: Dafna Hirschfeld <dafna@fastmail.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Nicolas Dufresne <nicolas.dufresne@collabora.com>,
	Hans Verkuil <hverkuil@kernel.org>,
	Heiko Stuebner <heiko@sntech.de>,
	linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: rkisp1: Depend on PM
Date: Tue, 3 Nov 2026 01:12:06 +0200	[thread overview]
Message-ID: <20261102231206.GA3559911@killaraus.ideasonboard.com> (raw)
In-Reply-To: <20261103005500.rkisp1-pm-reply-1@iav.lv>

On Tue, Nov 03, 2026 at 02:55:00AM +0200, Igor Velkov wrote:
> On Mon, Nov 02, 2026, Laurent Pinchart wrote:
> > > ARCH_ROCKCHIP and arm64 ARCH_MXC select PM,
> >
> > Why do we need this patch then ?
> 
> Only COMPILE_TEST builds reach PM=n, and there the driver still binds and
> probe reads RKISP1_CIF_VI_ID with the clocks off.

What does the driver bind to when running on a system that has PM=n ? On
which platform can that happen ?

> Nicolas asked to close
> the PM=n case per driver [1]; rkcif already depends on PM. If you'd rather
> leave COMPILE_TEST-only configs alone, I'll drop it.
> 
> [1] https://lore.kernel.org/r/8aafdbbf04a0d939c6b4d7d5577d97bb58d1c439.camel@collabora.com

-- 
Regards,

Laurent Pinchart

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Igor Velkov <iav@iav.lv>
Cc: Dafna Hirschfeld <dafna@fastmail.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Nicolas Dufresne <nicolas.dufresne@collabora.com>,
	Hans Verkuil <hverkuil@kernel.org>,
	Heiko Stuebner <heiko@sntech.de>,
	linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: rkisp1: Depend on PM
Date: Tue, 3 Nov 2026 01:12:06 +0200	[thread overview]
Message-ID: <20261102231206.GA3559911@killaraus.ideasonboard.com> (raw)
In-Reply-To: <20261103005500.rkisp1-pm-reply-1@iav.lv>

On Tue, Nov 03, 2026 at 02:55:00AM +0200, Igor Velkov wrote:
> On Mon, Nov 02, 2026, Laurent Pinchart wrote:
> > > ARCH_ROCKCHIP and arm64 ARCH_MXC select PM,
> >
> > Why do we need this patch then ?
> 
> Only COMPILE_TEST builds reach PM=n, and there the driver still binds and
> probe reads RKISP1_CIF_VI_ID with the clocks off.

What does the driver bind to when running on a system that has PM=n ? On
which platform can that happen ?

> Nicolas asked to close
> the PM=n case per driver [1]; rkcif already depends on PM. If you'd rather
> leave COMPILE_TEST-only configs alone, I'll drop it.
> 
> [1] https://lore.kernel.org/r/8aafdbbf04a0d939c6b4d7d5577d97bb58d1c439.camel@collabora.com

-- 
Regards,

Laurent Pinchart

  reply	other threads:[~2026-11-02 23:12 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-02 17:49 [PATCH] media: rkisp1: Depend on PM Igor Velkov via B4 Relay
2026-11-02 17:49 ` Igor Velkov via B4 Relay
2026-11-02 17:49 ` Igor Velkov
2026-11-02 22:33 ` Laurent Pinchart
2026-11-02 22:33   ` Laurent Pinchart
2026-11-03  0:55   ` Igor Velkov
2026-11-03  0:55     ` Igor Velkov
2026-11-02 23:12     ` Laurent Pinchart [this message]
2026-11-02 23:12       ` Laurent Pinchart
2026-11-02 23:25       ` Igor Velkov
2026-11-02 23:25         ` Igor Velkov
2026-11-02 23:42         ` Laurent Pinchart
2026-11-02 23:42           ` Laurent Pinchart
2026-11-02 23:46     ` Nicolas Dufresne
2026-11-02 23:46       ` Nicolas Dufresne
2026-11-03  0:01       ` Igor Velkov
2026-11-03  0:01         ` Igor Velkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261102231206.GA3559911@killaraus.ideasonboard.com \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=dafna@fastmail.com \
    --cc=heiko@sntech.de \
    --cc=hverkuil@kernel.org \
    --cc=iav@iav.lv \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=mchehab@kernel.org \
    --cc=nicolas.dufresne@collabora.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.