From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Igor Velkov <iav@iav.lv>
Cc: Dafna Hirschfeld <dafna@fastmail.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Nicolas Dufresne <nicolas.dufresne@collabora.com>,
Hans Verkuil <hverkuil@kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: rkisp1: Depend on PM
Date: Tue, 3 Nov 2026 01:42:38 +0200 [thread overview]
Message-ID: <20261102234238.GD3559911@killaraus.ideasonboard.com> (raw)
In-Reply-To: <20261103-rkisp1-pm-reply-2@iav.lv>
On Tue, Nov 03, 2026 at 01:25:45AM +0200, Igor Velkov wrote:
> On Tue, Nov 03, 2026, Laurent Pinchart wrote:
> > What does the driver bind to when running on a system that has PM=n ? On
> > which platform can that happen ?
>
> None that I can name: the nodes exist only on Rockchip and i.MX8 boards,
> and those select PM. The patch came out of the rkvdec thread, where Nicolas
> pointed out that with PM=n the first MMIO access can hang and asked to
> check similar drivers [1]; rkisp1 and rga had the same pattern. If that
> case is not worth guarding, I'll drop it.
Given that it can't happen on any platform, I don't think the patch is
needed.
> [1] https://lore.kernel.org/r/8aafdbbf04a0d939c6b4d7d5577d97bb58d1c439.camel@collabora.com
--
Regards,
Laurent Pinchart
WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Igor Velkov <iav@iav.lv>
Cc: Dafna Hirschfeld <dafna@fastmail.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Nicolas Dufresne <nicolas.dufresne@collabora.com>,
Hans Verkuil <hverkuil@kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: rkisp1: Depend on PM
Date: Tue, 3 Nov 2026 01:42:38 +0200 [thread overview]
Message-ID: <20261102234238.GD3559911@killaraus.ideasonboard.com> (raw)
In-Reply-To: <20261103-rkisp1-pm-reply-2@iav.lv>
On Tue, Nov 03, 2026 at 01:25:45AM +0200, Igor Velkov wrote:
> On Tue, Nov 03, 2026, Laurent Pinchart wrote:
> > What does the driver bind to when running on a system that has PM=n ? On
> > which platform can that happen ?
>
> None that I can name: the nodes exist only on Rockchip and i.MX8 boards,
> and those select PM. The patch came out of the rkvdec thread, where Nicolas
> pointed out that with PM=n the first MMIO access can hang and asked to
> check similar drivers [1]; rkisp1 and rga had the same pattern. If that
> case is not worth guarding, I'll drop it.
Given that it can't happen on any platform, I don't think the patch is
needed.
> [1] https://lore.kernel.org/r/8aafdbbf04a0d939c6b4d7d5577d97bb58d1c439.camel@collabora.com
--
Regards,
Laurent Pinchart
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2026-11-02 23:42 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-02 17:49 [PATCH] media: rkisp1: Depend on PM Igor Velkov
2026-11-02 17:49 ` Igor Velkov via B4 Relay
2026-11-02 17:49 ` Igor Velkov via B4 Relay
2026-11-02 22:33 ` Laurent Pinchart
2026-11-02 22:33 ` Laurent Pinchart
2026-11-03 0:55 ` Igor Velkov
2026-11-03 0:55 ` Igor Velkov
2026-11-02 23:12 ` Laurent Pinchart
2026-11-02 23:12 ` Laurent Pinchart
2026-11-02 23:25 ` Igor Velkov
2026-11-02 23:25 ` Igor Velkov
2026-11-02 23:42 ` Laurent Pinchart [this message]
2026-11-02 23:42 ` Laurent Pinchart
2026-11-02 23:46 ` Nicolas Dufresne
2026-11-02 23:46 ` Nicolas Dufresne
2026-11-03 0:01 ` Igor Velkov
2026-11-03 0:01 ` Igor Velkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261102234238.GD3559911@killaraus.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=dafna@fastmail.com \
--cc=heiko@sntech.de \
--cc=hverkuil@kernel.org \
--cc=iav@iav.lv \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mchehab@kernel.org \
--cc=nicolas.dufresne@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.