From: "Enrique Hernández Bello" <ehbello@gmail.com>
To: shawn.lin@rock-chips.com, lpieralisi@kernel.org,
kwilczynski@kernel.org, mani@kernel.org, bhelgaas@google.com
Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
heiko@sntech.de, dlemoal@kernel.org, iav@iav.lv,
devicetree@vger.kernel.org, linux-pci@vger.kernel.org,
linux-rockchip@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
"Enrique Hernández Bello" <ehbello@gmail.com>
Subject: [PATCH v5 1/2] dt-bindings: PCI: rockchip,rk3399-pcie: Add PERST# inactive delay properties
Date: Wed, 4 Nov 2026 21:58:46 +0000 [thread overview]
Message-ID: <20261104215848.2087944-2-ehbello@gmail.com> (raw)
In-Reply-To: <20261104215848.2087944-1-ehbello@gmail.com>
The driver holds PERST# asserted for T_PVPERL (100 ms) before releasing it.
Endpoints disagree about what they want there: some need longer than the
default to settle, while others stop answering configuration reads when the
reset pulse is stretched that far, because PERST# stays asserted for the
whole wait.
Describe two properties so a board can state what its endpoint needs, named
after the ones the Rockchip vendor driver already uses for the dwc-based
controllers:
rockchip,perst-inactive-ms - the delay used at probe
rockchip,s2r-perst-inactive-ms - the delay used when resuming
Both are optional and the defaults preserve the current behaviour.
Signed-off-by: Enrique Hernández Bello <ehbello@gmail.com>
---
.../bindings/pci/rockchip,rk3399-pcie.yaml | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/Documentation/devicetree/bindings/pci/rockchip,rk3399-pcie.yaml b/Documentation/devicetree/bindings/pci/rockchip,rk3399-pcie.yaml
index 720a5f9..7ac915c 100644
--- a/Documentation/devicetree/bindings/pci/rockchip,rk3399-pcie.yaml
+++ b/Documentation/devicetree/bindings/pci/rockchip,rk3399-pcie.yaml
@@ -40,6 +40,21 @@ properties:
maxItems: 1
description: pre-reset GPIO
+ rockchip,perst-inactive-ms:
+ default: 100
+ description:
+ Time PERST# is held asserted before it is released, which is also the
+ width of the reset pulse. The default meets T_PVPERL for a slot that
+ is powered at the moment PERST# is asserted. Some endpoints need more
+ settling time than that, while others stop responding when the pulse
+ is that long. A value of 0 selects the 100 us minimum the PCI Express
+ CEM specification sets for the pulse.
+
+ rockchip,s2r-perst-inactive-ms:
+ description:
+ The same time, applied when resuming from system suspend. Defaults to
+ the value of rockchip,perst-inactive-ms.
+
vpcie12v-supply:
description: The 12v regulator to use for PCIe.
--
2.56.0
WARNING: multiple messages have this Message-ID (diff)
From: "Enrique Hernández Bello" <ehbello@gmail.com>
To: shawn.lin@rock-chips.com, lpieralisi@kernel.org,
kwilczynski@kernel.org, mani@kernel.org, bhelgaas@google.com
Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
heiko@sntech.de, dlemoal@kernel.org, iav@iav.lv,
devicetree@vger.kernel.org, linux-pci@vger.kernel.org,
linux-rockchip@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
"Enrique Hernández Bello" <ehbello@gmail.com>
Subject: [PATCH v5 1/2] dt-bindings: PCI: rockchip,rk3399-pcie: Add PERST# inactive delay properties
Date: Wed, 4 Nov 2026 21:58:46 +0000 [thread overview]
Message-ID: <20261104215848.2087944-2-ehbello@gmail.com> (raw)
In-Reply-To: <20261104215848.2087944-1-ehbello@gmail.com>
The driver holds PERST# asserted for T_PVPERL (100 ms) before releasing it.
Endpoints disagree about what they want there: some need longer than the
default to settle, while others stop answering configuration reads when the
reset pulse is stretched that far, because PERST# stays asserted for the
whole wait.
Describe two properties so a board can state what its endpoint needs, named
after the ones the Rockchip vendor driver already uses for the dwc-based
controllers:
rockchip,perst-inactive-ms - the delay used at probe
rockchip,s2r-perst-inactive-ms - the delay used when resuming
Both are optional and the defaults preserve the current behaviour.
Signed-off-by: Enrique Hernández Bello <ehbello@gmail.com>
---
.../bindings/pci/rockchip,rk3399-pcie.yaml | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/Documentation/devicetree/bindings/pci/rockchip,rk3399-pcie.yaml b/Documentation/devicetree/bindings/pci/rockchip,rk3399-pcie.yaml
index 720a5f9..7ac915c 100644
--- a/Documentation/devicetree/bindings/pci/rockchip,rk3399-pcie.yaml
+++ b/Documentation/devicetree/bindings/pci/rockchip,rk3399-pcie.yaml
@@ -40,6 +40,21 @@ properties:
maxItems: 1
description: pre-reset GPIO
+ rockchip,perst-inactive-ms:
+ default: 100
+ description:
+ Time PERST# is held asserted before it is released, which is also the
+ width of the reset pulse. The default meets T_PVPERL for a slot that
+ is powered at the moment PERST# is asserted. Some endpoints need more
+ settling time than that, while others stop responding when the pulse
+ is that long. A value of 0 selects the 100 us minimum the PCI Express
+ CEM specification sets for the pulse.
+
+ rockchip,s2r-perst-inactive-ms:
+ description:
+ The same time, applied when resuming from system suspend. Defaults to
+ the value of rockchip,perst-inactive-ms.
+
vpcie12v-supply:
description: The 12v regulator to use for PCIe.
--
2.56.0
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2026-11-04 21:58 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-04 21:58 [PATCH v5 0/2] PCI: rockchip-host: Make the PERST# inactive delay configurable Enrique Hernández Bello
2026-11-04 21:58 ` Enrique Hernández Bello
2026-11-04 21:58 ` Enrique Hernández Bello [this message]
2026-11-04 21:58 ` [PATCH v5 1/2] dt-bindings: PCI: rockchip,rk3399-pcie: Add PERST# inactive delay properties Enrique Hernández Bello
2026-11-04 22:06 ` sashiko-bot
2026-11-05 12:23 ` Krzysztof Kozlowski
2026-11-05 12:23 ` Krzysztof Kozlowski
2026-11-05 17:40 ` Enrique Hernández Bello
2026-11-05 17:40 ` Enrique Hernández Bello
2026-11-05 18:24 ` Krzysztof Kozlowski
2026-11-05 18:24 ` Krzysztof Kozlowski
2026-11-04 21:58 ` [PATCH v5 2/2] PCI: rockchip-host: Make the PERST# inactive delay configurable Enrique Hernández Bello
2026-11-04 21:58 ` Enrique Hernández Bello
2026-11-04 22:04 ` sashiko-bot
2026-11-05 1:44 ` [PATCH v5 0/2] " Igor Velkov
2026-11-05 1:44 ` Igor Velkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261104215848.2087944-2-ehbello@gmail.com \
--to=ehbello@gmail.com \
--cc=bhelgaas@google.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlemoal@kernel.org \
--cc=heiko@sntech.de \
--cc=iav@iav.lv \
--cc=krzk+dt@kernel.org \
--cc=kwilczynski@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
--cc=robh@kernel.org \
--cc=shawn.lin@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.