From: phucduc.bui@gmail.com
To: Andrew Jackson <Andrew.Jackson@arm.com>,
Mark Brown <broonie@kernel.org>,
Xingyu Wu <xingyu.wu@starfivetech.com>
Cc: Tim Bird <tim.bird@sony.com>,
Yuri Zaporozhets <yuriz@vodafonemail.de>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Maxim Kochetkov <fido_max@inbox.ru>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
bui duc phuc <phucduc.bui@gmail.com>
Subject: [PATCH 5/5] ASoC: dwc: Remove redundant error messages
Date: Fri, 6 Nov 2026 18:29:40 +0700 [thread overview]
Message-ID: <20261106112940.53550-6-phucduc.bui@gmail.com> (raw)
In-Reply-To: <20261106112940.53550-1-phucduc.bui@gmail.com>
From: bui duc phuc <phucduc.bui@gmail.com>
The underlying functions already report these errors deeper in
the call chain, making the additional dev_err_probe() and
dev_err() calls unnecessary.
Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>
---
sound/soc/dwc/dwc-i2s.c | 12 ++++--------
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/sound/soc/dwc/dwc-i2s.c b/sound/soc/dwc/dwc-i2s.c
index 1ff5b6f8864d..87b47661e469 100644
--- a/sound/soc/dwc/dwc-i2s.c
+++ b/sound/soc/dwc/dwc-i2s.c
@@ -752,7 +752,7 @@ static int jh7110_i2s_crg_master_init(struct dw_i2s_dev *dev)
ret = clk_bulk_get(dev->dev, ARRAY_SIZE(clks), clks);
if (ret)
- return dev_err_probe(dev->dev, ret, "failed to get i2s clocks\n");
+ return ret;
mclk = clks[0].clk;
mclk_ext = clks[1].clk;
@@ -830,7 +830,7 @@ static int jh7110_i2s_crg_slave_init(struct dw_i2s_dev *dev)
ret = clk_bulk_get(dev->dev, ARRAY_SIZE(clks), clks);
if (ret)
- return dev_err_probe(dev->dev, ret, "failed to get i2s clocks\n");
+ return ret;
mclk = clks[0].clk;
mclk_ext = clks[1].clk;
@@ -966,10 +966,8 @@ static int dw_i2s_probe(struct platform_device *pdev)
if (irq > 0) {
ret = devm_request_irq(&pdev->dev, irq, i2s_irq_handler, 0,
pdev->name, dev);
- if (ret < 0) {
- dev_err(&pdev->dev, "failed to request irq\n");
+ if (ret < 0)
goto err_assert_reset;
- }
}
dev->i2s_reg_comp1 = I2S_COMP_PARAM_1;
@@ -1010,10 +1008,8 @@ static int dw_i2s_probe(struct platform_device *pdev)
dev_set_drvdata(&pdev->dev, dev);
ret = devm_snd_soc_register_component(&pdev->dev, &dw_i2s_component,
dw_i2s_dai, 1);
- if (ret != 0) {
- dev_err(&pdev->dev, "not able to register dai\n");
+ if (ret)
goto err_assert_reset;
- }
if (!pdata || dev->is_jh7110) {
if (irq >= 0) {
--
2.43.0
next prev parent reply other threads:[~2026-11-06 11:30 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-06 11:29 [PATCH 0/5] Fix several issues in the DesignWare I2S driver phucduc.bui
2026-11-06 11:29 ` [PATCH 1/5] ASoC: dwc: Fix bit clock rate in TDM mode phucduc.bui
2026-11-09 7:10 ` Maxim Kochetkov
2026-11-10 6:53 ` Bui Duc Phuc
2026-11-06 11:29 ` [PATCH 2/5] ASoC: dwc: Fix error handling in dw_i2s_set_fmt() phucduc.bui
2026-11-09 7:19 ` Maxim Kochetkov
2026-11-10 6:55 ` Bui Duc Phuc
2026-11-06 11:29 ` [PATCH 3/5] ASoC: dwc: Fix channels_max derived from COMP_PARAM_1 phucduc.bui
2026-11-09 7:23 ` Maxim Kochetkov
2026-11-06 11:29 ` [PATCH 4/5] ASoC: dwc: Fix DMA fifo_size calculation phucduc.bui
2026-11-06 11:39 ` sashiko-bot
2026-11-06 11:29 ` phucduc.bui [this message]
2026-11-06 11:43 ` [PATCH 5/5] ASoC: dwc: Remove redundant error messages sashiko-bot
2026-11-09 5:01 ` Bui Duc Phuc
2026-11-08 14:05 ` Mark Brown
2026-11-09 2:59 ` Bui Duc Phuc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261106112940.53550-6-phucduc.bui@gmail.com \
--to=phucduc.bui@gmail.com \
--cc=Andrew.Jackson@arm.com \
--cc=broonie@kernel.org \
--cc=fido_max@inbox.ru \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tim.bird@sony.com \
--cc=tiwai@suse.com \
--cc=xingyu.wu@starfivetech.com \
--cc=yuriz@vodafonemail.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.