From: sashiko-bot@kernel.org
To: phucduc.bui@gmail.com
Cc: linux-sound@vger.kernel.org
Subject: Re: [PATCH 4/5] ASoC: dwc: Fix DMA fifo_size calculation
Date: Fri, 06 Nov 2026 11:39:05 +0000 [thread overview]
Message-ID: <sashiko-outbox-201325@kernel.org> (raw)
In-Reply-To: <20261106112940.53550-5-phucduc.bui@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] ASoC: dwc: missing Fixes trailer for dw_configure_dai_by_dt()
fifo_size bug
--
commit 8358dacf329eafc6bd36da9f372ae4682d156a1c
Author: bui duc phuc <phucduc.bui@gmail.com>
> ASoC: dwc: Fix DMA fifo_size calculation
>
> fifo_size should be the FIFO size in bytes (depth * width / 8), but
> the code shifts by 8 instead of 3. For capture the parentheses also
> make it always 0.
>
> Use depth * width / 8 for both directions.
>
> Fixes: 52ea7c0543f8 ("ASoC: dwc: i2s: Add StarFive JH7110 SoC support")
> Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>
[Severity: Low]
52ea7c0543f8 ("ASoC: dwc: i2s: Add StarFive JH7110 SoC support") only
copied the broken fifo_size calculation into dw_configure_dai_by_pd(),
whereas the original bug in dw_configure_dai_by_dt() dates back earlier.
Should this also include:
Fixes: 0d274544bfee ("ASoC: dwc: Add devicetree support for Designware I2S")
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261106112940.53550-1-phucduc.bui@gmail.com?part=4
next prev parent reply other threads:[~2026-11-06 11:39 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-06 11:29 [PATCH 0/5] Fix several issues in the DesignWare I2S driver phucduc.bui
2026-11-06 11:29 ` [PATCH 1/5] ASoC: dwc: Fix bit clock rate in TDM mode phucduc.bui
2026-11-09 7:10 ` Maxim Kochetkov
2026-11-10 6:53 ` Bui Duc Phuc
2026-11-06 11:29 ` [PATCH 2/5] ASoC: dwc: Fix error handling in dw_i2s_set_fmt() phucduc.bui
2026-11-09 7:19 ` Maxim Kochetkov
2026-11-10 6:55 ` Bui Duc Phuc
2026-11-06 11:29 ` [PATCH 3/5] ASoC: dwc: Fix channels_max derived from COMP_PARAM_1 phucduc.bui
2026-11-09 7:23 ` Maxim Kochetkov
2026-11-06 11:29 ` [PATCH 4/5] ASoC: dwc: Fix DMA fifo_size calculation phucduc.bui
2026-11-06 11:39 ` sashiko-bot [this message]
2026-11-06 11:29 ` [PATCH 5/5] ASoC: dwc: Remove redundant error messages phucduc.bui
2026-11-06 11:43 ` sashiko-bot
2026-11-09 5:01 ` Bui Duc Phuc
2026-11-08 14:05 ` Mark Brown
2026-11-09 2:59 ` Bui Duc Phuc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-201325@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=phucduc.bui@gmail.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.