Re: [PATCH 5/5] ASoC: dwc: Remove redundant error messages

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found no new issues
in this patch, but noticed 1 related pre-existing issue it does not
introduce:
- [Critical] ASoC: dwc: use-after-free in jh7110_i2s_crg_master_init()
  [1]
--

commit 5c9147e66967380d8d14ec0323b003b6d572821e
Author: bui duc phuc <phucduc.bui@gmail.com>

ASoC: dwc: Remove redundant error messages

This commit removes dev_err_probe() and dev_err() calls in the DesignWare I2S
driver where the underlying helper functions already log errors on failure.

> diff --git a/sound/soc/dwc/dwc-i2s.c b/sound/soc/dwc/dwc-i2s.c
> index 1ff5b6f8864d6..87b47661e4698 100644
> --- a/sound/soc/dwc/dwc-i2s.c
> +++ b/sound/soc/dwc/dwc-i2s.c
> @@ -752,7 +752,7 @@ static int jh7110_i2s_crg_master_init(struct dw_i2s_dev *dev)
>  
>  	ret = clk_bulk_get(dev->dev, ARRAY_SIZE(clks), clks);
>  	if (ret)
> -		return dev_err_probe(dev->dev, ret, "failed to get i2s clocks\n");
> +		return ret;
>  
>  	mclk = clks[0].clk;
>  	mclk_ext = clks[1].clk;
> @@ -830,7 +830,7 @@ static int jh7110_i2s_crg_slave_init(struct dw_i2s_dev *dev)
>  
>  	ret = clk_bulk_get(dev->dev, ARRAY_SIZE(clks), clks);
>  	if (ret)
> -		return dev_err_probe(dev->dev, ret, "failed to get i2s clocks\n");
> +		return ret;
>  
>  	mclk = clks[0].clk;
>  	mclk_ext = clks[1].clk;

[Severity: Critical]
This problem wasn't introduced by this patch, but can concurrent probes
clobber the static clks[] arrays [1] in jh7110_i2s_crg_master_init()
and jh7110_i2s_crg_slave_init()?

Both functions declare their struct clk_bulk_data clks[] array as static,
so clk_bulk_get() writes per-device struct clk pointers into shared state.
If two I2S instances probe concurrently, one overwrites the other's clock
pointers in clks[], causing subsequent clk_bulk_put() calls to leak the
overwritten references and release the remaining ones multiple times,
leading to a use-after-free.

[1] https://sashiko.dev/#/bug/linux-89ddb741-fe78-4a6e-bfd0-66e1730f7ed2

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261106112940.53550-1-phucduc.bui@gmail.com?part=5