From: Gabriel Gama <operatingsystemsdepression@gmail.com>
To: dri-devel@lists.freedesktop.org
Cc: patrik.r.jakobsson@gmail.com
Subject: [RFC PATCH v2 2/6] drm/gma500: do not underflow an unpinned GEM object
Date: Mon, 9 Nov 2026 03:32:59 -0300 [thread overview]
Message-ID: <20261109063303.32658-3-operatingsystemsdepression@gmail.com> (raw)
In-Reply-To: <20261109063303.32658-1-operatingsystemsdepression@gmail.com>
Return after warning if psb_gem_unpin() is called without a pin.
Decrementing zero makes in_gart negative, so later pins incorrectly skip
backing-page and mapping setup. Release the reservation lock normally.
Signed-off-by: Gabriel Gama <operatingsystemsdepression@gmail.com>
---
drivers/gpu/drm/gma500/gem.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/gma500/gem.c b/drivers/gpu/drm/gma500/gem.c
index 7250bf660..fa5d3f137 100644
--- a/drivers/gpu/drm/gma500/gem.c
+++ b/drivers/gpu/drm/gma500/gem.c
@@ -85,7 +85,8 @@ void psb_gem_unpin(struct psb_gem_object *pobj)
if (drm_WARN_ONCE(dev, ret, "dma_resv_lock() failed, ret=%d\n", ret))
return;
- WARN_ON(!pobj->in_gart);
+ if (WARN_ON(!pobj->in_gart))
+ goto out;
--pobj->in_gart;
next prev parent reply other threads:[~2026-11-09 6:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-09 6:32 [RFC PATCH v2 0/6] drm/gma500: prepare GEM and MMU for 3D rendering and hybrid 2D Gabriel Gama
2026-11-09 6:32 ` [RFC PATCH v2 1/6] drm/gma500: use the common dumb-buffer size helper Gabriel Gama
2026-11-12 21:20 ` Joseph Telaak
2026-11-09 6:32 ` Gabriel Gama [this message]
2026-11-12 21:17 ` [RFC PATCH v2 2/6] drm/gma500: do not underflow an unpinned GEM object Joseph Telaak
2026-11-09 6:33 ` [RFC PATCH v2 3/6] drm/gma500: Fix SGX page-table cache-flush mapping lifetime Gabriel Gama
2026-11-12 21:20 ` Joseph Telaak
2026-11-09 6:33 ` [RFC PATCH v2 4/6] drm/gma500: Make SGX MMU insertion checked and transactional Gabriel Gama
2026-11-09 6:41 ` sashiko-bot
2026-11-12 21:20 ` Joseph Telaak
2026-11-09 6:33 ` [RFC PATCH v2 5/6] drm/gma500: Propagate SGX MMU setup and GEM pin failures Gabriel Gama
2026-11-12 21:20 ` Joseph Telaak
2026-11-13 2:17 ` Gabriel Gama
2026-11-09 6:33 ` [RFC PATCH v2 6/6] drm/gma500: Add software-only KUnit coverage for SGX page tables Gabriel Gama
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261109063303.32658-3-operatingsystemsdepression@gmail.com \
--to=operatingsystemsdepression@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=patrik.r.jakobsson@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.