Re: [RFC PATCH v2 4/6] drm/gma500: Make SGX MMU insertion checked and transactional

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] drm/gma500: missing Fixes trailer for SGX MMU page-table bug
  fixes
--

commit b5c47bf3ab6f62c803717a8b203c45789315c003
Author: Gabriel Gama <operatingsystemsdepression@gmail.com>

> drm/gma500: Make SGX MMU insertion checked and transactional
>
> Validate 32-bit mapping extents, PFNs and tiled geometry before changing
> PTEs. Serialize changes with the write semaphore and undo only the
> inserted prefix on allocation failure or collision, preserving existing
> entries. Do not allocate tables or decrement counts when removing holes.
>
> Use 64-bit exclusive endpoints so mapping the last GPU page does not wrap
> on i386. Zero-page requests remain no-ops.
>
> Signed-off-by: Gabriel Gama <operatingsystemsdepression@gmail.com>

[Severity: Low]
This fixes several bugs in SGX MMU page-table management, such as
allocating page tables and underflowing pt->count when removing unmapped
holes, wrapping 32-bit endpoints on i386, and taking driver->sem in read
mode during PTE updates.  Should this include a Fixes tag?

  Fixes: 8c8f1c958ab5 ("gma500: introduce the GTT and MMU handling logic")

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261109063303.32658-1-operatingsystemsdepression@gmail.com?part=4