From: Eric Biggers <ebiggers@kernel.org>
To: Andrey Albershteyn <aalbersh@kernel.org>
Cc: hch@lst.de, fsverity@lists.linux.dev, dsterba@suse.com,
linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org,
brauner@kernel.org, viro@zeniv.linux.org.uk, jaegeuk@kernel.org,
chao@kernel.org, tytso@mit.edu
Subject: Re: [PATCH v2 2/5] fsverity: add I_VERITY_BUILDING inode state flag
Date: Tue, 10 Nov 2026 14:37:41 -0800 [thread overview]
Message-ID: <20261110223741.GE1907@quark> (raw)
In-Reply-To: <20261110223526.GD1907@quark>
On Tue, Nov 10, 2026 at 02:35:26PM -0800, Eric Biggers wrote:
> On Thu, Nov 05, 2026 at 12:55:27PM +0100, Andrey Albershteyn wrote:
> > + } else if (inode_state_read_once(inode) & I_VERITY_BUILDING) {
>
> fsverity_is_building()?
>
> > +static inline bool fsverity_is_building(const struct inode *inode)
> > +{
> > + return inode_state_read_once((struct inode *)inode) & I_VERITY_BUILDING;
> > +}
>
> It would make more sense for inode_state_read_once() itself to take
> 'const struct inode *'. Then the cast wouldn't be needed.
Also, we should include an IS_ENABLED(CONFIG_FS_VERITY) check here, so
that it gets compiled away to nothing if CONFIG_FS_VERITY is disabled.
- Eric
WARNING: multiple messages have this Message-ID (diff)
From: Eric Biggers via Linux-f2fs-devel <linux-f2fs-devel@lists.sourceforge.net>
To: Andrey Albershteyn <aalbersh@kernel.org>
Cc: fsverity@lists.linux.dev, brauner@kernel.org, tytso@mit.edu,
linux-f2fs-devel@lists.sourceforge.net,
linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
viro@zeniv.linux.org.uk, dsterba@suse.com, jaegeuk@kernel.org,
linux-ext4@vger.kernel.org, hch@lst.de,
linux-btrfs@vger.kernel.org
Subject: Re: [f2fs-dev] [PATCH v2 2/5] fsverity: add I_VERITY_BUILDING inode state flag
Date: Tue, 10 Nov 2026 14:37:41 -0800 [thread overview]
Message-ID: <20261110223741.GE1907@quark> (raw)
In-Reply-To: <20261110223526.GD1907@quark>
On Tue, Nov 10, 2026 at 02:35:26PM -0800, Eric Biggers wrote:
> On Thu, Nov 05, 2026 at 12:55:27PM +0100, Andrey Albershteyn wrote:
> > + } else if (inode_state_read_once(inode) & I_VERITY_BUILDING) {
>
> fsverity_is_building()?
>
> > +static inline bool fsverity_is_building(const struct inode *inode)
> > +{
> > + return inode_state_read_once((struct inode *)inode) & I_VERITY_BUILDING;
> > +}
>
> It would make more sense for inode_state_read_once() itself to take
> 'const struct inode *'. Then the cast wouldn't be needed.
Also, we should include an IS_ENABLED(CONFIG_FS_VERITY) check here, so
that it gets compiled away to nothing if CONFIG_FS_VERITY is disabled.
- Eric
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2026-11-10 22:37 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-05 11:55 [PATCH v2 0/5] fsverity: lift ioctl() input masking and runtime inode flag to VFS Andrey Albershteyn
2026-11-05 11:55 ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-11-05 11:55 ` [PATCH v2 1/5] fsverity: strip FS_VERITY_FL from FS_IOC_SETFLAGS Andrey Albershteyn
2026-11-05 11:55 ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-11-05 12:03 ` sashiko-bot
2026-11-05 12:03 ` sashiko-bot--- via Linux-f2fs-devel
2026-11-06 10:26 ` Christoph Hellwig
2026-11-06 10:26 ` [f2fs-dev] " Christoph Hellwig
2026-11-10 22:32 ` Eric Biggers
2026-11-10 22:32 ` [f2fs-dev] " Eric Biggers via Linux-f2fs-devel
2026-11-05 11:55 ` [PATCH v2 2/5] fsverity: add I_VERITY_BUILDING inode state flag Andrey Albershteyn
2026-11-05 11:55 ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-11-05 12:03 ` sashiko-bot
2026-11-05 12:03 ` sashiko-bot--- via Linux-f2fs-devel
2026-11-06 10:26 ` Christoph Hellwig
2026-11-06 10:26 ` [f2fs-dev] " Christoph Hellwig
2026-11-10 22:35 ` Eric Biggers
2026-11-10 22:35 ` [f2fs-dev] " Eric Biggers via Linux-f2fs-devel
2026-11-10 22:37 ` Eric Biggers [this message]
2026-11-10 22:37 ` Eric Biggers via Linux-f2fs-devel
2026-11-10 22:40 ` Eric Biggers
2026-11-10 22:40 ` [f2fs-dev] " Eric Biggers via Linux-f2fs-devel
2026-11-10 22:57 ` Eric Biggers
2026-11-10 22:57 ` [f2fs-dev] " Eric Biggers via Linux-f2fs-devel
2026-11-05 11:55 ` [PATCH v2 3/5] btrfs: use I_VERITY_BUILDING instead of private flags Andrey Albershteyn
2026-11-05 11:55 ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-11-05 12:03 ` sashiko-bot
2026-11-06 10:26 ` Christoph Hellwig
2026-11-06 10:26 ` [f2fs-dev] " Christoph Hellwig
2026-11-05 11:55 ` [PATCH v2 4/5] ext4: " Andrey Albershteyn
2026-11-05 11:55 ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-11-05 12:01 ` sashiko-bot
2026-11-05 12:01 ` sashiko-bot--- via Linux-f2fs-devel
2026-11-06 10:27 ` Christoph Hellwig
2026-11-06 10:27 ` [f2fs-dev] " Christoph Hellwig
2026-11-10 23:01 ` Eric Biggers
2026-11-10 23:01 ` [f2fs-dev] " Eric Biggers via Linux-f2fs-devel
2026-11-05 11:55 ` [PATCH v2 5/5] f2fs: " Andrey Albershteyn
2026-11-05 11:55 ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-11-05 12:03 ` sashiko-bot
2026-11-05 12:03 ` sashiko-bot--- via Linux-f2fs-devel
2026-11-06 10:27 ` Christoph Hellwig
2026-11-06 10:27 ` [f2fs-dev] " Christoph Hellwig
2026-11-10 23:03 ` Eric Biggers via Linux-f2fs-devel
2026-11-10 23:03 ` Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261110223741.GE1907@quark \
--to=ebiggers@kernel.org \
--cc=aalbersh@kernel.org \
--cc=brauner@kernel.org \
--cc=chao@kernel.org \
--cc=dsterba@suse.com \
--cc=fsverity@lists.linux.dev \
--cc=hch@lst.de \
--cc=jaegeuk@kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.