All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Günther Noack" <gnoack3000@gmail.com>
To: Kuniyuki Iwashima <kuniyu@google.com>
Cc: Alejandro Colomar <alx+linux-man@kernel.org>,
	linux-man@vger.kernel.org,
	Michael Kerrisk <mtk.manpages@gmail.com>,
	Eric Dumazet <edumazet@kernel.org>,
	Paolo Abeni <pabeni@redhat.com>,
	Willem de Bruijn <willemb@google.com>
Subject: Re: [PATCH v2 4/8] man/man7/unix.7: SCM_SECURITY: Generalize to other LSMs, not just SELinux
Date: Mon, 16 Nov 2026 08:35:57 +0100	[thread overview]
Message-ID: <20261116.34a1603ed035@gnoack.org> (raw)
In-Reply-To: <avpUW_zBBph5d40d@google.com>

Thank you for the review!

On Mon, Nov 16, 2026 at 12:55:26AM +0000, Kuniyuki Iwashima wrote:
> On Tue, 03 Nov 2026 21:22:06 +0100, Günther Noack wrote:
> > [...]
> >
> > diff --git a/man/man7/unix.7 b/man/man7/unix.7
> > index 61f06a74359b..c0e2bdbacdd8 100644
> > --- a/man/man7/unix.7
> > +++ b/man/man7/unix.7
> > @@ -538,13 +538,16 @@ .SS Ancillary messages
> >  option must be enabled on the socket.
> >  .TP
> >  .B SCM_SECURITY
> > -Receive the SELinux security context (the security label)
> > -of the peer socket.
> > -The received ancillary data is a null-terminated string containing
> > -the security context.
> > -The receiver should allocate at least
> > -.B NAME_MAX
> > -bytes in the data portion of the ancillary message for this data.
> > +Receive the security context (the security label)
> > +of the peer socket,
> > +as provided by the active Linux Security Module (LSM).
> > +The received ancillary data is a byte buffer.
> > +.IP
> > +The exact format of the security context buffer
> > +is defined by the active major LSM.
> > +For example,
> > +SELinux returns a SELinux label as a string
> > +(including a terminating null byte).
> 
> nit: s/null/NUL/
> 
> otherwise looks good
> 
> Reviewed-by: Kuniyuki Iwashima <kuniyu@google.com>

The "null byte" is spelled in line with the man-pages(7) conventions
for consistency, where it says:

  The preferred term for the byte is "null byte".  Avoid writing
  "NUL", since it is too easily confused with "NULL".

So unless you feel strongly about it, I would prefer to keep it as is.

–Günther

  reply	other threads:[~2026-11-16  7:36 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-03 20:22 [PATCH v2 0/8] unix.7: Socket Options and SCM_* fixes Günther Noack
2026-11-03 20:22 ` [PATCH v2 1/8] man/man7/unix.7: ERRORS: ETOOMANYREFS: Fix the conditions Günther Noack
2026-11-06 13:00   ` Alejandro Colomar
2026-11-03 20:22 ` [PATCH v2 2/8] man/man7/unix.7: Multiple same-typed SCM_* messages may be sent in one message Günther Noack
2026-11-16  0:52   ` Kuniyuki Iwashima
2026-11-18  0:59     ` Alejandro Colomar
2026-11-03 20:22 ` [PATCH v2 3/8] man/man7/unix.7: Autobind: Clarify when it happens, and mention SO_PASSPIDFD Günther Noack
2026-11-16  0:53   ` Kuniyuki Iwashima
2026-11-18  1:06     ` Alejandro Colomar
2026-11-03 20:22 ` [PATCH v2 4/8] man/man7/unix.7: SCM_SECURITY: Generalize to other LSMs, not just SELinux Günther Noack
2026-11-16  0:55   ` Kuniyuki Iwashima
2026-11-16  7:35     ` Günther Noack [this message]
2026-11-18  1:15       ` Alejandro Colomar
2026-11-18  1:13   ` Alejandro Colomar
2026-11-03 20:22 ` [PATCH v2 5/8] man/man7/unix.7: SO_PASSSEC: wfix Günther Noack
2026-11-03 20:22 ` [PATCH v2 6/8] man/man7/unix.7: Document SO_PASSPIDFD, SO_PEERPIDFD, and SCM_PIDFD Günther Noack
2026-11-16  1:03   ` Kuniyuki Iwashima
2026-11-03 20:22 ` [PATCH v2 7/8] man/man7/unix.7: Document SO_PASSRIGHTS Günther Noack
2026-11-16  1:02   ` Kuniyuki Iwashima
2026-11-03 20:22 ` [PATCH v2 8/8] man/man7/unix.7: Remove mentions of "namespace" in the general sense Günther Noack
2026-11-16  0:59   ` Kuniyuki Iwashima

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261116.34a1603ed035@gnoack.org \
    --to=gnoack3000@gmail.com \
    --cc=alx+linux-man@kernel.org \
    --cc=edumazet@kernel.org \
    --cc=kuniyu@google.com \
    --cc=linux-man@vger.kernel.org \
    --cc=mtk.manpages@gmail.com \
    --cc=pabeni@redhat.com \
    --cc=willemb@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.