All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alejandro Colomar <alx+linux-man@kernel.org>
To: Kuniyuki Iwashima <kuniyu@google.com>
Cc: "Günther Noack" <gnoack3000@gmail.com>,
	linux-man@vger.kernel.org,
	"Michael Kerrisk" <mtk.manpages@gmail.com>
Subject: Re: [PATCH v2 2/8] man/man7/unix.7: Multiple same-typed SCM_* messages may be sent in one message
Date: Wed, 18 Nov 2026 01:59:56 +0100	[thread overview]
Message-ID: <avz4awkoCeYWYGeW@devuan> (raw)
In-Reply-To: <avpTxVySkPfwWolT@google.com>

[-- Attachment #1: Type: text/plain, Size: 1489 bytes --]

Hi Kuniyuki, Günther!

> Date: 2026-11-16 00:52:32+0000
> From: Kuniyuki Iwashima <kuniyu@google.com>
>
> On Tue, 03 Nov 2026 21:22:04 +0100, Günther Noack wrote:
> > In the Linux kernel code, __scm_send() in linux.git net/core/scm.c
> > walks all control messages in a loop like this:
> > 
> > 	for_each_cmsghdr(cmsg, msg) {
> > 		// ...
> > 		switch (cmsg->cmsg_type)
> > 		{
> > 		case SCM_RIGHTS:
> > 			... append(!) file descriptors
> > 			    up to the SCM_MAX_FD limit ...
> > 			break;
> > 		case SCM_CREDENTIALS:
> > 			... replace previously set credentials ...
> > 			break;
> > 		default:
> > 			goto error;
> > 		}
> > 	}
> > 
> > So it is possible to pass multiple SCM_* messages -- they will compose
> > if possible and override the previous value if not.  Since their
> > contents are being conflated that way, they will appear as one message
> > again on the receiving side.
> > 
> > Keep the recommendation as portability advice, and describe the Linux
> > behavior.
> > 
> > Fixes: 5b5cb1958062 (2018-07-10; "unix.7: When sending ancillary data, only one item of each type may be sent")
> > Cc: Michael Kerrisk <mtk.manpages@gmail.com>
> > Cc: Kuniyuki Iwashima <kuniyu@google.com>
> > Assisted-by: LLM
> > Signed-off-by: Günther Noack <gnoack3000@gmail.com>
> 
> Reviewed-by: Kuniyuki Iwashima <kuniyu@google.com>

Thanks!  I've applied the patch.


Have a lovely night!
Alex

-- 
<https://www.alejandro-colomar.es>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2026-11-18  1:00 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-03 20:22 [PATCH v2 0/8] unix.7: Socket Options and SCM_* fixes Günther Noack
2026-11-03 20:22 ` [PATCH v2 1/8] man/man7/unix.7: ERRORS: ETOOMANYREFS: Fix the conditions Günther Noack
2026-11-06 13:00   ` Alejandro Colomar
2026-11-03 20:22 ` [PATCH v2 2/8] man/man7/unix.7: Multiple same-typed SCM_* messages may be sent in one message Günther Noack
2026-11-16  0:52   ` Kuniyuki Iwashima
2026-11-18  0:59     ` Alejandro Colomar [this message]
2026-11-03 20:22 ` [PATCH v2 3/8] man/man7/unix.7: Autobind: Clarify when it happens, and mention SO_PASSPIDFD Günther Noack
2026-11-16  0:53   ` Kuniyuki Iwashima
2026-11-18  1:06     ` Alejandro Colomar
2026-11-03 20:22 ` [PATCH v2 4/8] man/man7/unix.7: SCM_SECURITY: Generalize to other LSMs, not just SELinux Günther Noack
2026-11-16  0:55   ` Kuniyuki Iwashima
2026-11-16  7:35     ` Günther Noack
2026-11-18  1:15       ` Alejandro Colomar
2026-11-18  1:13   ` Alejandro Colomar
2026-11-03 20:22 ` [PATCH v2 5/8] man/man7/unix.7: SO_PASSSEC: wfix Günther Noack
2026-11-03 20:22 ` [PATCH v2 6/8] man/man7/unix.7: Document SO_PASSPIDFD, SO_PEERPIDFD, and SCM_PIDFD Günther Noack
2026-11-16  1:03   ` Kuniyuki Iwashima
2026-11-03 20:22 ` [PATCH v2 7/8] man/man7/unix.7: Document SO_PASSRIGHTS Günther Noack
2026-11-16  1:02   ` Kuniyuki Iwashima
2026-11-03 20:22 ` [PATCH v2 8/8] man/man7/unix.7: Remove mentions of "namespace" in the general sense Günther Noack
2026-11-16  0:59   ` Kuniyuki Iwashima

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=avz4awkoCeYWYGeW@devuan \
    --to=alx+linux-man@kernel.org \
    --cc=gnoack3000@gmail.com \
    --cc=kuniyu@google.com \
    --cc=linux-man@vger.kernel.org \
    --cc=mtk.manpages@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.