All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daeho Jeong <daeho43@gmail.com>
To: linux-kernel@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net, kernel-team@android.com
Cc: Daeho Jeong <daehojeong@google.com>
Subject: [PATCH v2 09/20] f2fs: support subpage blocks in pinned files
Date: Sun, 15 Nov 2026 20:08:40 -0800	[thread overview]
Message-ID: <20261116040851.2849696-10-daeho43@gmail.com> (raw)
In-Reply-To: <20261116040851.2849696-1-daeho43@gmail.com>

From: Daeho Jeong <daehojeong@google.com>

Pinned files must not allocate blocks outside fallocate(). As write()
does, return -EIO from page_mkwrite when the folio range up to EOF is
not fully allocated, and remove the -EOPNOTSUPP checks.

page_mkwrite keeps failing a device aliasing file with -EIO, as it does
when the block size equals PAGE_SIZE. Its block addresses are only in
the extent cache, so f2fs_overwrite_io() does not catch it.

Signed-off-by: Daeho Jeong <daehojeong@google.com>
---
 fs/f2fs/file.c | 22 ++++++++++++++++------
 1 file changed, 16 insertions(+), 6 deletions(-)

diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
index bec7988ca54b..72c601d240d4 100644
--- a/fs/f2fs/file.c
+++ b/fs/f2fs/file.c
@@ -142,7 +142,8 @@ static vm_fault_t f2fs_vm_page_mkwrite(struct vm_fault *vmf)
 	struct folio *folio = page_folio(vmf->page);
 	struct inode *inode = file_inode(vmf->vma->vm_file);
 	struct f2fs_sb_info *sbi = F2FS_I_SB(inode);
-	bool need_alloc = !f2fs_is_pinned_file(inode);
+	bool pinned = f2fs_is_pinned_file(inode);
+	bool need_alloc = !pinned;
 	pgoff_t pidx = folio->index + folio_page_idx(folio, vmf->page);
 	loff_t pos = (loff_t)pidx << PAGE_SHIFT;
 	pgoff_t bidx = F2FS_BYTES_TO_BLK(sbi, pos);
@@ -245,6 +246,19 @@ static vm_fault_t f2fs_vm_page_mkwrite(struct vm_fault *vmf)
 	nr = DIV_ROUND_UP(dirty_len, PAGE_SIZE);
 
 	if (f2fs_has_subpage_blocks(sbi)) {
+		/*
+		 * A device aliasing file has its block addresses only in the
+		 * extent cache, where f2fs_overwrite_io() finds them. Fail it
+		 * as f2fs_get_block_mkwrite() does.
+		 */
+		if (pinned &&
+		    (IS_DEVICE_ALIASING(inode) ||
+		     !f2fs_overwrite_io(inode, folio_pos(folio), dirty_len))) {
+			folio_unlock(folio);
+			err = -EIO;
+			goto out_sem;
+		}
+
 		/*
 		 * A writable PTE covers the whole base folio.  Like ext4's
 		 * block_page_mkwrite(), prepare every filesystem block through EOF
@@ -2285,8 +2299,7 @@ static long f2fs_fallocate(struct file *file, int mode,
 
 	if (f2fs_has_subpage_blocks(F2FS_I_SB(inode))) {
 		if ((mode & (FALLOC_FL_COLLAPSE_RANGE | FALLOC_FL_INSERT_RANGE)) ||
-		    f2fs_is_pinned_file(inode) || f2fs_is_atomic_file(inode) ||
-		    f2fs_compressed_file(inode)) {
+		    f2fs_is_atomic_file(inode) || f2fs_compressed_file(inode)) {
 			ret = -EOPNOTSUPP;
 			goto out;
 		}
@@ -3828,9 +3841,6 @@ static int f2fs_ioc_set_pin_file(struct file *filp, unsigned long arg)
 	__u32 pin;
 	int ret = 0;
 
-	if (f2fs_has_subpage_blocks(sbi))
-		return -EOPNOTSUPP;
-
 	if (get_user(pin, (__u32 __user *)arg))
 		return -EFAULT;
 
-- 
2.56.0.611.g1030f0b940-goog


WARNING: multiple messages have this Message-ID (diff)
From: Daeho Jeong <daeho43@gmail.com>
To: linux-kernel@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net, kernel-team@android.com
Cc: Daeho Jeong <daehojeong@google.com>
Subject: [f2fs-dev] [PATCH v2 09/20] f2fs: support subpage blocks in pinned files
Date: Sun, 15 Nov 2026 20:08:40 -0800	[thread overview]
Message-ID: <20261116040851.2849696-10-daeho43@gmail.com> (raw)
In-Reply-To: <20261116040851.2849696-1-daeho43@gmail.com>

From: Daeho Jeong <daehojeong@google.com>

Pinned files must not allocate blocks outside fallocate(). As write()
does, return -EIO from page_mkwrite when the folio range up to EOF is
not fully allocated, and remove the -EOPNOTSUPP checks.

page_mkwrite keeps failing a device aliasing file with -EIO, as it does
when the block size equals PAGE_SIZE. Its block addresses are only in
the extent cache, so f2fs_overwrite_io() does not catch it.

Signed-off-by: Daeho Jeong <daehojeong@google.com>
---
 fs/f2fs/file.c | 22 ++++++++++++++++------
 1 file changed, 16 insertions(+), 6 deletions(-)

diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
index bec7988ca54b..72c601d240d4 100644
--- a/fs/f2fs/file.c
+++ b/fs/f2fs/file.c
@@ -142,7 +142,8 @@ static vm_fault_t f2fs_vm_page_mkwrite(struct vm_fault *vmf)
 	struct folio *folio = page_folio(vmf->page);
 	struct inode *inode = file_inode(vmf->vma->vm_file);
 	struct f2fs_sb_info *sbi = F2FS_I_SB(inode);
-	bool need_alloc = !f2fs_is_pinned_file(inode);
+	bool pinned = f2fs_is_pinned_file(inode);
+	bool need_alloc = !pinned;
 	pgoff_t pidx = folio->index + folio_page_idx(folio, vmf->page);
 	loff_t pos = (loff_t)pidx << PAGE_SHIFT;
 	pgoff_t bidx = F2FS_BYTES_TO_BLK(sbi, pos);
@@ -245,6 +246,19 @@ static vm_fault_t f2fs_vm_page_mkwrite(struct vm_fault *vmf)
 	nr = DIV_ROUND_UP(dirty_len, PAGE_SIZE);
 
 	if (f2fs_has_subpage_blocks(sbi)) {
+		/*
+		 * A device aliasing file has its block addresses only in the
+		 * extent cache, where f2fs_overwrite_io() finds them. Fail it
+		 * as f2fs_get_block_mkwrite() does.
+		 */
+		if (pinned &&
+		    (IS_DEVICE_ALIASING(inode) ||
+		     !f2fs_overwrite_io(inode, folio_pos(folio), dirty_len))) {
+			folio_unlock(folio);
+			err = -EIO;
+			goto out_sem;
+		}
+
 		/*
 		 * A writable PTE covers the whole base folio.  Like ext4's
 		 * block_page_mkwrite(), prepare every filesystem block through EOF
@@ -2285,8 +2299,7 @@ static long f2fs_fallocate(struct file *file, int mode,
 
 	if (f2fs_has_subpage_blocks(F2FS_I_SB(inode))) {
 		if ((mode & (FALLOC_FL_COLLAPSE_RANGE | FALLOC_FL_INSERT_RANGE)) ||
-		    f2fs_is_pinned_file(inode) || f2fs_is_atomic_file(inode) ||
-		    f2fs_compressed_file(inode)) {
+		    f2fs_is_atomic_file(inode) || f2fs_compressed_file(inode)) {
 			ret = -EOPNOTSUPP;
 			goto out;
 		}
@@ -3828,9 +3841,6 @@ static int f2fs_ioc_set_pin_file(struct file *filp, unsigned long arg)
 	__u32 pin;
 	int ret = 0;
 
-	if (f2fs_has_subpage_blocks(sbi))
-		return -EOPNOTSUPP;
-
 	if (get_user(pin, (__u32 __user *)arg))
 		return -EFAULT;
 
-- 
2.56.0.611.g1030f0b940-goog



_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

  parent reply	other threads:[~2026-11-16  4:09 UTC|newest]

Thread overview: 86+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16  4:08 [PATCH v2 00/20] f2fs: support block size smaller than PAGE_SIZE Daeho Jeong
2026-11-16  4:08 ` [f2fs-dev] " Daeho Jeong
2026-11-16  4:08 ` [PATCH v2 01/20] f2fs: use block-based index and size calculations in more paths Daeho Jeong
2026-11-16  4:08   ` [f2fs-dev] " Daeho Jeong
2026-11-17  8:53   ` Chao Yu
2026-11-17  8:53     ` Chao Yu via Linux-f2fs-devel
2026-11-16  4:08 ` [PATCH v2 02/20] f2fs: support subpage block size superblock and mount Daeho Jeong
2026-11-16  4:08   ` [f2fs-dev] " Daeho Jeong
2026-11-17  8:53   ` Chao Yu via Linux-f2fs-devel
2026-11-17  8:53     ` Chao Yu
2026-11-16  4:08 ` [PATCH v2 03/20] f2fs: extend f2fs_folio_state for subpage blocks Daeho Jeong
2026-11-16  4:08   ` [f2fs-dev] " Daeho Jeong
2026-11-17  8:54   ` Chao Yu
2026-11-17  8:54     ` Chao Yu via Linux-f2fs-devel
2026-11-16  4:08 ` [PATCH v2 04/20] f2fs: support subpage blocks in directory operations Daeho Jeong
2026-11-16  4:08   ` [f2fs-dev] " Daeho Jeong
2026-11-17  8:54   ` Chao Yu via Linux-f2fs-devel
2026-11-17  8:54     ` Chao Yu
2026-11-16  4:08 ` [PATCH v2 05/20] f2fs: convert inode dirty page counters to dirty block counters Daeho Jeong
2026-11-16  4:08   ` [f2fs-dev] " Daeho Jeong
2026-11-17  8:54   ` Chao Yu
2026-11-17  8:54     ` Chao Yu via Linux-f2fs-devel
2026-11-16  4:08 ` [PATCH v2 06/20] f2fs: support subpage blocks in data read path and GC Daeho Jeong
2026-11-16  4:08   ` [f2fs-dev] " Daeho Jeong
2026-11-17  8:58   ` Chao Yu
2026-11-17  8:58     ` Chao Yu via Linux-f2fs-devel
2026-11-17 16:51     ` Jaegeuk Kim
2026-11-17 16:51       ` Jaegeuk Kim via Linux-f2fs-devel
2026-11-16  4:08 ` [PATCH v2 07/20] f2fs: support subpage blocks in data write path and writeback Daeho Jeong
2026-11-16  4:08   ` [f2fs-dev] " Daeho Jeong
2026-11-17 10:43   ` Chao Yu
2026-11-17 10:43     ` Chao Yu via Linux-f2fs-devel
2026-11-16  4:08 ` [PATCH v2 08/20] f2fs: adapt range operations and mmap for subpage blocks Daeho Jeong
2026-11-16  4:08   ` [f2fs-dev] " Daeho Jeong
2026-11-17 11:05   ` Chao Yu via Linux-f2fs-devel
2026-11-17 11:05     ` Chao Yu
2026-11-16  4:08 ` Daeho Jeong [this message]
2026-11-16  4:08   ` [f2fs-dev] [PATCH v2 09/20] f2fs: support subpage blocks in pinned files Daeho Jeong
2026-11-17 11:09   ` Chao Yu via Linux-f2fs-devel
2026-11-17 11:09     ` Chao Yu
2026-11-16  4:08 ` [PATCH v2 10/20] f2fs: support subpage blocks in collapse and insert range Daeho Jeong
2026-11-16  4:08   ` [f2fs-dev] " Daeho Jeong
2026-11-17 11:13   ` Chao Yu via Linux-f2fs-devel
2026-11-17 11:13     ` Chao Yu
2026-11-16  4:08 ` [PATCH v2 11/20] f2fs: support subpage blocks in move range Daeho Jeong
2026-11-16  4:08   ` [f2fs-dev] " Daeho Jeong
2026-11-17 11:22   ` Chao Yu via Linux-f2fs-devel
2026-11-17 11:22     ` Chao Yu
2026-11-16  4:08 ` [PATCH v2 12/20] f2fs: support subpage blocks in defragmentation Daeho Jeong
2026-11-16  4:08   ` [f2fs-dev] " Daeho Jeong
2026-11-17 11:25   ` Chao Yu via Linux-f2fs-devel
2026-11-17 11:25     ` Chao Yu
2026-11-16  4:08 ` [PATCH v2 13/20] f2fs: support subpage blocks in swapfile activation Daeho Jeong
2026-11-16  4:08   ` [f2fs-dev] " Daeho Jeong
2026-11-17 11:25   ` Chao Yu
2026-11-17 11:25     ` Chao Yu via Linux-f2fs-devel
2026-11-16  4:08 ` [PATCH v2 14/20] f2fs: support subpage blocks in fs-verity enablement Daeho Jeong
2026-11-16  4:08   ` [f2fs-dev] " Daeho Jeong
2026-11-17 11:38   ` Chao Yu
2026-11-17 11:38     ` Chao Yu via Linux-f2fs-devel
2026-11-16  4:08 ` [PATCH v2 15/20] f2fs: support subpage blocks in atomic writes Daeho Jeong
2026-11-16  4:08   ` [f2fs-dev] " Daeho Jeong
2026-11-17 11:39   ` Chao Yu via Linux-f2fs-devel
2026-11-17 11:39     ` Chao Yu
2026-11-16  4:08 ` [PATCH v2 16/20] f2fs: preserve inline data in subpage block mode Daeho Jeong
2026-11-16  4:08   ` [f2fs-dev] " Daeho Jeong
2026-11-17 11:40   ` Chao Yu
2026-11-17 11:40     ` Chao Yu via Linux-f2fs-devel
2026-11-16  4:08 ` [PATCH v2 17/20] f2fs: support subpage blocks in online resize Daeho Jeong
2026-11-16  4:08   ` [f2fs-dev] " Daeho Jeong
2026-11-17 11:41   ` Chao Yu via Linux-f2fs-devel
2026-11-17 11:41     ` Chao Yu
2026-11-16  4:08 ` [PATCH v2 18/20] f2fs: support subpage blocks in compression Daeho Jeong
2026-11-16  4:08   ` [f2fs-dev] " Daeho Jeong
2026-11-18  2:29   ` Chao Yu via Linux-f2fs-devel
2026-11-18  2:29     ` Chao Yu
2026-11-16  4:08 ` [PATCH v2 19/20] f2fs: count compress cache entries in pages for its memory limit Daeho Jeong
2026-11-16  4:08   ` [f2fs-dev] " Daeho Jeong
2026-11-18  2:30   ` Chao Yu
2026-11-18  2:30     ` Chao Yu via Linux-f2fs-devel
2026-11-16  4:08 ` [PATCH v2 20/20] f2fs: enable subpage block size support Daeho Jeong
2026-11-16  4:08   ` [f2fs-dev] " Daeho Jeong
2026-11-18  2:30   ` Chao Yu
2026-11-18  2:30     ` Chao Yu via Linux-f2fs-devel
2026-11-17 16:50 ` [f2fs-dev] [PATCH v2 00/20] f2fs: support block size smaller than PAGE_SIZE patchwork-bot+f2fs--- via Linux-f2fs-devel
2026-11-17 16:50   ` patchwork-bot+f2fs

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261116040851.2849696-10-daeho43@gmail.com \
    --to=daeho43@gmail.com \
    --cc=daehojeong@google.com \
    --cc=kernel-team@android.com \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.