From: Chao Yu via Linux-f2fs-devel <linux-f2fs-devel@lists.sourceforge.net>
To: Daeho Jeong <daeho43@gmail.com>,
linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net, kernel-team@android.com
Cc: Daeho Jeong <daehojeong@google.com>
Subject: Re: [f2fs-dev] [PATCH v2 15/20] f2fs: support subpage blocks in atomic writes
Date: Tue, 17 Nov 2026 19:39:38 +0800 [thread overview]
Message-ID: <b253465e-d0c6-45eb-9ae8-798ef9ced6bd@kernel.org> (raw)
In-Reply-To: <20261116040851.2849696-16-daeho43@gmail.com>
On 11/16/26 12:08, Daeho Jeong wrote:
> From: Daeho Jeong <daehojeong@google.com>
>
> Writeback already writes dirty blocks to the COW inode per block. Make
> write_begin of atomic files reserve and read COW blocks per block as
> well, and remove the -EOPNOTSUPP checks. Skipping the read of the
> blocks that a write fully covers also applies to large folios when the
> block size equals PAGE_SIZE.
>
> Aborting atomic writes drops the page cache and restores i_size without
> i_gc_rwsem[WRITE] and invalidate_lock. With subpage blocks, a page fault
> in between can make a folio writable with only the blocks within the
> smaller i_size prepared, and a read can zero-fill the blocks beyond it
> and mark them uptodate, while they are inside the restored i_size. GC
> reads through the page cache as well once FI_ATOMIC_FILE is cleared, and
> then moves the zeroes. Hold both locks across it as
> f2fs_ioc_start_atomic_write() does, except at eviction, where no one
> else uses the inode.
>
> Signed-off-by: Daeho Jeong <daehojeong@google.com>
Reviewed-by: Chao Yu <chao@kernel.org>
Thanks,
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
WARNING: multiple messages have this Message-ID (diff)
From: Chao Yu <chao@kernel.org>
To: Daeho Jeong <daeho43@gmail.com>,
linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net, kernel-team@android.com
Cc: chao@kernel.org, Daeho Jeong <daehojeong@google.com>
Subject: Re: [f2fs-dev] [PATCH v2 15/20] f2fs: support subpage blocks in atomic writes
Date: Tue, 17 Nov 2026 19:39:38 +0800 [thread overview]
Message-ID: <b253465e-d0c6-45eb-9ae8-798ef9ced6bd@kernel.org> (raw)
In-Reply-To: <20261116040851.2849696-16-daeho43@gmail.com>
On 11/16/26 12:08, Daeho Jeong wrote:
> From: Daeho Jeong <daehojeong@google.com>
>
> Writeback already writes dirty blocks to the COW inode per block. Make
> write_begin of atomic files reserve and read COW blocks per block as
> well, and remove the -EOPNOTSUPP checks. Skipping the read of the
> blocks that a write fully covers also applies to large folios when the
> block size equals PAGE_SIZE.
>
> Aborting atomic writes drops the page cache and restores i_size without
> i_gc_rwsem[WRITE] and invalidate_lock. With subpage blocks, a page fault
> in between can make a folio writable with only the blocks within the
> smaller i_size prepared, and a read can zero-fill the blocks beyond it
> and mark them uptodate, while they are inside the restored i_size. GC
> reads through the page cache as well once FI_ATOMIC_FILE is cleared, and
> then moves the zeroes. Hold both locks across it as
> f2fs_ioc_start_atomic_write() does, except at eviction, where no one
> else uses the inode.
>
> Signed-off-by: Daeho Jeong <daehojeong@google.com>
Reviewed-by: Chao Yu <chao@kernel.org>
Thanks,
next prev parent reply other threads:[~2026-11-17 11:39 UTC|newest]
Thread overview: 86+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 4:08 [f2fs-dev] [PATCH v2 00/20] f2fs: support block size smaller than PAGE_SIZE Daeho Jeong
2026-11-16 4:08 ` Daeho Jeong
2026-11-16 4:08 ` [f2fs-dev] [PATCH v2 01/20] f2fs: use block-based index and size calculations in more paths Daeho Jeong
2026-11-16 4:08 ` Daeho Jeong
2026-11-17 8:53 ` [f2fs-dev] " Chao Yu
2026-11-17 8:53 ` Chao Yu via Linux-f2fs-devel
2026-11-16 4:08 ` [f2fs-dev] [PATCH v2 02/20] f2fs: support subpage block size superblock and mount Daeho Jeong
2026-11-16 4:08 ` Daeho Jeong
2026-11-17 8:53 ` [f2fs-dev] " Chao Yu via Linux-f2fs-devel
2026-11-17 8:53 ` Chao Yu
2026-11-16 4:08 ` [f2fs-dev] [PATCH v2 03/20] f2fs: extend f2fs_folio_state for subpage blocks Daeho Jeong
2026-11-16 4:08 ` Daeho Jeong
2026-11-17 8:54 ` [f2fs-dev] " Chao Yu via Linux-f2fs-devel
2026-11-17 8:54 ` Chao Yu
2026-11-16 4:08 ` [f2fs-dev] [PATCH v2 04/20] f2fs: support subpage blocks in directory operations Daeho Jeong
2026-11-16 4:08 ` Daeho Jeong
2026-11-17 8:54 ` [f2fs-dev] " Chao Yu via Linux-f2fs-devel
2026-11-17 8:54 ` Chao Yu
2026-11-16 4:08 ` [f2fs-dev] [PATCH v2 05/20] f2fs: convert inode dirty page counters to dirty block counters Daeho Jeong
2026-11-16 4:08 ` Daeho Jeong
2026-11-17 8:54 ` [f2fs-dev] " Chao Yu via Linux-f2fs-devel
2026-11-17 8:54 ` Chao Yu
2026-11-16 4:08 ` [f2fs-dev] [PATCH v2 06/20] f2fs: support subpage blocks in data read path and GC Daeho Jeong
2026-11-16 4:08 ` Daeho Jeong
2026-11-17 8:58 ` [f2fs-dev] " Chao Yu
2026-11-17 8:58 ` Chao Yu via Linux-f2fs-devel
2026-11-17 16:51 ` Jaegeuk Kim
2026-11-17 16:51 ` Jaegeuk Kim via Linux-f2fs-devel
2026-11-16 4:08 ` [f2fs-dev] [PATCH v2 07/20] f2fs: support subpage blocks in data write path and writeback Daeho Jeong
2026-11-16 4:08 ` Daeho Jeong
2026-11-17 10:43 ` [f2fs-dev] " Chao Yu
2026-11-17 10:43 ` Chao Yu via Linux-f2fs-devel
2026-11-16 4:08 ` [f2fs-dev] [PATCH v2 08/20] f2fs: adapt range operations and mmap for subpage blocks Daeho Jeong
2026-11-16 4:08 ` Daeho Jeong
2026-11-17 11:05 ` [f2fs-dev] " Chao Yu
2026-11-17 11:05 ` Chao Yu via Linux-f2fs-devel
2026-11-16 4:08 ` [f2fs-dev] [PATCH v2 09/20] f2fs: support subpage blocks in pinned files Daeho Jeong
2026-11-16 4:08 ` Daeho Jeong
2026-11-17 11:09 ` [f2fs-dev] " Chao Yu via Linux-f2fs-devel
2026-11-17 11:09 ` Chao Yu
2026-11-16 4:08 ` [f2fs-dev] [PATCH v2 10/20] f2fs: support subpage blocks in collapse and insert range Daeho Jeong
2026-11-16 4:08 ` Daeho Jeong
2026-11-17 11:13 ` [f2fs-dev] " Chao Yu via Linux-f2fs-devel
2026-11-17 11:13 ` Chao Yu
2026-11-16 4:08 ` [f2fs-dev] [PATCH v2 11/20] f2fs: support subpage blocks in move range Daeho Jeong
2026-11-16 4:08 ` Daeho Jeong
2026-11-17 11:22 ` [f2fs-dev] " Chao Yu via Linux-f2fs-devel
2026-11-17 11:22 ` Chao Yu
2026-11-16 4:08 ` [f2fs-dev] [PATCH v2 12/20] f2fs: support subpage blocks in defragmentation Daeho Jeong
2026-11-16 4:08 ` Daeho Jeong
2026-11-17 11:25 ` [f2fs-dev] " Chao Yu
2026-11-17 11:25 ` Chao Yu via Linux-f2fs-devel
2026-11-16 4:08 ` [f2fs-dev] [PATCH v2 13/20] f2fs: support subpage blocks in swapfile activation Daeho Jeong
2026-11-16 4:08 ` Daeho Jeong
2026-11-17 11:25 ` [f2fs-dev] " Chao Yu
2026-11-17 11:25 ` Chao Yu via Linux-f2fs-devel
2026-11-16 4:08 ` [f2fs-dev] [PATCH v2 14/20] f2fs: support subpage blocks in fs-verity enablement Daeho Jeong
2026-11-16 4:08 ` Daeho Jeong
2026-11-17 11:38 ` [f2fs-dev] " Chao Yu via Linux-f2fs-devel
2026-11-17 11:38 ` Chao Yu
2026-11-16 4:08 ` [f2fs-dev] [PATCH v2 15/20] f2fs: support subpage blocks in atomic writes Daeho Jeong
2026-11-16 4:08 ` Daeho Jeong
2026-11-17 11:39 ` Chao Yu via Linux-f2fs-devel [this message]
2026-11-17 11:39 ` [f2fs-dev] " Chao Yu
2026-11-16 4:08 ` [f2fs-dev] [PATCH v2 16/20] f2fs: preserve inline data in subpage block mode Daeho Jeong
2026-11-16 4:08 ` Daeho Jeong
2026-11-17 11:40 ` [f2fs-dev] " Chao Yu
2026-11-17 11:40 ` Chao Yu via Linux-f2fs-devel
2026-11-16 4:08 ` [f2fs-dev] [PATCH v2 17/20] f2fs: support subpage blocks in online resize Daeho Jeong
2026-11-16 4:08 ` Daeho Jeong
2026-11-17 11:41 ` [f2fs-dev] " Chao Yu via Linux-f2fs-devel
2026-11-17 11:41 ` Chao Yu
2026-11-16 4:08 ` [f2fs-dev] [PATCH v2 18/20] f2fs: support subpage blocks in compression Daeho Jeong
2026-11-16 4:08 ` Daeho Jeong
2026-11-18 2:29 ` [f2fs-dev] " Chao Yu via Linux-f2fs-devel
2026-11-18 2:29 ` Chao Yu
2026-11-16 4:08 ` [f2fs-dev] [PATCH v2 19/20] f2fs: count compress cache entries in pages for its memory limit Daeho Jeong
2026-11-16 4:08 ` Daeho Jeong
2026-11-18 2:30 ` [f2fs-dev] " Chao Yu via Linux-f2fs-devel
2026-11-18 2:30 ` Chao Yu
2026-11-16 4:08 ` [f2fs-dev] [PATCH v2 20/20] f2fs: enable subpage block size support Daeho Jeong
2026-11-16 4:08 ` Daeho Jeong
2026-11-18 2:30 ` [f2fs-dev] " Chao Yu via Linux-f2fs-devel
2026-11-18 2:30 ` Chao Yu
2026-11-17 16:50 ` [f2fs-dev] [PATCH v2 00/20] f2fs: support block size smaller than PAGE_SIZE patchwork-bot+f2fs--- via Linux-f2fs-devel
2026-11-17 16:50 ` patchwork-bot+f2fs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b253465e-d0c6-45eb-9ae8-798ef9ced6bd@kernel.org \
--to=linux-f2fs-devel@lists.sourceforge.net \
--cc=chao@kernel.org \
--cc=daeho43@gmail.com \
--cc=daehojeong@google.com \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.