From: Andreas Kemnade <andreas@kemnade.info>
To: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Cc: Marek Vasut <marex@denx.de>,
Andrzej Hajda <andrzej.hajda@intel.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Robert Foss <rfoss@kernel.org>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Jonas Karlman <jonas@kwiboo.se>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Dave Stevenson <dave.stevenson@raspberrypi.com>
Subject: Re: [PATCH v5 03/13] drm/bridge: tc358762: Improve LCDCTRL defines
Date: Mon, 16 Nov 2026 09:02:06 +0100 [thread overview]
Message-ID: <20261116090206.4085771b@kemnade.info> (raw)
In-Reply-To: <20261015-tc358762-fixes-v5-3-7cd721a6451b@ideasonboard.com>
On Thu, 15 Oct 2026 14:15:54 +0300
Tomi Valkeinen <tomi.valkeinen@ideasonboard.com> wrote:
> LCDCTRL fields are quite wrong in the driver. Fix the field defines.
>
> A few notes about the wrong fields:
>
> LCDCTRL_VSDELAY(1) actually sets LCDCTRL_DCLK_POL
> LCDCTRL_UNK6 | LCDCTRL_VTGEN actually set LCDCTRL_PXLFORM_RGB888
> LCDCTRL_RGB888 actually sets LCDCTRL_DPI_EN
>
> The total still resulted in a working display even if the defines were
> quite wrong.
>
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Reviewed-by: Andreas Kemnade <andreas@kemnade.info>
> ---
> drivers/gpu/drm/bridge/tc358762.c | 33 ++++++++++++++++++++-------------
> 1 file changed, 20 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/tc358762.c b/drivers/gpu/drm/bridge/tc358762.c
> index 59c68432f8e1..26671dc66874 100644
> --- a/drivers/gpu/drm/bridge/tc358762.c
> +++ b/drivers/gpu/drm/bridge/tc358762.c
> @@ -46,17 +46,22 @@
> #define DSI_LANEENABLE_L0EN BIT(1)
> #define DSI_LANEENABLE_L1EN BIT(2)
>
> -/* LCDC/DPI Host Registers, based on guesswork that this matches TC358764 */
> +/* LCDC/DPI Registers */
> #define LCDCTRL 0x0420 /* Video Path Control */
> #define LCDCTRL_MSF BIT(0) /* Magic square in RGB666 */
> -#define LCDCTRL_VTGEN BIT(4)/* Use chip clock for timing */
> -#define LCDCTRL_UNK6 BIT(6) /* Unknown */
> -#define LCDCTRL_EVTMODE BIT(5) /* Event mode */
> -#define LCDCTRL_RGB888 BIT(8) /* RGB888 mode */
> -#define LCDCTRL_HSPOL BIT(17) /* Polarity of HSYNC signal */
> -#define LCDCTRL_DEPOL BIT(18) /* Polarity of DE signal */
> -#define LCDCTRL_VSPOL BIT(19) /* Polarity of VSYNC signal */
> -#define LCDCTRL_VSDELAY(v) (((v) & 0xfff) << 20) /* VSYNC delay */
> +#define LCDCTRL_VTGEN BIT(1) /* Use chip clock for timing */
> +#define LCDCTRL_PXLFORM GENMASK_U32(6, 4)
> +#define LCDCTRL_PXLFORM_RGB666 0 /* x:R:G:B 6:8:8:8 */
> +#define LCDCTRL_PXLFORM_RGB666_24 1 /* x:R:x:G:x:B 2:6:2:6:2:6 */
> +#define LCDCTRL_PXLFORM_RGB565 2 /* x:R:G:B 8:5:6:5 */
> +#define LCDCTRL_PXLFORM_RGB565_1 3 /* x:R:x:G:x:B 3:5:2:6:3:5 */
> +#define LCDCTRL_PXLFORM_RGB565_2 4 /* x:R:x:G:x:B:x 2:5:3:6:2:5:1 */
> +#define LCDCTRL_PXLFORM_RGB888 5 /* R:G:B 8:8:8 */
> +#define LCDCTRL_DPI_EN BIT(8)
> +#define LCDCTRL_HSYNC_POL BIT(17) /* Polarity of HSYNC signal */
> +#define LCDCTRL_DE_POL BIT(18) /* Polarity of DE signal */
> +#define LCDCTRL_VSYNC_POL BIT(19) /* Polarity of VSYNC signal */
> +#define LCDCTRL_DCLK_POL BIT(20) /* Polarity of pixel clock */
>
> /* SPI Master Registers */
> #define SPICMR 0x0450
> @@ -139,14 +144,16 @@ static int tc358762_init(struct tc358762 *ctx)
>
> tc358762_write(ctx, SPICMR, 0x00);
>
> - lcdctrl = LCDCTRL_VSDELAY(1) | LCDCTRL_RGB888 |
> - LCDCTRL_UNK6 | LCDCTRL_VTGEN;
> + lcdctrl = FIELD_PREP(LCDCTRL_PXLFORM, LCDCTRL_PXLFORM_RGB888) |
> + LCDCTRL_DPI_EN;
> +
> + lcdctrl |= LCDCTRL_DCLK_POL;
>
> if (ctx->mode.flags & DRM_MODE_FLAG_NHSYNC)
> - lcdctrl |= LCDCTRL_HSPOL;
> + lcdctrl |= LCDCTRL_HSYNC_POL;
>
> if (ctx->mode.flags & DRM_MODE_FLAG_NVSYNC)
> - lcdctrl |= LCDCTRL_VSPOL;
> + lcdctrl |= LCDCTRL_VSYNC_POL;
>
> tc358762_write(ctx, LCDCTRL, lcdctrl);
>
>
next prev parent reply other threads:[~2026-11-16 8:02 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-15 11:15 [PATCH v5 00/13] drm/bridge: tc358762: Various small fixes Tomi Valkeinen
2026-10-15 11:15 ` [PATCH v5 01/13] drm/bridge: tc358762: Clean up register defines Tomi Valkeinen
2026-11-11 10:30 ` Andreas Kemnade
2026-10-15 11:15 ` [PATCH v5 02/13] drm/bridge: tc358762: Improve SYSCTRL " Tomi Valkeinen
2026-11-11 10:35 ` Andreas Kemnade
2026-10-15 11:15 ` [PATCH v5 03/13] drm/bridge: tc358762: Improve LCDCTRL defines Tomi Valkeinen
2026-11-16 8:02 ` Andreas Kemnade [this message]
2026-10-15 11:15 ` [PATCH v5 04/13] drm/bridge: tc358762: Configure SYSCTRL first Tomi Valkeinen
2026-11-16 8:16 ` Andreas Kemnade
2026-10-15 11:15 ` [PATCH v5 05/13] drm/bridge: tc358762: Drop SPICMR write Tomi Valkeinen
2026-10-15 11:15 ` [PATCH v5 06/13] drm/bridge: tc358762: Improve DPI enable handling Tomi Valkeinen
2026-10-15 11:25 ` sashiko-bot
2026-10-15 11:15 ` [PATCH v5 07/13] drm/bridge: tc358762: Update comment about the number of lanes Tomi Valkeinen
2026-11-16 8:25 ` Andreas Kemnade
2026-10-15 11:15 ` [PATCH v5 08/13] drm/bridge: tc358762: Support VTG Tomi Valkeinen
2026-10-15 11:16 ` [PATCH v5 09/13] drm/bridge: tc358762: Fix sync polarities Tomi Valkeinen
2026-11-16 8:29 ` Andreas Kemnade
2026-10-15 11:16 ` [PATCH v5 10/13] drm/bridge: tc358762: Move tc358762_init() into tc358762_enable() Tomi Valkeinen
2026-11-16 9:05 ` Andreas Kemnade
2026-10-15 11:16 ` [PATCH v5 11/13] drm/bridge: tc358762: Drop drm_bridge_funcs.mode_set Tomi Valkeinen
2026-11-16 9:06 ` Andreas Kemnade
2026-10-15 11:16 ` [PATCH v5 12/13] drm/bridge: tc358762: Set DE_POL and DCLK_POL properly Tomi Valkeinen
2026-11-16 9:17 ` Andreas Kemnade
2026-10-15 11:16 ` [PATCH v5 13/13] drm/panel-simple: Fix powertip,ph800480t013-idf02 timings Tomi Valkeinen
2026-10-28 11:42 ` [PATCH v5 00/13] drm/bridge: tc358762: Various small fixes Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261116090206.4085771b@kemnade.info \
--to=andreas@kemnade.info \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@gmail.com \
--cc=andrzej.hajda@intel.com \
--cc=dave.stevenson@raspberrypi.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=marex@denx.de \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=rfoss@kernel.org \
--cc=simona@ffwll.ch \
--cc=tomi.valkeinen@ideasonboard.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.