From: Andreas Kemnade <andreas@kemnade.info>
To: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Cc: Marek Vasut <marex@denx.de>,
Andrzej Hajda <andrzej.hajda@intel.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Robert Foss <rfoss@kernel.org>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Jonas Karlman <jonas@kwiboo.se>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Dave Stevenson <dave.stevenson@raspberrypi.com>
Subject: Re: [PATCH v5 12/13] drm/bridge: tc358762: Set DE_POL and DCLK_POL properly
Date: Mon, 16 Nov 2026 10:17:37 +0100 [thread overview]
Message-ID: <20261116101737.38caec27@kemnade.info> (raw)
In-Reply-To: <20261015-tc358762-fixes-v5-12-7cd721a6451b@ideasonboard.com>
On Thu, 15 Oct 2026 14:16:03 +0300
Tomi Valkeinen <tomi.valkeinen@ideasonboard.com> wrote:
> The driver hardcodes LCDCTRL_DCLK_POL and ~DE_POL, ignoring what the
> panel actuall wants. Fix this by looking at the
> bridge_state->output_bus_cfg.flags, and set the polarities correctly.
>
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Reviewed-by: Andreas Kemnade <andreas@kemnade.info>
> ---
> drivers/gpu/drm/bridge/tc358762.c | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/tc358762.c b/drivers/gpu/drm/bridge/tc358762.c
> index 33312300e606..e73be376e33c 100644
> --- a/drivers/gpu/drm/bridge/tc358762.c
> +++ b/drivers/gpu/drm/bridge/tc358762.c
> @@ -186,12 +186,15 @@ static void tc358762_enable(struct drm_bridge *bridge,
> {
> struct tc358762 *ctx = bridge_to_tc358762(bridge);
> struct drm_connector_state *conn_state;
> + struct drm_bridge_state *bridge_state;
> struct drm_crtc_state *crtc_state;
> struct drm_connector *connector;
> struct drm_display_mode *mode;
> u32 lcdctrl;
> int ret;
>
> + bridge_state = drm_atomic_get_new_bridge_state(state, bridge);
> +
> connector = drm_atomic_get_new_connector_for_encoder(state, bridge->encoder);
> conn_state = drm_atomic_get_new_connector_state(state, connector);
> crtc_state = drm_atomic_get_new_crtc_state(state, conn_state->crtc);
> @@ -243,7 +246,9 @@ static void tc358762_enable(struct drm_bridge *bridge,
> if (ctx->use_vtg)
> lcdctrl |= LCDCTRL_VTGEN;
>
> - lcdctrl |= LCDCTRL_DCLK_POL;
> + /* Note: DCLK_POL affects pixdata, de and syncs */
> + if (bridge_state->output_bus_cfg.flags & DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE)
> + lcdctrl |= LCDCTRL_DCLK_POL;
>
> if (mode->flags & DRM_MODE_FLAG_PHSYNC)
> lcdctrl |= LCDCTRL_HSYNC_POL;
> @@ -251,6 +256,9 @@ static void tc358762_enable(struct drm_bridge *bridge,
> if (mode->flags & DRM_MODE_FLAG_PVSYNC)
> lcdctrl |= LCDCTRL_VSYNC_POL;
>
> + if (bridge_state->output_bus_cfg.flags & DRM_BUS_FLAG_DE_LOW)
> + lcdctrl |= LCDCTRL_DE_POL;
> +
> tc358762_write(ctx, LCDCTRL, lcdctrl);
>
> tc358762_write(ctx, PPI_STARTPPI, PPI_STARTPPI_STARTPPI);
>
next prev parent reply other threads:[~2026-11-16 9:18 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-15 11:15 [PATCH v5 00/13] drm/bridge: tc358762: Various small fixes Tomi Valkeinen
2026-10-15 11:15 ` [PATCH v5 01/13] drm/bridge: tc358762: Clean up register defines Tomi Valkeinen
2026-11-11 10:30 ` Andreas Kemnade
2026-10-15 11:15 ` [PATCH v5 02/13] drm/bridge: tc358762: Improve SYSCTRL " Tomi Valkeinen
2026-11-11 10:35 ` Andreas Kemnade
2026-10-15 11:15 ` [PATCH v5 03/13] drm/bridge: tc358762: Improve LCDCTRL defines Tomi Valkeinen
2026-11-16 8:02 ` Andreas Kemnade
2026-10-15 11:15 ` [PATCH v5 04/13] drm/bridge: tc358762: Configure SYSCTRL first Tomi Valkeinen
2026-11-16 8:16 ` Andreas Kemnade
2026-10-15 11:15 ` [PATCH v5 05/13] drm/bridge: tc358762: Drop SPICMR write Tomi Valkeinen
2026-10-15 11:15 ` [PATCH v5 06/13] drm/bridge: tc358762: Improve DPI enable handling Tomi Valkeinen
2026-10-15 11:25 ` sashiko-bot
2026-10-15 11:15 ` [PATCH v5 07/13] drm/bridge: tc358762: Update comment about the number of lanes Tomi Valkeinen
2026-11-16 8:25 ` Andreas Kemnade
2026-10-15 11:15 ` [PATCH v5 08/13] drm/bridge: tc358762: Support VTG Tomi Valkeinen
2026-10-15 11:16 ` [PATCH v5 09/13] drm/bridge: tc358762: Fix sync polarities Tomi Valkeinen
2026-11-16 8:29 ` Andreas Kemnade
2026-10-15 11:16 ` [PATCH v5 10/13] drm/bridge: tc358762: Move tc358762_init() into tc358762_enable() Tomi Valkeinen
2026-11-16 9:05 ` Andreas Kemnade
2026-10-15 11:16 ` [PATCH v5 11/13] drm/bridge: tc358762: Drop drm_bridge_funcs.mode_set Tomi Valkeinen
2026-11-16 9:06 ` Andreas Kemnade
2026-10-15 11:16 ` [PATCH v5 12/13] drm/bridge: tc358762: Set DE_POL and DCLK_POL properly Tomi Valkeinen
2026-11-16 9:17 ` Andreas Kemnade [this message]
2026-10-15 11:16 ` [PATCH v5 13/13] drm/panel-simple: Fix powertip,ph800480t013-idf02 timings Tomi Valkeinen
2026-10-28 11:42 ` [PATCH v5 00/13] drm/bridge: tc358762: Various small fixes Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261116101737.38caec27@kemnade.info \
--to=andreas@kemnade.info \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@gmail.com \
--cc=andrzej.hajda@intel.com \
--cc=dave.stevenson@raspberrypi.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=marex@denx.de \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=rfoss@kernel.org \
--cc=simona@ffwll.ch \
--cc=tomi.valkeinen@ideasonboard.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.