All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andreas Kemnade <andreas@kemnade.info>
To: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Cc: Marek Vasut <marex@denx.de>,
	Andrzej Hajda <andrzej.hajda@intel.com>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Robert Foss <rfoss@kernel.org>,
	Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
	Jonas Karlman <jonas@kwiboo.se>,
	Jernej Skrabec <jernej.skrabec@gmail.com>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	Dave Stevenson <dave.stevenson@raspberrypi.com>
Subject: Re: [PATCH v5 11/13] drm/bridge: tc358762: Drop drm_bridge_funcs.mode_set
Date: Mon, 16 Nov 2026 10:06:42 +0100	[thread overview]
Message-ID: <20261116100642.5d61e34b@kemnade.info> (raw)
In-Reply-To: <20261015-tc358762-fixes-v5-11-7cd721a6451b@ideasonboard.com>

On Thu, 15 Oct 2026 14:16:02 +0300
Tomi Valkeinen <tomi.valkeinen@ideasonboard.com> wrote:

> drm_bridge_funcs.mode_set is deprecated. Drop it and get the
> drm_display_mode from the atomic state.
> 
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Reviewed-by: Andreas Kemnade <andreas@kemnade.info>
> ---
>  drivers/gpu/drm/bridge/tc358762.c | 26 ++++++++++++--------------
>  1 file changed, 12 insertions(+), 14 deletions(-)
> 
> diff --git a/drivers/gpu/drm/bridge/tc358762.c b/drivers/gpu/drm/bridge/tc358762.c
> index a91cf159ba27..33312300e606 100644
> --- a/drivers/gpu/drm/bridge/tc358762.c
> +++ b/drivers/gpu/drm/bridge/tc358762.c
> @@ -98,7 +98,6 @@ struct tc358762 {
>  	struct regulator *regulator;
>  	struct drm_bridge *panel_bridge;
>  	struct gpio_desc *reset_gpio;
> -	struct drm_display_mode mode;
>  	bool pre_enabled;
>  	int error;
>  	bool use_vtg;
> @@ -186,9 +185,18 @@ static void tc358762_enable(struct drm_bridge *bridge,
>  			    struct drm_atomic_commit *state)
>  {
>  	struct tc358762 *ctx = bridge_to_tc358762(bridge);
> +	struct drm_connector_state *conn_state;
> +	struct drm_crtc_state *crtc_state;
> +	struct drm_connector *connector;
> +	struct drm_display_mode *mode;
>  	u32 lcdctrl;
>  	int ret;
>  
> +	connector = drm_atomic_get_new_connector_for_encoder(state, bridge->encoder);
> +	conn_state = drm_atomic_get_new_connector_state(state, connector);
> +	crtc_state = drm_atomic_get_new_crtc_state(state, conn_state->crtc);
> +	mode = &crtc_state->mode;
> +
>  	/*
>  	 * DPIENABLE has reset default of 1. Make sure we don't output on
>  	 * DPI until we have finished the coniguration.
> @@ -213,7 +221,7 @@ static void tc358762_enable(struct drm_bridge *bridge,
>  	if (ctx->use_vtg) {
>  		struct videomode vm = { 0 };
>  
> -		drm_display_mode_to_videomode(&ctx->mode, &vm);
> +		drm_display_mode_to_videomode(mode, &vm);
>  
>  		tc358762_write(ctx, LCDC_HSR_HBPR,
>  			       vm.hsync_len | (vm.hback_porch << 16));
> @@ -237,10 +245,10 @@ static void tc358762_enable(struct drm_bridge *bridge,
>  
>  	lcdctrl |= LCDCTRL_DCLK_POL;
>  
> -	if (ctx->mode.flags & DRM_MODE_FLAG_PHSYNC)
> +	if (mode->flags & DRM_MODE_FLAG_PHSYNC)
>  		lcdctrl |= LCDCTRL_HSYNC_POL;
>  
> -	if (ctx->mode.flags & DRM_MODE_FLAG_PVSYNC)
> +	if (mode->flags & DRM_MODE_FLAG_PVSYNC)
>  		lcdctrl |= LCDCTRL_VSYNC_POL;
>  
>  	tc358762_write(ctx, LCDCTRL, lcdctrl);
> @@ -265,15 +273,6 @@ static int tc358762_attach(struct drm_bridge *bridge,
>  				 bridge, flags);
>  }
>  
> -static void tc358762_bridge_mode_set(struct drm_bridge *bridge,
> -				     const struct drm_display_mode *mode,
> -				     const struct drm_display_mode *adj)
> -{
> -	struct tc358762 *ctx = bridge_to_tc358762(bridge);
> -
> -	drm_mode_copy(&ctx->mode, mode);
> -}
> -
>  static const struct drm_bridge_funcs tc358762_bridge_funcs = {
>  	.atomic_post_disable = tc358762_post_disable,
>  	.atomic_pre_enable = tc358762_pre_enable,
> @@ -282,7 +281,6 @@ static const struct drm_bridge_funcs tc358762_bridge_funcs = {
>  	.atomic_destroy_state = drm_atomic_helper_bridge_destroy_state,
>  	.atomic_create_state = drm_atomic_helper_bridge_create_state,
>  	.attach = tc358762_attach,
> -	.mode_set = tc358762_bridge_mode_set,
>  };
>  
>  static int tc358762_parse_dt(struct tc358762 *ctx)
> 


  reply	other threads:[~2026-11-16  9:06 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-15 11:15 [PATCH v5 00/13] drm/bridge: tc358762: Various small fixes Tomi Valkeinen
2026-10-15 11:15 ` [PATCH v5 01/13] drm/bridge: tc358762: Clean up register defines Tomi Valkeinen
2026-11-11 10:30   ` Andreas Kemnade
2026-10-15 11:15 ` [PATCH v5 02/13] drm/bridge: tc358762: Improve SYSCTRL " Tomi Valkeinen
2026-11-11 10:35   ` Andreas Kemnade
2026-10-15 11:15 ` [PATCH v5 03/13] drm/bridge: tc358762: Improve LCDCTRL defines Tomi Valkeinen
2026-11-16  8:02   ` Andreas Kemnade
2026-10-15 11:15 ` [PATCH v5 04/13] drm/bridge: tc358762: Configure SYSCTRL first Tomi Valkeinen
2026-11-16  8:16   ` Andreas Kemnade
2026-10-15 11:15 ` [PATCH v5 05/13] drm/bridge: tc358762: Drop SPICMR write Tomi Valkeinen
2026-10-15 11:15 ` [PATCH v5 06/13] drm/bridge: tc358762: Improve DPI enable handling Tomi Valkeinen
2026-10-15 11:25   ` sashiko-bot
2026-10-15 11:15 ` [PATCH v5 07/13] drm/bridge: tc358762: Update comment about the number of lanes Tomi Valkeinen
2026-11-16  8:25   ` Andreas Kemnade
2026-10-15 11:15 ` [PATCH v5 08/13] drm/bridge: tc358762: Support VTG Tomi Valkeinen
2026-10-15 11:16 ` [PATCH v5 09/13] drm/bridge: tc358762: Fix sync polarities Tomi Valkeinen
2026-11-16  8:29   ` Andreas Kemnade
2026-10-15 11:16 ` [PATCH v5 10/13] drm/bridge: tc358762: Move tc358762_init() into tc358762_enable() Tomi Valkeinen
2026-11-16  9:05   ` Andreas Kemnade
2026-10-15 11:16 ` [PATCH v5 11/13] drm/bridge: tc358762: Drop drm_bridge_funcs.mode_set Tomi Valkeinen
2026-11-16  9:06   ` Andreas Kemnade [this message]
2026-10-15 11:16 ` [PATCH v5 12/13] drm/bridge: tc358762: Set DE_POL and DCLK_POL properly Tomi Valkeinen
2026-11-16  9:17   ` Andreas Kemnade
2026-10-15 11:16 ` [PATCH v5 13/13] drm/panel-simple: Fix powertip,ph800480t013-idf02 timings Tomi Valkeinen
2026-10-28 11:42 ` [PATCH v5 00/13] drm/bridge: tc358762: Various small fixes Tomi Valkeinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261116100642.5d61e34b@kemnade.info \
    --to=andreas@kemnade.info \
    --cc=Laurent.pinchart@ideasonboard.com \
    --cc=airlied@gmail.com \
    --cc=andrzej.hajda@intel.com \
    --cc=dave.stevenson@raspberrypi.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jernej.skrabec@gmail.com \
    --cc=jonas@kwiboo.se \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=marex@denx.de \
    --cc=mripard@kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=rfoss@kernel.org \
    --cc=simona@ffwll.ch \
    --cc=tomi.valkeinen@ideasonboard.com \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.