From: Conor Dooley <conor@kernel.org>
To: Mina Chou <minachou@andestech.com>
Cc: pjw@kernel.org, palmer@dabbelt.com, aou@eecs.berkeley.edu,
alex@ghiti.fr, jic23@kernel.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org, geert+renesas@glider.be,
magnus.damm@gmail.com, prabhakar.mahadev-lad.rj@bp.renesas.com,
linux-riscv@lists.infradead.org, devicetree@vger.kernel.org,
linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
randolph@andestech.com, cyyang772@andestech.com,
tim609@andestech.com, az70021@gmail.com
Subject: Re: [PATCH v2 18/19] riscv: errata: andes: limit the IOCP workaround to RZ/Five
Date: Tue, 17 Nov 2026 17:37:59 +0000 [thread overview]
Message-ID: <20261117-grape-skeletal-89da442523ce@spud> (raw)
In-Reply-To: <avwdT/vGjfsUCkHv@atcsi01.andestech.com>
[-- Attachment #1: Type: text/plain, Size: 1165 bytes --]
On Tue, Nov 17, 2026 at 05:24:31PM +0800, Mina Chou wrote:
> On Fri, Nov 13, 2026 at 01:53:29PM +0000, Conor Dooley wrote:
> > > Move the match into soc_is_r9a07g043f() and make it also require
> > > ARCH_R9A07G043. Kernels without RZ/Five support then skip the SBI call
> > > and take the generic Andes cache errata path. No other upstream-
> > > supported SoC uses this AX45MP mimpid, so their behavior does not
> > > change.
> >
> > But a device using this soc that doesn't have a dts in mainline won't
> > function properly, so this is fragile. Why not just do it properly and
> > check for RZ/Five specifically?
> > Can check for of_machine_is_compatible() probably?
>
> I will check for RZ/Five with of_machine_is_compatible("renesas,r9a07g043"),
> which on RISC-V is only used by RZ/Five, and drop the marchid/mimpid match.
Looking at what is quoted, I wonder if my main point I forgot to
include. Checking for ARCH_R9... (or any other SoC in that manner) will
fall over on multiplatform kernels. Code needs to be written so that no
matter what Kconfig options are enabled it will work.
of_machine_is_compatible() solves that though.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Conor Dooley <conor@kernel.org>
To: Mina Chou <minachou@andestech.com>
Cc: pjw@kernel.org, palmer@dabbelt.com, aou@eecs.berkeley.edu,
alex@ghiti.fr, jic23@kernel.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org, geert+renesas@glider.be,
magnus.damm@gmail.com, prabhakar.mahadev-lad.rj@bp.renesas.com,
linux-riscv@lists.infradead.org, devicetree@vger.kernel.org,
linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
randolph@andestech.com, cyyang772@andestech.com,
tim609@andestech.com, az70021@gmail.com
Subject: Re: [PATCH v2 18/19] riscv: errata: andes: limit the IOCP workaround to RZ/Five
Date: Tue, 17 Nov 2026 17:37:59 +0000 [thread overview]
Message-ID: <20261117-grape-skeletal-89da442523ce@spud> (raw)
In-Reply-To: <avwdT/vGjfsUCkHv@atcsi01.andestech.com>
[-- Attachment #1.1: Type: text/plain, Size: 1165 bytes --]
On Tue, Nov 17, 2026 at 05:24:31PM +0800, Mina Chou wrote:
> On Fri, Nov 13, 2026 at 01:53:29PM +0000, Conor Dooley wrote:
> > > Move the match into soc_is_r9a07g043f() and make it also require
> > > ARCH_R9A07G043. Kernels without RZ/Five support then skip the SBI call
> > > and take the generic Andes cache errata path. No other upstream-
> > > supported SoC uses this AX45MP mimpid, so their behavior does not
> > > change.
> >
> > But a device using this soc that doesn't have a dts in mainline won't
> > function properly, so this is fragile. Why not just do it properly and
> > check for RZ/Five specifically?
> > Can check for of_machine_is_compatible() probably?
>
> I will check for RZ/Five with of_machine_is_compatible("renesas,r9a07g043"),
> which on RISC-V is only used by RZ/Five, and drop the marchid/mimpid match.
Looking at what is quoted, I wonder if my main point I forgot to
include. Checking for ARCH_R9... (or any other SoC in that manner) will
fall over on multiplatform kernels. Code needs to be written so that no
matter what Kconfig options are enabled it will work.
of_machine_is_compatible() solves that though.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 161 bytes --]
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2026-11-17 17:38 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-13 7:11 [PATCH v2 00/19] riscv: andes: make the LLC driver and cache errata generic Mina Hui-Min Chou
2026-11-13 7:11 ` Mina Hui-Min Chou
2026-11-13 7:11 ` [PATCH v2 01/19] cache: ax45mp_cache: use __initconst for ax45mp_cmo_ops Mina Hui-Min Chou
2026-11-13 7:11 ` Mina Hui-Min Chou
2026-11-13 7:11 ` [PATCH v2 02/19] cache: ax45mp_cache: rename AX45MP-specific identifiers to generic ANDES Mina Hui-Min Chou
2026-11-13 7:11 ` Mina Hui-Min Chou
2026-11-13 7:11 ` [PATCH v2 03/19] cache: ax45mp_cache: rename L2 identifiers to LLC Mina Hui-Min Chou
2026-11-13 7:11 ` Mina Hui-Min Chou
2026-11-13 7:11 ` [PATCH v2 04/19] cache: ax45mp_cache: add shared header for Andes CSRs Mina Hui-Min Chou
2026-11-13 7:11 ` Mina Hui-Min Chou
2026-11-13 7:11 ` [PATCH v2 05/19] cache: ax45mp_cache: standardize macro naming for LLC and L1D registers Mina Hui-Min Chou
2026-11-13 7:11 ` Mina Hui-Min Chou
2026-11-13 7:11 ` [PATCH v2 06/19] cache: ax45mp_cache: rename ax45mp_cache.c to andes_llcache.c Mina Hui-Min Chou
2026-11-13 7:11 ` Mina Hui-Min Chou
2026-11-13 7:11 ` [PATCH v2 07/19] cache: andes_llcache: clean up cache inv/wback functions Mina Hui-Min Chou
2026-11-13 7:11 ` Mina Hui-Min Chou
2026-11-13 7:11 ` [PATCH v2 08/19] cache: andes_llcache: use u32 and fix the cache-line-size error message Mina Hui-Min Chou
2026-11-13 7:11 ` Mina Hui-Min Chou
2026-11-13 7:11 ` [PATCH v2 09/19] cache: andes_llcache: write the full physical address for CCTL Mina Hui-Min Chou
2026-11-13 7:11 ` Mina Hui-Min Chou
2026-11-13 7:11 ` [PATCH v2 10/19] cache: andes_llcache: register cache ops only when the errata needs them Mina Hui-Min Chou
2026-11-13 7:11 ` Mina Hui-Min Chou
2026-11-13 7:11 ` [PATCH v2 11/19] cache: andes_llcache: use the hart ID to index the CCTL registers Mina Hui-Min Chou
2026-11-13 7:11 ` Mina Hui-Min Chou
2026-11-13 7:11 ` [PATCH v2 12/19] dt-bindings: cache: andestech: update schema for generic LLC support Mina Hui-Min Chou
2026-11-13 7:11 ` Mina Hui-Min Chou
2026-11-13 14:05 ` Conor Dooley
2026-11-13 14:05 ` Conor Dooley
2026-11-16 12:05 ` Krzysztof Kozlowski
2026-11-16 12:05 ` Krzysztof Kozlowski
2026-11-16 18:00 ` Conor Dooley
2026-11-16 18:00 ` Conor Dooley
2026-11-17 9:20 ` Mina Chou
2026-11-17 9:20 ` Mina Chou
2026-11-13 7:11 ` [PATCH v2 13/19] dt-bindings: cache: rename andestech,ax45mp-cache to andestech,llcache Mina Hui-Min Chou
2026-11-13 7:11 ` Mina Hui-Min Chou
2026-11-13 14:01 ` Conor Dooley
2026-11-13 14:01 ` Conor Dooley
2026-11-16 12:01 ` Krzysztof Kozlowski
2026-11-16 12:01 ` Krzysztof Kozlowski
2026-11-13 7:11 ` [PATCH v2 14/19] cache: andes_llcache: add generic andestech,llcache compatible Mina Hui-Min Chou
2026-11-13 7:11 ` Mina Hui-Min Chou
2026-11-13 7:11 ` [PATCH v2 15/19] MAINTAINERS: Add maintainer for Andes cache driver Mina Hui-Min Chou
2026-11-13 7:11 ` Mina Hui-Min Chou
2026-11-13 7:11 ` [PATCH v2 16/19] riscv: errata: andes: allow ERRATA_ANDES_CMO on all Andes SoCs Mina Hui-Min Chou
2026-11-13 7:11 ` Mina Hui-Min Chou
2026-11-13 14:00 ` Conor Dooley
2026-11-13 14:00 ` Conor Dooley
2026-11-17 3:28 ` Mina Chou
2026-11-17 3:28 ` Mina Chou
2026-11-13 7:11 ` [PATCH v2 17/19] riscv: errata: andes: generalize cache errata for Andes cores Mina Hui-Min Chou
2026-11-13 7:11 ` Mina Hui-Min Chou
2026-11-13 13:59 ` Conor Dooley
2026-11-13 13:59 ` Conor Dooley
2026-11-17 10:11 ` Mina Chou
2026-11-17 10:11 ` Mina Chou
2026-11-13 7:11 ` [PATCH v2 18/19] riscv: errata: andes: limit the IOCP workaround to RZ/Five Mina Hui-Min Chou
2026-11-13 7:11 ` Mina Hui-Min Chou
2026-11-13 13:53 ` Conor Dooley
2026-11-13 13:53 ` Conor Dooley
2026-11-17 9:24 ` Mina Chou
2026-11-17 9:24 ` Mina Chou
2026-11-17 17:37 ` Conor Dooley [this message]
2026-11-17 17:37 ` Conor Dooley
2026-11-13 16:21 ` [PATCH v2 00/19] riscv: andes: make the LLC driver and cache errata generic Conor Dooley
2026-11-13 16:21 ` Conor Dooley
2026-11-16 1:22 ` Mina Chou
2026-11-16 1:22 ` Mina Chou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261117-grape-skeletal-89da442523ce@spud \
--to=conor@kernel.org \
--cc=alex@ghiti.fr \
--cc=aou@eecs.berkeley.edu \
--cc=az70021@gmail.com \
--cc=conor+dt@kernel.org \
--cc=cyyang772@andestech.com \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=magnus.damm@gmail.com \
--cc=minachou@andestech.com \
--cc=palmer@dabbelt.com \
--cc=pjw@kernel.org \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=randolph@andestech.com \
--cc=robh@kernel.org \
--cc=tim609@andestech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.