All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ata: libata-core: remove two WDC BROKEN_HPA quirks that never match
@ 2026-11-17 13:02 Niklas Cassel
  2026-11-17 13:07 ` Damien Le Moal
  2026-11-17 13:25 ` Niklas Cassel
  0 siblings, 2 replies; 3+ messages in thread
From: Niklas Cassel @ 2026-11-17 13:02 UTC (permalink / raw)
  To: Damien Le Moal, Niklas Cassel; +Cc: linux-ide

The second field of a __ata_dev_quirks[] entry is matched against the
firmware revision of the device, which ata_dev_quirks() reads into a
buffer of ATA_ID_FW_REV_LEN (8) characters. The ATA_QUIRK_BROKEN_HPA
entries for "WDC WD3200JD-00KLB0" and "WDC WD2500JD-00HBB0" instead
contain "WD-WCAMR1130137" and "WD-WMAL71490727", which look like drive
serial numbers. Without wildcards, these 15 character patterns can never
match a firmware revision, so the two entries have not applied to any
drive since they were added in commit 16c55b038033 ("libata: implement
BROKEN_HPA horkage and apply it to affected drives").

Remove them. The quirks applied to all drives are unchanged: these
models keep getting their quirks from the "WDC WD2500JD-*" and
"WDC WD3200JD-*" entries.

Signed-off-by: Niklas Cassel <cassel@kernel.org>
---
 drivers/ata/libata-core.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index 2a5ca1b9ee5c..96aa941c4810 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -4331,8 +4331,6 @@ static const struct ata_dev_quirks_entry __ata_dev_quirks[] = {
 
 	/* devices which puke on READ_NATIVE_MAX */
 	{ "HDS724040KLSA80",	"KFAOA20N",	ATA_QUIRK_BROKEN_HPA },
-	{ "WDC WD3200JD-00KLB0", "WD-WCAMR1130137", ATA_QUIRK_BROKEN_HPA },
-	{ "WDC WD2500JD-00HBB0", "WD-WMAL71490727", ATA_QUIRK_BROKEN_HPA },
 	{ "MAXTOR 6L080L4",	"A93.0500",	ATA_QUIRK_BROKEN_HPA },
 
 	/* this one allows HPA unlocking but fails IOs on the area */
-- 
2.56.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] ata: libata-core: remove two WDC BROKEN_HPA quirks that never match
  2026-11-17 13:02 [PATCH] ata: libata-core: remove two WDC BROKEN_HPA quirks that never match Niklas Cassel
@ 2026-11-17 13:07 ` Damien Le Moal
  2026-11-17 13:25 ` Niklas Cassel
  1 sibling, 0 replies; 3+ messages in thread
From: Damien Le Moal @ 2026-11-17 13:07 UTC (permalink / raw)
  To: Niklas Cassel; +Cc: linux-ide

On 11/17/26 05:02, Niklas Cassel wrote:
> The second field of a __ata_dev_quirks[] entry is matched against the
> firmware revision of the device, which ata_dev_quirks() reads into a
> buffer of ATA_ID_FW_REV_LEN (8) characters. The ATA_QUIRK_BROKEN_HPA
> entries for "WDC WD3200JD-00KLB0" and "WDC WD2500JD-00HBB0" instead
> contain "WD-WCAMR1130137" and "WD-WMAL71490727", which look like drive
> serial numbers. Without wildcards, these 15 character patterns can never
> match a firmware revision, so the two entries have not applied to any
> drive since they were added in commit 16c55b038033 ("libata: implement
> BROKEN_HPA horkage and apply it to affected drives").
> 
> Remove them. The quirks applied to all drives are unchanged: these
> models keep getting their quirks from the "WDC WD2500JD-*" and
> "WDC WD3200JD-*" entries.
> 
> Signed-off-by: Niklas Cassel <cassel@kernel.org>

Reviewed-by: Damien Le Moal <dlemoal@kernel.org>

-- 
Damien Le Moal
Western Digital Research

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ata: libata-core: remove two WDC BROKEN_HPA quirks that never match
  2026-11-17 13:02 [PATCH] ata: libata-core: remove two WDC BROKEN_HPA quirks that never match Niklas Cassel
  2026-11-17 13:07 ` Damien Le Moal
@ 2026-11-17 13:25 ` Niklas Cassel
  1 sibling, 0 replies; 3+ messages in thread
From: Niklas Cassel @ 2026-11-17 13:25 UTC (permalink / raw)
  To: Damien Le Moal, Niklas Cassel; +Cc: linux-ide

On Tue, 17 Nov 2026 14:02:39 +0100, Niklas Cassel wrote:
> The second field of a __ata_dev_quirks[] entry is matched against the
> firmware revision of the device, which ata_dev_quirks() reads into a
> buffer of ATA_ID_FW_REV_LEN (8) characters. The ATA_QUIRK_BROKEN_HPA
> entries for "WDC WD3200JD-00KLB0" and "WDC WD2500JD-00HBB0" instead
> contain "WD-WCAMR1130137" and "WD-WMAL71490727", which look like drive
> serial numbers. Without wildcards, these 15 character patterns can never
> match a firmware revision, so the two entries have not applied to any
> drive since they were added in commit 16c55b038033 ("libata: implement
> BROKEN_HPA horkage and apply it to affected drives").
> 
> [...]

Applied to libata/linux.git (for-7.5), thanks!

[1/1] ata: libata-core: remove two WDC BROKEN_HPA quirks that never match
      https://git.kernel.org/libata/linux/c/3391ac40

Kind regards,
Niklas


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-11-17 13:25 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-17 13:02 [PATCH] ata: libata-core: remove two WDC BROKEN_HPA quirks that never match Niklas Cassel
2026-11-17 13:07 ` Damien Le Moal
2026-11-17 13:25 ` Niklas Cassel

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.