* Re: [PATCH 2/5] arm64: dts: qcom: sc8180x: Add Microsoft Surface Pro X @ 2026-11-17 23:07 kernel test robot 0 siblings, 0 replies; 8+ messages in thread From: kernel test robot @ 2026-11-17 23:07 UTC (permalink / raw) To: oe-kbuild; +Cc: lkp :::::: :::::: Manual check reason: "linux-review patch is more than 7 days old, verify it wasn't already superseded" :::::: BCC: lkp@intel.com CC: llvm@lists.linux.dev CC: oe-kbuild-all@lists.linux.dev In-Reply-To: <20261104070441.74127-3-val@packett.cool> References: <20261104070441.74127-3-val@packett.cool> TO: Val Packett <val@packett.cool> TO: Bjorn Andersson <andersson@kernel.org> TO: Konrad Dybcio <konradybcio@kernel.org> TO: Abel Vesa <abelvesa@kernel.org> TO: Rob Herring <robh@kernel.org> TO: Krzysztof Kozlowski <krzk@kernel.org> TO: Conor Dooley <conor+dt@kernel.org> CC: Maximilian Luz <luzmaximilian@gmail.com> CC: Hans de Goede <hansg@kernel.org> CC: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com> CC: Alexandre Belloni <alexandre.belloni@bootlin.com> CC: linux-arm-msm@vger.kernel.org CC: devicetree@vger.kernel.org CC: linux-kernel@vger.kernel.org CC: linux-rtc@vger.kernel.org CC: Val Packett <val@packett.cool> Hi Val, kernel test robot noticed the following build errors: [auto build test ERROR on robh/for-next] [also build test ERROR on abelloni/rtc-next abelvesa/for-next linus/master v7.4-rc3 next-20261116] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Val-Packett/dt-bindings-arm-qcom-Document-Microsoft-Surface-Pro-X/20261104-040432 base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next patch link: https://lore.kernel.org/r/20261104070441.74127-3-val%40packett.cool patch subject: [PATCH 2/5] arm64: dts: qcom: sc8180x: Add Microsoft Surface Pro X :::::: branch date: 2 weeks ago :::::: commit date: 2 weeks ago config: arm64-allmodconfig (https://download.01.org/0day-ci/archive/20261118/202611180504.XxXMU3Rs-lkp@intel.com/config) compiler: clang version 24.0.0git (https://github.com/llvm/llvm-project 5dabc01bba1df10de6fb3c32fcf9db4aafe78f38) rustc: rustc 1.96.0 (ac68faa20 2026-05-25) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20261118/202611180504.XxXMU3Rs-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@intel.com> | Closes: https://lore.kernel.org/r/202611180504.XxXMU3Rs-lkp@intel.com/ All errors (new ones prefixed by >>): Error: arch/arm64/boot/dts/qcom/sc8180x-microsoft-surface-pro-x.dtsi:400.1-11 Label or path smb2351_2 not found Error: arch/arm64/boot/dts/qcom/sc8180x-microsoft-surface-pro-x.dtsi:404.1-11 Label or path smb2351_a not found Error: arch/arm64/boot/dts/qcom/sc8180x-microsoft-surface-pro-x.dtsi:803.1-17 Label or path remoteproc_slpi not found Error: arch/arm64/boot/dts/qcom/sc8180x-microsoft-cambria.dts:34.1-17 Label or path remoteproc_slpi not found >> FATAL ERROR: Syntax error parsing input tree -- Error: arch/arm64/boot/dts/qcom/sc8180x-microsoft-surface-pro-x.dtsi:400.1-11 Label or path smb2351_2 not found Error: arch/arm64/boot/dts/qcom/sc8180x-microsoft-surface-pro-x.dtsi:404.1-11 Label or path smb2351_a not found Error: arch/arm64/boot/dts/qcom/sc8180x-microsoft-surface-pro-x.dtsi:803.1-17 Label or path remoteproc_slpi not found Error: arch/arm64/boot/dts/qcom/sc8180x-microsoft-carina.dts:46.1-17 Label or path remoteproc_slpi not found >> FATAL ERROR: Syntax error parsing input tree -- Error: arch/arm64/boot/dts/qcom/sc8180x-microsoft-surface-pro-x.dtsi:400.1-11 Label or path smb2351_2 not found Error: arch/arm64/boot/dts/qcom/sc8180x-microsoft-surface-pro-x.dtsi:404.1-11 Label or path smb2351_a not found Error: arch/arm64/boot/dts/qcom/sc8180x-microsoft-surface-pro-x.dtsi:803.1-17 Label or path remoteproc_slpi not found Error: arch/arm64/boot/dts/qcom/sc8180x-microsoft-caspar.dts:34.1-17 Label or path remoteproc_slpi not found >> FATAL ERROR: Syntax error parsing input tree -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 0/5] Add support for the Microsoft Surface Pro X @ 2026-11-04 7:04 Val Packett 2026-11-04 7:04 ` [PATCH 2/5] arm64: dts: qcom: sc8180x: Add " Val Packett 0 siblings, 1 reply; 8+ messages in thread From: Val Packett @ 2026-11-04 7:04 UTC (permalink / raw) Cc: Val Packett, Bjorn Andersson, Konrad Dybcio, Abel Vesa, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Maximilian Luz, Hans de Goede, Ilpo Järvinen, Alexandre Belloni, linux-arm-msm, devicetree, linux-kernel, linux-rtc The Surface Pro X is a 2019-era tablet powered by the Qualcomm SC8180X SoC, released in three variants (SQ1, Wi-Fi, SQ2). Patches to support it have been around in a downstream tree at https://github.com/linux-surface/kernel for a while. Let's upstream it! I have permission from Maximilian Luz to use his From/S-o-b with modified (squashed, stripped down and split by model variant) patches: https://github.com/linux-surface/surface-pro-x/issues/7#issuecomment-6597291831 One aspect that will need some input from people with internal qcom docs :) is the PCIe setup. There is sort of a multi PHY or multi controller setup, and for now we've been setting up a single controller with num-lanes=<2> and it does work, but it's not the proper way to do it.. Thanks, ~val Maximilian Luz (3): arm64: dts: qcom: sc8180x: Add Microsoft Surface Pro X rtc: Add basic support for RTC via Surface System Aggregator Module platform/surface: aggregator_registry: Add support for Surface Pro X Val Packett (2): dt-bindings: arm: qcom: Document Microsoft Surface Pro X firmware: qcom: scm: Allow QSEECOM on the Surface Pro X .../devicetree/bindings/arm/qcom.yaml | 4 +- MAINTAINERS | 8 + arch/arm64/boot/dts/qcom/Makefile | 3 + .../dts/qcom/sc8180x-microsoft-cambria.dts | 38 + .../dts/qcom/sc8180x-microsoft-carina.dts | 50 + .../dts/qcom/sc8180x-microsoft-caspar.dts | 38 + .../qcom/sc8180x-microsoft-surface-pro-x.dtsi | 853 ++++++++++++++++++ drivers/firmware/qcom/qcom_scm.c | 3 + .../surface/surface_aggregator_registry.c | 26 + drivers/rtc/Kconfig | 9 + drivers/rtc/Makefile | 1 + drivers/rtc/rtc-surface.c | 129 +++ 12 files changed, 1161 insertions(+), 1 deletion(-) create mode 100644 arch/arm64/boot/dts/qcom/sc8180x-microsoft-cambria.dts create mode 100644 arch/arm64/boot/dts/qcom/sc8180x-microsoft-carina.dts create mode 100644 arch/arm64/boot/dts/qcom/sc8180x-microsoft-caspar.dts create mode 100644 arch/arm64/boot/dts/qcom/sc8180x-microsoft-surface-pro-x.dtsi create mode 100644 drivers/rtc/rtc-surface.c -- 2.56.0 ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 2/5] arm64: dts: qcom: sc8180x: Add Microsoft Surface Pro X 2026-11-04 7:04 [PATCH 0/5] Add support for the " Val Packett @ 2026-11-04 7:04 ` Val Packett 2026-11-04 7:22 ` sashiko-bot ` (2 more replies) 0 siblings, 3 replies; 8+ messages in thread From: Val Packett @ 2026-11-04 7:04 UTC (permalink / raw) To: Bjorn Andersson, Konrad Dybcio, Abel Vesa, Rob Herring, Krzysztof Kozlowski, Conor Dooley Cc: Maximilian Luz, Hans de Goede, Ilpo Järvinen, Alexandre Belloni, linux-arm-msm, devicetree, linux-kernel, linux-rtc, Val Packett From: Maximilian Luz <luzmaximilian@gmail.com> Introduce a device tree for the Surface Pro X tablet in all 3 variants (SQ1 with cellular, SQ1 Wi-Fi only, SQ2 with cellular). Currently working: * Display, backlight (eDP panel) * USB 2.0 * Wi-Fi and Bluetooth (WCN3998) * NVMe on PCIe2 * Embedded controller (Surface SAM over UART) * All remoteprocs (ADSP, CDSP, MPSS, SLPI) * Volume and power buttons Signed-off-by: Maximilian Luz <luzmaximilian@gmail.com> Signed-off-by: Val Packett <val@packett.cool> --- arch/arm64/boot/dts/qcom/Makefile | 3 + .../dts/qcom/sc8180x-microsoft-cambria.dts | 38 + .../dts/qcom/sc8180x-microsoft-carina.dts | 50 + .../dts/qcom/sc8180x-microsoft-caspar.dts | 38 + .../qcom/sc8180x-microsoft-surface-pro-x.dtsi | 853 ++++++++++++++++++ 5 files changed, 982 insertions(+) create mode 100644 arch/arm64/boot/dts/qcom/sc8180x-microsoft-cambria.dts create mode 100644 arch/arm64/boot/dts/qcom/sc8180x-microsoft-carina.dts create mode 100644 arch/arm64/boot/dts/qcom/sc8180x-microsoft-caspar.dts create mode 100644 arch/arm64/boot/dts/qcom/sc8180x-microsoft-surface-pro-x.dtsi diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile index d6e440cd252b..dcaf74dc876b 100644 --- a/arch/arm64/boot/dts/qcom/Makefile +++ b/arch/arm64/boot/dts/qcom/Makefile @@ -324,6 +324,9 @@ dtb-$(CONFIG_ARCH_QCOM) += sc7280-idp.dtb dtb-$(CONFIG_ARCH_QCOM) += sc7280-idp2.dtb dtb-$(CONFIG_ARCH_QCOM) += sc7280-crd-r3.dtb dtb-$(CONFIG_ARCH_QCOM) += sc8180x-lenovo-flex-5g.dtb +dtb-$(CONFIG_ARCH_QCOM) += sc8180x-microsoft-cambria.dtb +dtb-$(CONFIG_ARCH_QCOM) += sc8180x-microsoft-carina.dtb +dtb-$(CONFIG_ARCH_QCOM) += sc8180x-microsoft-caspar.dtb dtb-$(CONFIG_ARCH_QCOM) += sc8180x-primus.dtb sc8280xp-crd-el2-dtbs := sc8280xp-crd.dtb sc8280xp-el2.dtbo dtb-$(CONFIG_ARCH_QCOM) += sc8280xp-crd.dtb sc8280xp-crd-el2.dtb diff --git a/arch/arm64/boot/dts/qcom/sc8180x-microsoft-cambria.dts b/arch/arm64/boot/dts/qcom/sc8180x-microsoft-cambria.dts new file mode 100644 index 000000000000..fcf7e49b3ae4 --- /dev/null +++ b/arch/arm64/boot/dts/qcom/sc8180x-microsoft-cambria.dts @@ -0,0 +1,38 @@ +// SPDX-License-Identifier: BSD-3-Clause + +/dts-v1/; + +#include "sc8180x-microsoft-surface-pro-x.dtsi" + +/ { + model = "Microsoft Surface Pro X (SQ1)"; + compatible = "microsoft,cambria", "qcom,sc8180x"; +}; + +&gpu_zap_shader { + firmware-name = "qcom/sc8180x/microsoft/cambria/qcdxkmsuc8180.mbn"; +}; + +&remoteproc_adsp { + firmware-name = "qcom/sc8180x/microsoft/cambria/qcadsp8180.mbn"; + + status = "okay"; +}; + +&remoteproc_cdsp { + firmware-name = "qcom/sc8180x/microsoft/cambria/qccdsp8180.mbn"; + + status = "okay"; +}; + +&remoteproc_mpss { + firmware-name = "qcom/sc8180x/microsoft/cambria/qcmpss8180.mbn"; + + status = "okay"; +}; + +&remoteproc_slpi { + firmware-name = "qcom/sc8180x/microsoft/cambria/qcslpi8180.mbn"; + + status = "okay"; +}; diff --git a/arch/arm64/boot/dts/qcom/sc8180x-microsoft-carina.dts b/arch/arm64/boot/dts/qcom/sc8180x-microsoft-carina.dts new file mode 100644 index 000000000000..5d155c69907a --- /dev/null +++ b/arch/arm64/boot/dts/qcom/sc8180x-microsoft-carina.dts @@ -0,0 +1,50 @@ +// SPDX-License-Identifier: BSD-3-Clause + +/dts-v1/; + +#include "sc8180x-microsoft-surface-pro-x.dtsi" + +/ { + model = "Microsoft Surface Pro X (SQ2)"; + compatible = "microsoft,carina", "qcom,sc8180x"; +}; + +&cpu4_opp_table { + opp-3072000000 { + opp-hz = /bits/ 64 <3072000000>; + opp-peak-kBps = <8368000 51609600>; + }; + + opp-3148800000 { + opp-hz = /bits/ 64 <3148800000>; + opp-peak-kBps = <8368000 51609600>; + }; +}; + +&gpu_zap_shader { + firmware-name = "qcom/sc8180x/microsoft/carina/qcdxkmsuc8180.mbn"; +}; + +&remoteproc_adsp { + firmware-name = "qcom/sc8180x/microsoft/carina/qcadsp8180.mbn"; + + status = "okay"; +}; + +&remoteproc_cdsp { + firmware-name = "qcom/sc8180x/microsoft/carina/qccdsp8180.mbn"; + + status = "okay"; +}; + +&remoteproc_mpss { + firmware-name = "qcom/sc8180x/microsoft/carina/qcmpss8180.mbn"; + + status = "okay"; +}; + +&remoteproc_slpi { + firmware-name = "qcom/sc8180x/microsoft/carina/qcslpi8180.mbn"; + + status = "okay"; +}; diff --git a/arch/arm64/boot/dts/qcom/sc8180x-microsoft-caspar.dts b/arch/arm64/boot/dts/qcom/sc8180x-microsoft-caspar.dts new file mode 100644 index 000000000000..df42020ff81a --- /dev/null +++ b/arch/arm64/boot/dts/qcom/sc8180x-microsoft-caspar.dts @@ -0,0 +1,38 @@ +// SPDX-License-Identifier: BSD-3-Clause + +/dts-v1/; + +#include "sc8180x-microsoft-surface-pro-x.dtsi" + +/ { + model = "Microsoft Surface Pro X (Wi-Fi)"; + compatible = "microsoft,caspar", "qcom,sc8180x"; +}; + +&gpu_zap_shader { + firmware-name = "qcom/sc8180x/microsoft/caspar/qcdxkmsuc8180.mbn"; +}; + +&remoteproc_adsp { + firmware-name = "qcom/sc8180x/microsoft/caspar/qcadsp8180.mbn"; + + status = "okay"; +}; + +&remoteproc_cdsp { + firmware-name = "qcom/sc8180x/microsoft/caspar/qccdsp8180.mbn"; + + status = "okay"; +}; + +&remoteproc_mpss { + firmware-name = "qcom/sc8180x/microsoft/caspar/qcmpss8180_nm.mbn"; + + status = "okay"; +}; + +&remoteproc_slpi { + firmware-name = "qcom/sc8180x/microsoft/caspar/qcslpi8180.mbn"; + + status = "okay"; +}; diff --git a/arch/arm64/boot/dts/qcom/sc8180x-microsoft-surface-pro-x.dtsi b/arch/arm64/boot/dts/qcom/sc8180x-microsoft-surface-pro-x.dtsi new file mode 100644 index 000000000000..17fb01c6b164 --- /dev/null +++ b/arch/arm64/boot/dts/qcom/sc8180x-microsoft-surface-pro-x.dtsi @@ -0,0 +1,853 @@ +// SPDX-License-Identifier: BSD-3-Clause +/* + * Based on: + % - sc8180x-primus.dts + % - sc8180x-lenovo-flex-5g.dts + */ + +/dts-v1/; + +#include <dt-bindings/gpio/gpio.h> +#include <dt-bindings/input/linux-event-codes.h> +#include <dt-bindings/interrupt-controller/irq.h> +#include <dt-bindings/regulator/qcom,rpmh-regulator.h> +#include <dt-bindings/spmi/spmi.h> +#include <dt-bindings/iio/qcom,spmi-vadc.h> +#include "sc8180x.dtsi" +#include "sc8180x-pmics.dtsi" + +/delete-node/ &gpu_mem; + +/ { + chassis-type = "tablet"; + + aliases { + serial0 = &uart13; + serial1 = &uart15; + }; + + backlight: backlight { + compatible = "pwm-backlight"; + + pwms = <&pmc8180c_lpg 4 5000000>; + enable-gpios = <&pmc8180_2_gpios 1 GPIO_ACTIVE_HIGH>; + + pinctrl-names = "default"; + pinctrl-0 = <&bl_pwm_default_state &bl_en_default_state>; + }; + + gpio-keys-volume { + compatible = "gpio-keys"; + label = "Volume Buttons"; + autorepeat; + + pinctrl-names = "default"; + pinctrl-0 = <&volume_down_gpio &volume_up_gpio>; + + volume-down { + label = "Volume Down"; + gpios = <&pmc8180_1_gpios 1 GPIO_ACTIVE_LOW>; + linux,code = <KEY_VOLUMEDOWN>; + }; + + volume-up { + label = "Volume Up"; + gpios = <&pmc8180_1_gpios 6 GPIO_ACTIVE_LOW>; + linux,code = <KEY_VOLUMEUP>; + }; + }; + + chosen { + }; + + reserved-memory { + rmtfs_mem: memory@85500000 { + compatible = "qcom,rmtfs-mem"; + reg = <0x0 0x85500000 0x0 0x200000>; + no-map; + + qcom,client-id = <1>; + qcom,vmid = <15>; + }; + + wlan_mem: memory@8bc00000 { + reg = <0x0 0x8bc00000 0x0 0x180000>; + no-map; + }; + + mpss_mem: memory@8d800000 { /* non-relocatable */ + reg = <0x0 0x8d800000 0x0 0x9600000>; + no-map; + }; + + adsp_mem: memory@96e00000 { + reg = <0x0 0x96e00000 0x0 0x1c00000>; + no-map; + }; + + cdsp_mem: memory@98a00000 { + reg = <0x0 0x98a00000 0x0 0x800000>; + no-map; + }; + + slpi_mem: memory@99200000 { + reg = <0x0 0x99200000 0x0 0x1400000>; + no-map; + }; + + venus_mem: memory@9a600000 { + reg = <0x0 0x9a600000 0x0 0x500000>; + no-map; + }; + + gfxsuc_mem: memory@9ab00000 { + reg = <0x0 0x9ab00000 0x0 0x5000>; + no-map; + }; + + linux,cma { + compatible = "shared-dma-pool"; + size = <0x0 0x8000000>; + reusable; + linux,cma-default; + }; + }; + + thermal-zones { + pmc8180a-thermal { + polling-delay-passive = <100>; + polling-delay = <0>; + + thermal-sensors = <&pmc8180_temp>; + + trips { + trip0 { + temperature = <95000>; + hysteresis = <0>; + type = "passive"; + }; + + trip1 { + temperature = <115000>; + hysteresis = <0>; + type = "hot"; + }; + + trip2 { + temperature = <145000>; + hysteresis = <0>; + type = "critical"; + }; + }; + }; + + pmc8180c-thermal { + polling-delay-passive = <100>; + polling-delay = <0>; + + thermal-sensors = <&pmc8180c_temp>; + + trips { + trip0 { + temperature = <95000>; + hysteresis = <0>; + type = "passive"; + }; + + trip1 { + temperature = <115000>; + hysteresis = <0>; + type = "hot"; + }; + + trip2 { + temperature = <145000>; + hysteresis = <0>; + type = "critical"; + }; + }; + }; + + pmc8180e-thermal { + polling-delay-passive = <100>; + polling-delay = <0>; + + thermal-sensors = <&pmc8180e_temp>; + + trips { + trip0 { + temperature = <95000>; + hysteresis = <0>; + type = "passive"; + }; + + trip1 { + temperature = <115000>; + hysteresis = <0>; + type = "hot"; + }; + + trip2 { + temperature = <145000>; + hysteresis = <0>; + type = "critical"; + }; + }; + }; + }; + + vph_pwr: vph-pwr-regulator { + compatible = "regulator-fixed"; + regulator-name = "vph_pwr"; + regulator-min-microvolt = <3700000>; + regulator-max-microvolt = <3700000>; + + regulator-always-on; + regulator-boot-on; + }; + + vreg_s4a_1p8: pm8150-s4 { + compatible = "regulator-fixed"; + regulator-name = "vreg_s4a_1p8"; + + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + + regulator-always-on; + regulator-boot-on; + + vin-supply = <&vph_pwr>; + }; +}; + +&apps_rsc { + pmc8180-a-rpmh-regulators { + compatible = "qcom,pmc8180-rpmh-regulators"; + qcom,pmic-id = "a"; + + vdd-s1-supply = <&vph_pwr>; + vdd-s2-supply = <&vph_pwr>; + vdd-s3-supply = <&vph_pwr>; + vdd-s4-supply = <&vph_pwr>; + vdd-s5-supply = <&vph_pwr>; + vdd-s6-supply = <&vph_pwr>; + vdd-s7-supply = <&vph_pwr>; + vdd-s8-supply = <&vph_pwr>; + vdd-s9-supply = <&vph_pwr>; + vdd-s10-supply = <&vph_pwr>; + + vdd-l1-l8-l11-supply = <&vreg_s6c_1p37>; + vdd-l2-l10-supply = <&vreg_bob>; + vdd-l3-l4-l5-l18-supply = <&vreg_s7c_0p96>; + vdd-l6-l9-supply = <&vreg_s6c_1p37>; + vdd-l7-l12-l14-l15-supply = <&vreg_s5a_2p04>; + vdd-l13-l16-l17-supply = <&vreg_bob>; + + vreg_s5a_2p04: smps5 { + regulator-min-microvolt = <2040000>; + regulator-max-microvolt = <2040000>; + }; + + vreg_l7a_1p8: ldo7 { + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; + }; + + vreg_l9a_1p3: ldo9 { + regulator-min-microvolt = <1296000>; + regulator-max-microvolt = <1304000>; + regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; + }; + + vreg_l12a_1p8: ldo12 { + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; + }; + }; + + pmc8180-e-rpmh-regulators { + compatible = "qcom,pmc8180-rpmh-regulators"; + qcom,pmic-id = "e"; + + vdd-s1-supply = <&vph_pwr>; + vdd-s2-supply = <&vph_pwr>; + vdd-s3-supply = <&vph_pwr>; + vdd-s4-supply = <&vph_pwr>; + vdd-s5-supply = <&vph_pwr>; + vdd-s6-supply = <&vph_pwr>; + vdd-s7-supply = <&vph_pwr>; + vdd-s8-supply = <&vph_pwr>; + vdd-s9-supply = <&vph_pwr>; + vdd-s10-supply = <&vph_pwr>; + + vdd-l1-l8-l11-supply = <&vreg_s4e_0p99>; + vdd-l2-l10-supply = <&vreg_bob>; + vdd-l3-l4-l5-l18-supply = <&vreg_s4e_0p99>; + vdd-l6-l9-supply = <&vreg_s4e_0p99>; + vdd-l7-l12-l14-l15-supply = <&vreg_s5e_2p04>; + vdd-l13-l16-l17-supply = <&vreg_bob>; + + vreg_s4e_0p99: smps4 { + regulator-min-microvolt = <992000>; + regulator-max-microvolt = <992000>; + regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; + }; + + vreg_s5e_2p04: smps5 { + regulator-min-microvolt = <2040000>; + regulator-max-microvolt = <2040000>; + regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; + }; + + vreg_l1e_0p75: ldo1 { + regulator-min-microvolt = <752000>; + regulator-max-microvolt = <752000>; + regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; + }; + + vreg_l5e_0p88: ldo5 { + regulator-min-microvolt = <880000>; + regulator-max-microvolt = <880000>; + regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; + }; + + vreg_l9e_0p88: ldo9 { + regulator-min-microvolt = <880000>; + regulator-max-microvolt = <880000>; + regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; + }; + + vreg_l16e_3p1: ldo16 { + regulator-min-microvolt = <3072000>; + regulator-max-microvolt = <3072000>; + regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; + }; + }; + + pmc8180c-rpmh-regulators { + compatible = "qcom,pmc8180c-rpmh-regulators"; + qcom,pmic-id = "c"; + + vdd-s1-supply = <&vph_pwr>; + vdd-s2-supply = <&vph_pwr>; + vdd-s3-supply = <&vph_pwr>; + vdd-s4-supply = <&vph_pwr>; + vdd-s5-supply = <&vph_pwr>; + vdd-s6-supply = <&vph_pwr>; + vdd-s7-supply = <&vph_pwr>; + vdd-s8-supply = <&vph_pwr>; + + vdd-l1-l8-supply = <&vreg_s4a_1p8>; + vdd-l2-l3-supply = <&vreg_s6c_1p37>; + vdd-l4-l5-l6-supply = <&vreg_bob>; + vdd-l7-l11-supply = <&vreg_bob>; + vdd-l9-l10-supply = <&vreg_bob>; + + vdd-bob-supply = <&vph_pwr>; + vdd-flash-supply = <&vreg_bob>; + vdd-rgb-supply = <&vreg_bob>; + + vreg_s6c_1p37: smps6 { + regulator-min-microvolt = <1350000>; + regulator-max-microvolt = <1372000>; + regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; + }; + + vreg_s7c_0p96: smps7 { + regulator-min-microvolt = <960000>; + regulator-max-microvolt = <960000>; + regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; + }; + + vreg_l3c_1p2: ldo3 { + regulator-min-microvolt = <1200000>; + regulator-max-microvolt = <1200000>; + regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; + }; + + vreg_l10c_3p3: ldo10 { + regulator-min-microvolt = <3296000>; + regulator-max-microvolt = <3312000>; + regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; + }; + + vreg_l11c_3p3: ldo11 { + regulator-min-microvolt = <3296000>; + regulator-max-microvolt = <3304000>; + regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; + }; + + vreg_bob: bob { + regulator-min-microvolt = <3296000>; + regulator-max-microvolt = <3350000>; + regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; + }; + }; +}; + +&dispcc { + status = "okay"; +}; + +&gcc { + protected-clocks = <GCC_QSPI_CORE_CLK>, + <GCC_QSPI_CORE_CLK_SRC>, + <GCC_QSPI_CNOC_PERIPH_AHB_CLK>; +}; + +&smb2351_2 { + status = "disabled"; +}; + +&smb2351_a { + status = "disabled"; +}; + +&tlmm { + gpio-reserved-ranges = <0 4>, <47 4>; + + pcie1_default_state: pcie1-default-state { + clkreq-n-pins { + pins = "gpio176"; + function = "pci_e2"; + drive-strength = <2>; + bias-pull-up; + }; + + perst-n-pins { + pins = "gpio102"; + function = "gpio"; + drive-strength = <2>; + bias-disable; + }; + + wake-n-pins { + pins = "gpio104"; + function = "gpio"; + drive-strength = <2>; + bias-pull-up; + }; + }; + + uart13_state: uart13-state { + cts { + pins = "gpio43"; + function = "qup13"; + bias-pull-down; + }; + + rts-tx { + pins = "gpio44", "gpio45"; + function = "qup13"; + drive-strength = <2>; + bias-disable; + }; + + rx { + pins = "gpio46"; + function = "qup13"; + bias-pull-up; + }; + }; + + uart15_state: uart15-state { + cts { + pins = "gpio27"; + function = "qup15"; + bias-pull-down; + }; + + rts-tx { + pins = "gpio28", "gpio29"; + function = "qup15"; + drive-strength = <2>; + bias-disable; + }; + + rx { + pins = "gpio30"; + function = "qup15"; + bias-pull-up; + }; + }; + + ssam_state: ssam-state { + wake-int { + pins = "gpio180"; + function = "gpio"; + bias-disable; + }; + }; + + panel_vdd_en_default_state: panel-vdd-en-default-state { + pins = "gpio130"; + function = "gpio"; + + drive-strength = <2>; + bias-disable; + output-high; + }; + + edp_hpd_active: epd-hpd-active-state { + pins = "gpio10"; + function = "edp_hot"; + }; +}; + +&pmc8180_1_gpios { + volume_down_gpio: pmc8180a_gpio1 { + pins = "gpio1"; + function = "normal"; + input-enable; + bias-pull-up; + qcom,drive-strength = <0>; + }; + + volume_up_gpio: pmc8180a_gpio6 { + pins = "gpio6"; + function = "normal"; + input-enable; + bias-pull-up; + qcom,drive-strength = <0>; + }; +}; + +&pmc8180_2 { + pmc8180e_temp: temp-alarm@2400 { + compatible = "qcom,spmi-temp-alarm"; + reg = <0x2400>; + interrupts = <0x8 0x24 0x0 IRQ_TYPE_EDGE_BOTH>; + io-channels = <&pmc8180e_adc ADC5_DIE_TEMP>; + io-channel-names = "thermal"; + #thermal-sensor-cells = <0>; + }; + + pmc8180e_adc: adc@3100 { + compatible = "qcom,spmi-adc5"; + reg = <0x3100>; + #address-cells = <1>; + #size-cells = <0>; + #io-channel-cells = <1>; + interrupts = <0x8 0x31 0x0 IRQ_TYPE_EDGE_RISING>; + + ref-gnd@0 { + reg = <ADC5_REF_GND>; + qcom,pre-scaling = <1 1>; + label = "ref_gnd"; + }; + + vref-1p25@1 { + reg = <ADC5_1P25VREF>; + qcom,pre-scaling = <1 1>; + label = "vref_1p25"; + }; + + die-temp@6 { + reg = <ADC5_DIE_TEMP>; + qcom,pre-scaling = <1 1>; + label = "die_temp"; + }; + }; +}; + +&pmc8180_adc { + xo-therm@4c { + reg = <ADC5_XO_THERM_100K_PU>; + qcom,ratiometric; + qcom,pre-scaling = <1 1>; + qcom,hw-settle-time = <200>; + label = "xo_therm"; + }; + + vph-pwr@83 { + reg = <ADC5_VPH_PWR>; + qcom,pre-scaling = <1 3>; + label = "vph_pwr"; + }; + + vcoin@85 { + reg = <ADC5_VCOIN>; + qcom,pre-scaling = <1 3>; + label = "vcoin"; + }; +}; + +&pmc8180_pwrkey { + status = "okay"; +}; + +&pmc8180c_gpios { + bl_pwm_default_state: bl-pwm-default-state { + pins = "gpio10"; + function = "func1"; + }; +}; + +&pmc8180c_lpg { + status = "okay"; +}; + +&pmc8180_2_gpios { + bl_en_default_state: bl-pwm-default-state { + pins = "gpio1"; + function = "normal"; + }; +}; + +&spmi_bus { + pmc8180e_1: pmic@9 { + compatible = "qcom,pm8150", "qcom,spmi-pmic"; + reg = <0x9 SPMI_USID>; + #address-cells = <1>; + #size-cells = <0>; + }; +}; + +&gpu { + status = "okay"; +}; + +&gpu_zap_shader { + memory-region = <&gfxsuc_mem>; +}; + +&mdss { + status = "okay"; +}; + +&mdss_edp { + pinctrl-0 = <&edp_hpd_active>; + pinctrl-names = "default"; + + status = "okay"; + + aux-bus { + panel { + compatible = "edp-panel"; + enable-gpios = <&tlmm 130 GPIO_ACTIVE_HIGH>; + no-hpd; + + pinctrl-0 = <&panel_vdd_en_default_state>; + pinctrl-names = "default"; + + backlight = <&backlight>; + + port { + edp_panel_in: endpoint { + remote-endpoint = <&mdss_edp_out>; + }; + }; + }; + }; +}; + +&mdss_edp_out { + data-lanes = <0 1 2 3>; + remote-endpoint = <&edp_panel_in>; +}; + +&edp_phy { + vdda-pll-supply = <&vreg_l5e_0p88>; + vdda-phy-supply = <&vreg_l3c_1p2>; +}; + +&usb_prim_hsphy { + vdda-pll-supply = <&vreg_l9e_0p88>; + vdda18-supply = <&vreg_l12a_1p8>; + vdda33-supply = <&vreg_l16e_3p1>; + + status = "okay"; +}; + +&usb_prim_qmpphy { + vdda-phy-supply = <&vreg_l3c_1p2>; + vdda-pll-supply = <&vreg_l9e_0p88>; + + orientation-switch; + + status = "okay"; +}; + +&usb_prim { + status = "okay"; +}; + +&usb_prim_dwc3 { + dr_mode = "host"; +}; + +&usb_sec_hsphy { + vdda-pll-supply = <&vreg_l9e_0p88>; + vdda18-supply = <&vreg_l12a_1p8>; + vdda33-supply = <&vreg_l16e_3p1>; + + status = "okay"; +}; + +&usb_sec_qmpphy { + vdda-phy-supply = <&vreg_l3c_1p2>; + vdda-pll-supply = <&vreg_l9e_0p88>; + + orientation-switch; + + status = "okay"; +}; + +&usb_sec { + status = "okay"; +}; + +&usb_sec_dwc3 { + dr_mode = "host"; +}; + +&usb_mp_hsphy0 { + vdda-pll-supply = <&vreg_l9e_0p88>; + vdda18-supply = <&vreg_l12a_1p8>; + vdda33-supply = <&vreg_l16e_3p1>; + + status = "okay"; +}; + +&usb_mp_hsphy1 { + vdda-pll-supply = <&vreg_l9e_0p88>; + vdda18-supply = <&vreg_l12a_1p8>; + vdda33-supply = <&vreg_l16e_3p1>; + + status = "okay"; +}; + +&usb_mp_qmpphy0 { + vdda-phy-supply = <&vreg_l3c_1p2>; + vdda-pll-supply = <&vreg_l9e_0p88>; + + status = "okay"; +}; + +&usb_mp_qmpphy1 { + vdda-phy-supply = <&vreg_l3c_1p2>; + vdda-pll-supply = <&vreg_l9e_0p88>; + + status = "okay"; +}; + +&usb_mp { + status = "okay"; +}; + +&usb_mp_dwc3 { + dr_mode = "host"; +}; + +&pcie2 { + // XXX: pcie1 and pcie2 are multi'd together, for now use just one + num-lanes = <2>; + + pinctrl-0 = <&pcie1_default_state>; + pinctrl-names = "default"; + + // HACK: Remove "global" interrupt + interrupts = <GIC_SPI 672 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 671 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 670 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 669 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 668 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 667 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 666 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 665 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "msi0", + "msi1", + "msi2", + "msi3", + "msi4", + "msi5", + "msi6", + "msi7"; + + status = "okay"; +}; + +&pcie1_phy { + vdda-phy-supply = <&vreg_l5e_0p88>; + vdda-pll-supply = <&vreg_l3c_1p2>; + + status = "okay"; +}; + +&pcie2_phy { + vdda-phy-supply = <&vreg_l5e_0p88>; + vdda-pll-supply = <&vreg_l3c_1p2>; + + status = "okay"; +}; + +&pcie2_port0 { + reset-gpios = <&tlmm 102 GPIO_ACTIVE_LOW>; + wake-gpios = <&tlmm 104 GPIO_ACTIVE_LOW>; +}; + +&remoteproc_adsp { + memory-region = <&adsp_mem>; +}; + +&remoteproc_cdsp { + memory-region = <&cdsp_mem>; +}; + +&remoteproc_mpss { + memory-region = <&mpss_mem>; +}; + +&remoteproc_slpi { + memory-region = <&slpi_mem>; +}; + +&uart13 { + pinctrl-0 = <&uart13_state>; + pinctrl-names = "default"; + + status = "okay"; + + bluetooth { + compatible = "qcom,wcn3998-bt"; + + vddio-supply = <&vreg_s4a_1p8>; + vddxo-supply = <&vreg_l7a_1p8>; + vddrf-supply = <&vreg_l9a_1p3>; + vddch0-supply = <&vreg_l11c_3p3>; + + max-speed = <3200000>; + }; +}; + +&uart15 { + pinctrl-0 = <&uart15_state>; + pinctrl-names = "default"; + + status = "okay"; + + embedded-controller { + compatible = "microsoft,surface-sam"; + + interrupts-extended = <&tlmm 180 IRQ_TYPE_EDGE_RISING>; + + current-speed = <4000000>; + + pinctrl-0 = <&ssam_state>; + pinctrl-names = "default"; + }; +}; + +&wifi { + memory-region = <&wlan_mem>; + + vdd-0.8-cx-mx-supply = <&vreg_l1e_0p75>; + vdd-1.8-xo-supply = <&vreg_l7a_1p8>; + vdd-1.3-rfa-supply = <&vreg_l9a_1p3>; + vdd-3.3-ch0-supply = <&vreg_l11c_3p3>; + vdd-3.3-ch1-supply = <&vreg_l10c_3p3>; + + status = "okay"; +}; -- 2.56.0 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 2/5] arm64: dts: qcom: sc8180x: Add Microsoft Surface Pro X 2026-11-04 7:04 ` [PATCH 2/5] arm64: dts: qcom: sc8180x: Add " Val Packett @ 2026-11-04 7:22 ` sashiko-bot 2026-11-04 8:36 ` Konrad Dybcio 2026-11-15 3:16 ` Haipeng Lin 2 siblings, 0 replies; 8+ messages in thread From: sashiko-bot @ 2026-11-04 7:22 UTC (permalink / raw) To: Val Packett; +Cc: devicetree, linux-rtc, robh, conor+dt, Alexandre Belloni Thank you for your contribution! Sashiko AI review found 7 potential issue(s) to consider: - [High] arm64: dts: qcom: disabled qupv3_id_2 prevents uart13 and uart15 from probing - [Medium] arm64: dts: qcom: build failure from undefined smb2351_2 and smb2351_a labels - [Medium] arm64: dts: qcom: build failure from undefined remoteproc_slpi label - [Medium] arm64: dts: qcom: vdda-phy-supply and vdda-pll-supply swapped on USB QMP PHYs - [Medium] arm64: dts: qcom: missing power-supply and broken power sequencing on edp-panel - [Low] arm64: dts: qcom: duplicate pmc8180a-thermal zone for pmc8180_temp sensor - [Low] arm64: dts: qcom: child node names violate RSC, TLMM, PMIC GPIO, and ADC schemas -- commit 5309d200eb0928bd90998981b5c8364f2e0ed95e Author: Maximilian Luz <luzmaximilian@gmail.com> arm64: dts: qcom: sc8180x: Add Microsoft Surface Pro X This commit adds a common device tree include and three board device trees for the Microsoft Surface Pro X tablet variants (Cambria, Carina, and Caspar) based on the Qualcomm SC8180X platform. > diff --git a/arch/arm64/boot/dts/qcom/sc8180x-microsoft-surface-pro-x.dtsi b/arch/arm64/boot/dts/qcom/sc8180x-microsoft-surface-pro-x.dtsi > new file mode 100644 > index 0000000000000..17fb01c6b164f > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/sc8180x-microsoft-surface-pro-x.dtsi > @@ -0,0 +1,853 @@ [ ... ] > + thermal-zones { > + pmc8180a-thermal { > + polling-delay-passive = <100>; > + polling-delay = <0>; > + > + thermal-sensors = <&pmc8180_temp>; [Severity: Low] Should this node be named pmc8180-thermal instead of pmc8180a-thermal? Because sc8180x-pmics.dtsi already defines /thermal-zones/pmc8180-thermal with thermal-sensors = <&pmc8180_temp>, using the name pmc8180a-thermal creates a second thermal zone node in the DTB for the same 0-cell sensor rather than overriding the existing pmc8180-thermal node. When qpnp_tm_probe() registers pmc8180_temp via devm_thermal_of_zone_register(), thermal_of_zone_register() only binds the first matching zone (pmc8180-thermal) and leaves pmc8180a-thermal unused. [ ... ] > +&apps_rsc { > + pmc8180-a-rpmh-regulators { > + compatible = "qcom,pmc8180-rpmh-regulators"; > + qcom,pmic-id = "a"; [Severity: Low] This isn't a runtime bug, but several child node names in this file do not match the patternProperties required by their respective DT bindings (which set additionalProperties: false) and will cause dtbs_check validation failures: 1. Under &apps_rsc, pmc8180-a-rpmh-regulators, pmc8180-e-rpmh-regulators, and pmc8180c-rpmh-regulators do not match ^regulators(-[0-9])?$ in Documentation/devicetree/bindings/soc/qcom/qcom,rpmh-rsc.yaml. 2. Under &tlmm, the subnodes of uart13-state, uart15-state, and ssam-state (cts, rts-tx, rx, and wake-int) do not end with -pins as required by Documentation/devicetree/bindings/pinctrl/qcom,sc8180x-tlmm.yaml. 3. Under &pmc8180_1_gpios, pmc8180a_gpio1 and pmc8180a_gpio6 do not end with -state as required by Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml. 4. Under pmc8180e_adc and &pmc8180_adc, the channel child nodes (ref-gnd@0, vref-1p25@1, die-temp@6, xo-therm@4c, vph-pwr@83, and vcoin@85) do not match ^channel@[0-9a-f]+$ as required by Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.yaml. Could these node names be updated to match the binding schemas? [ ... ] > +&smb2351_2 { > + status = "disabled"; > +}; > + > +&smb2351_a { > + status = "disabled"; > +}; [Severity: Medium] Does this compile cleanly with dtc? In arch/arm64/boot/dts/qcom/sc8180x-pmics.dtsi, the two qcom,smb2351 PMIC nodes under &spmi_bus are defined without labels: pmic@2 { compatible = "qcom,smb2351", "qcom,spmi-pmic"; reg = <0x2 SPMI_USID>; ... }; ... pmic@a { compatible = "qcom,smb2351", "qcom,spmi-pmic"; reg = <0xa SPMI_USID>; ... }; Because neither smb2351_2 nor smb2351_a is defined anywhere in the tree, building the new Surface Pro X DTB targets under CONFIG_ARCH_QCOM fails with unresolved label errors. [ ... ] > +&mdss_edp { > + pinctrl-0 = <&edp_hpd_active>; > + pinctrl-names = "default"; > + > + status = "okay"; > + > + aux-bus { > + panel { > + compatible = "edp-panel"; > + enable-gpios = <&tlmm 130 GPIO_ACTIVE_HIGH>; > + no-hpd; > + > + pinctrl-0 = <&panel_vdd_en_default_state>; > + pinctrl-names = "default"; [Severity: Medium] Should GPIO 130 be modeled as a fixed regulator connected to power-supply on the panel node rather than enable-gpios? Documentation/devicetree/bindings/display/panel/panel-edp.yaml requires power-supply on compatible = "edp-panel" nodes. In addition, GPIO 130 is the panel VDD regulator enable pin (panel-vdd-en-default-state). In drivers/gpu/drm/panel/panel-edp.c, panel_edp_probe() requests enable-gpios with GPIOD_OUT_LOW, which drives GPIO 130 low and cuts panel power, and generic_edp_panel_probe() -> panel_edp_prepare_once() then re-asserts enable_gpio and immediately attempts DP AUX EDID reads with zero delay because no-hpd is set without hpd-absent-delay-ms. [ ... ] > +&usb_prim_qmpphy { > + vdda-phy-supply = <&vreg_l3c_1p2>; > + vdda-pll-supply = <&vreg_l9e_0p88>; > + > + orientation-switch; > + > + status = "okay"; > +}; [ ... ] > +&usb_sec_qmpphy { > + vdda-phy-supply = <&vreg_l3c_1p2>; > + vdda-pll-supply = <&vreg_l9e_0p88>; > + > + orientation-switch; > + > + status = "okay"; > +}; [ ... ] > +&usb_mp_qmpphy0 { > + vdda-phy-supply = <&vreg_l3c_1p2>; > + vdda-pll-supply = <&vreg_l9e_0p88>; > + > + status = "okay"; > +}; > + > +&usb_mp_qmpphy1 { > + vdda-phy-supply = <&vreg_l3c_1p2>; > + vdda-pll-supply = <&vreg_l9e_0p88>; > + > + status = "okay"; > +}; [Severity: Medium] Are vdda-phy-supply and vdda-pll-supply swapped on usb_prim_qmpphy, usb_sec_qmpphy, usb_mp_qmpphy0, and usb_mp_qmpphy1? On SC8180X QMP PHYs (including pcie1_phy and pcie2_phy below, as well as sc8180x-primus.dts and sc8180x-lenovo-flex-5g.dts), vdda-phy-supply is the 0.88V rail and vdda-pll-supply is the 1.2V rail (&vreg_l3c_1p2). In drivers/phy/qualcomm/phy-qcom-qmp-combo.c and drivers/phy/qualcomm/phy-qcom-qmp-usb.c, qmp_phy_vreg_l sets a 21800 uA load on vdda-phy and a 36000 uA load on vdda-pll, so swapping them applies the wrong current load votes to the two LDOs. [ ... ] > +&remoteproc_slpi { > + memory-region = <&slpi_mem>; > +}; [Severity: Medium] Where is the remoteproc_slpi label defined? Both sc8180x-microsoft-surface-pro-x.dtsi and the three board DTS files (sc8180x-microsoft-cambria.dts, sc8180x-microsoft-carina.dts, and sc8180x-microsoft-caspar.dts) reference &remoteproc_slpi, but arch/arm64/boot/dts/qcom/sc8180x.dtsi only defines remoteproc_mpss, remoteproc_cdsp, and remoteproc_adsp. Because remoteproc_slpi does not exist in sc8180x.dtsi, dtc fails to build all three DTB targets. > + > +&uart13 { > + pinctrl-0 = <&uart13_state>; > + pinctrl-names = "default"; > + > + status = "okay"; > + > + bluetooth { > + compatible = "qcom,wcn3998-bt"; > + > + vddio-supply = <&vreg_s4a_1p8>; > + vddxo-supply = <&vreg_l7a_1p8>; > + vddrf-supply = <&vreg_l9a_1p3>; > + vddch0-supply = <&vreg_l11c_3p3>; > + > + max-speed = <3200000>; > + }; > +}; > + > +&uart15 { > + pinctrl-0 = <&uart15_state>; > + pinctrl-names = "default"; > + > + status = "okay"; > + > + embedded-controller { > + compatible = "microsoft,surface-sam"; > + > + interrupts-extended = <&tlmm 180 IRQ_TYPE_EDGE_RISING>; > + > + current-speed = <4000000>; > + > + pinctrl-0 = <&ssam_state>; > + pinctrl-names = "default"; > + }; > +}; [Severity: High] Don't we also need to enable &qupv3_id_2 for uart13 and uart15 to probe? In arch/arm64/boot/dts/qcom/sc8180x.dtsi, uart13 and uart15 are children of qupv3_id_2 (geniqup@cc0000), which defaults to status = "disabled": qupv3_id_2: geniqup@cc0000 { compatible = "qcom,geni-se-qup"; ... status = "disabled"; Child serial engines under qcom,geni-se-qup are populated when geni_se_probe() calls devm_of_platform_populate(). Without setting status = "okay" on &qupv3_id_2, the parent QUPv3 wrapper never probes and neither uart13 (Bluetooth) nor uart15 (the Surface SAM embedded controller) is instantiated. -- Sashiko AI review · https://sashiko.dev/#/patchset/20261104070441.74127-1-val@packett.cool?part=2 ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/5] arm64: dts: qcom: sc8180x: Add Microsoft Surface Pro X 2026-11-04 7:04 ` [PATCH 2/5] arm64: dts: qcom: sc8180x: Add " Val Packett 2026-11-04 7:22 ` sashiko-bot @ 2026-11-04 8:36 ` Konrad Dybcio 2026-11-04 9:05 ` Val Packett 2026-11-15 3:16 ` Haipeng Lin 2 siblings, 1 reply; 8+ messages in thread From: Konrad Dybcio @ 2026-11-04 8:36 UTC (permalink / raw) To: Val Packett, Bjorn Andersson, Konrad Dybcio, Abel Vesa, Rob Herring, Krzysztof Kozlowski, Conor Dooley Cc: Maximilian Luz, Hans de Goede, Ilpo Järvinen, Alexandre Belloni, linux-arm-msm, devicetree, linux-kernel, linux-rtc On 11/4/26 8:04 AM, Val Packett wrote: > From: Maximilian Luz <luzmaximilian@gmail.com> > > Introduce a device tree for the Surface Pro X tablet in all 3 variants > (SQ1 with cellular, SQ1 Wi-Fi only, SQ2 with cellular). > > Currently working: > > * Display, backlight (eDP panel) > * USB 2.0 > * Wi-Fi and Bluetooth (WCN3998) > * NVMe on PCIe2 > * Embedded controller (Surface SAM over UART) > * All remoteprocs (ADSP, CDSP, MPSS, SLPI) > * Volume and power buttons [...] This needs some sorting etc., but let's tackle the bigger prob first > +&mdss_edp { > + pinctrl-0 = <&edp_hpd_active>; > + pinctrl-names = "default"; > + > + status = "okay"; > + > + aux-bus { > + panel { > + compatible = "edp-panel"; > + enable-gpios = <&tlmm 130 GPIO_ACTIVE_HIGH>; > + no-hpd; Is there really no HPD? The pinctrl above suggests otherwise [...] > +&pcie2 { > + // XXX: pcie1 and pcie2 are multi'd together, for now use just one > + num-lanes = <2>; We should be using the new phy-qcom-qmp-pcie-multiphy.c driver I think, I'll try chasing down the right magic values > + > + pinctrl-0 = <&pcie1_default_state>; > + pinctrl-names = "default"; > + > + // HACK: Remove "global" interrupt Why? Konrad ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/5] arm64: dts: qcom: sc8180x: Add Microsoft Surface Pro X 2026-11-04 8:36 ` Konrad Dybcio @ 2026-11-04 9:05 ` Val Packett 0 siblings, 0 replies; 8+ messages in thread From: Val Packett @ 2026-11-04 9:05 UTC (permalink / raw) To: Konrad Dybcio, Bjorn Andersson, Konrad Dybcio, Abel Vesa, Rob Herring, Krzysztof Kozlowski, Conor Dooley Cc: Maximilian Luz, Hans de Goede, Ilpo Järvinen, Alexandre Belloni, linux-arm-msm, devicetree, linux-kernel, linux-rtc On 11/4/26 5:36 AM, Konrad Dybcio wrote: > On 11/4/26 8:04 AM, Val Packett wrote: >> From: Maximilian Luz <luzmaximilian@gmail.com> >> >> Introduce a device tree for the Surface Pro X tablet in all 3 variants >> (SQ1 with cellular, SQ1 Wi-Fi only, SQ2 with cellular). >> >> Currently working: >> >> * Display, backlight (eDP panel) >> * USB 2.0 >> * Wi-Fi and Bluetooth (WCN3998) >> * NVMe on PCIe2 >> * Embedded controller (Surface SAM over UART) >> * All remoteprocs (ADSP, CDSP, MPSS, SLPI) >> * Volume and power buttons > [...] > > This needs some sorting etc., but let's tackle the bigger prob first > > >> +&mdss_edp { >> + pinctrl-0 = <&edp_hpd_active>; >> + pinctrl-names = "default"; >> + >> + status = "okay"; >> + >> + aux-bus { >> + panel { >> + compatible = "edp-panel"; >> + enable-gpios = <&tlmm 130 GPIO_ACTIVE_HIGH>; >> + no-hpd; > Is there really no HPD? The pinctrl above suggests otherwise Looks like that's been pretty much copy-pasted from lenovo-flex-5g where it's also set with no explanation, with the same pinctrl also existing. I'm suspecting that might've been an attempt at working around the inconsistent display initialization, pre clk_rcg2_shared_ops etc.? I'll try removing it. (Also will convert gpio130 to a power supply like flex-5g has it) > [...] > >> +&pcie2 { >> + // XXX: pcie1 and pcie2 are multi'd together, for now use just one >> + num-lanes = <2>; > We should be using the new phy-qcom-qmp-pcie-multiphy.c driver I think, > I'll try chasing down the right magic values Thanks!! >> + >> + pinctrl-0 = <&pcie1_default_state>; >> + pinctrl-names = "default"; >> + >> + // HACK: Remove "global" interrupt > Why? Related to not having the proper multiphy driver support, "it seems like that interrupt is expected to signal when the device is ready for use after initial setup. Unfortunately that doesn't seem to work for the NVME, potentially due to the composite PHYs. Likely it's just waiting forever and the IRQ doesn't get triggered. As it's optional, we can just drop it for now." ~val ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/5] arm64: dts: qcom: sc8180x: Add Microsoft Surface Pro X 2026-11-04 7:04 ` [PATCH 2/5] arm64: dts: qcom: sc8180x: Add " Val Packett 2026-11-04 7:22 ` sashiko-bot 2026-11-04 8:36 ` Konrad Dybcio @ 2026-11-15 3:16 ` Haipeng Lin 2026-11-15 8:20 ` Val Packett 2 siblings, 1 reply; 8+ messages in thread From: Haipeng Lin @ 2026-11-15 3:16 UTC (permalink / raw) To: Val Packett, Bjorn Andersson, Konrad Dybcio, Abel Vesa, Rob Herring, Krzysztof Kozlowski, Conor Dooley Cc: Maximilian Luz, Hans de Goede, Ilpo Järvinen, Alexandre Belloni, linux-arm-msm, devicetree, linux-kernel, linux-rtc On 11/4/26 2:04 AM, Val Packett wrote: > From: Maximilian Luz <luzmaximilian@gmail.com> > > Introduce a device tree for the Surface Pro X tablet in all 3 variants > (SQ1 with cellular, SQ1 Wi-Fi only, SQ2 with cellular). [...] I believe there is also a Wi-Fi only SQ2 variant. Looking at the WoA drivers for 8180_CAS (Caspar, Wi-Fi only) https://github.com/WOA-Project/Qualcomm-Reference-Drivers/tree/master/Surface/8180_CAS/200.0.31.0 This variant is the only that has both SurfaceSMF_SQ1.cab and SurfaceSMF_SQ2.cab. Only 8180_CAS MPSS INF maps the no-modem subsystem ID (SUBSYS_MSNM8180 -> qcmpss8180_nm.mbn), the 8180_CAR (Carina) only lists the cellular MSWW/MSJP/MSCN IDs. My SQ2 Wi-Fi boots with the caspar dts in this patch fine but the gold cluster is pinned at SQ1's top clocks because the 3.072 / 3.1488 GHz OPPs are only in carina.dts. > diff --git a/arch/arm64/boot/dts/qcom/sc8180x-microsoft-carina.dts b/arch/arm64/boot/dts/qcom/sc8180x-microsoft-carina.dts > new file mode 100644 > index 000000000000..5d155c69907a > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/sc8180x-microsoft-carina.dts > @@ -0,0 +1,50 @@ > +// SPDX-License-Identifier: BSD-3-Clause > + > +/dts-v1/; > + > +#include "sc8180x-microsoft-surface-pro-x.dtsi" > + > +/ { > + model = "Microsoft Surface Pro X (SQ2)"; > + compatible = "microsoft,carina", "qcom,sc8180x"; > +}; > + > +&cpu4_opp_table { > + opp-3072000000 { > + opp-hz = /bits/ 64 <3072000000>; > + opp-peak-kBps = <8368000 51609600>; > + }; > + > + opp-3148800000 { > + opp-hz = /bits/ 64 <3148800000>; > + opp-peak-kBps = <8368000 51609600>; > + }; > +}; > + [...] Would it make sense to move opp-3072000000 and opp-3148800000 into the shared sc8180x-microsoft-surface-pro-x.dtsi? qcom-cpufreq-hw disables all DT OPPs first and only re-enables freqs present in the hardware LUT so this would work for SQ1 and caspar.dtb will cover both the SQ1 and SQ2 Wi-Fi models out of the box and carina.dts won't need its own &cpu4_opp_table override. > diff --git a/arch/arm64/boot/dts/qcom/sc8180x-microsoft-surface-pro-x.dtsi b/arch/arm64/boot/dts/qcom/sc8180x-microsoft-surface-pro-x.dtsi > new file mode 100644 > index 000000000000..17fb01c6b164 > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/sc8180x-microsoft-surface-pro-x.dtsi [...] > +&smb2351_2 { > + status = "disabled"; > +}; > + > +&smb2351_a { > + status = "disabled"; > +}; Confirmed on hardware that labeling pmic@2 and pmic@a in sc8180x-pmics.dtsi fixes the dtc build failure here. [...]> +&uart13 { > + pinctrl-0 = <&uart13_state>; > + pinctrl-names = "default"; > + > + status = "okay"; [...] On linux-surface, ad1bb617a15a from Maximilian Luz had &qupv3_id_2 { status = "okay"; }; Would it be helpful to add here? I confirmed on hardware that adding it allows uart13 (WCN3998 Bluetooth) and uart15 (SAM EC) to populate and probe properly. Thanks, Haipeng ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/5] arm64: dts: qcom: sc8180x: Add Microsoft Surface Pro X 2026-11-15 3:16 ` Haipeng Lin @ 2026-11-15 8:20 ` Val Packett 2026-11-15 16:28 ` Haipeng Lin 0 siblings, 1 reply; 8+ messages in thread From: Val Packett @ 2026-11-15 8:20 UTC (permalink / raw) To: Haipeng Lin, Bjorn Andersson, Konrad Dybcio, Abel Vesa, Rob Herring, Krzysztof Kozlowski, Conor Dooley Cc: Maximilian Luz, Hans de Goede, Ilpo Järvinen, Alexandre Belloni, linux-arm-msm, devicetree, linux-kernel, linux-rtc On 11/15/26 12:16 AM, Haipeng Lin wrote: > On 11/4/26 2:04 AM, Val Packett wrote: >> From: Maximilian Luz <luzmaximilian@gmail.com> >> >> Introduce a device tree for the Surface Pro X tablet in all 3 variants >> (SQ1 with cellular, SQ1 Wi-Fi only, SQ2 with cellular). > [...] > > I believe there is also a Wi-Fi only SQ2 variant. Looking at the WoA > drivers for 8180_CAS (Caspar, Wi-Fi only) > https://github.com/WOA-Project/Qualcomm-Reference-Drivers/tree/master/Surface/8180_CAS/200.0.31.0 Huuuh, okay.. > This variant is the only that has both SurfaceSMF_SQ1.cab and > SurfaceSMF_SQ2.cab. Only 8180_CAS MPSS INF maps the no-modem subsystem > ID (SUBSYS_MSNM8180 -> qcmpss8180_nm.mbn), the 8180_CAR (Carina) only > lists the cellular MSWW/MSJP/MSCN IDs. > > My SQ2 Wi-Fi boots with the caspar dts in this patch fine but the > gold cluster is pinned at SQ1's top clocks because the 3.072 / 3.1488 > GHz OPPs are only in carina.dts. > >> diff --git a/arch/arm64/boot/dts/qcom/sc8180x-microsoft-carina.dts b/arch/arm64/boot/dts/qcom/sc8180x-microsoft-carina.dts >> new file mode 100644 >> index 000000000000..5d155c69907a >> --- /dev/null >> +++ b/arch/arm64/boot/dts/qcom/sc8180x-microsoft-carina.dts >> @@ -0,0 +1,50 @@ >> +// SPDX-License-Identifier: BSD-3-Clause >> + >> +/dts-v1/; >> + >> +#include "sc8180x-microsoft-surface-pro-x.dtsi" >> + >> +/ { >> + model = "Microsoft Surface Pro X (SQ2)"; >> + compatible = "microsoft,carina", "qcom,sc8180x"; >> +}; >> + >> +&cpu4_opp_table { >> + opp-3072000000 { >> + opp-hz = /bits/ 64 <3072000000>; >> + opp-peak-kBps = <8368000 51609600>; >> + }; >> + >> + opp-3148800000 { >> + opp-hz = /bits/ 64 <3148800000>; >> + opp-peak-kBps = <8368000 51609600>; >> + }; >> +}; >> + > [...] > > Would it make sense to move opp-3072000000 and opp-3148800000 into the > shared sc8180x-microsoft-surface-pro-x.dtsi? qcom-cpufreq-hw disables > all DT OPPs first and only re-enables freqs present in the hardware LUT > so this would work for SQ1 and caspar.dtb will cover both the SQ1 and > SQ2 Wi-Fi models out of the box and carina.dts won't need its own > &cpu4_opp_table override. I'm pretty sure mine *did* complain very loudly about having these OPPs and might've even had broken scaling. I'll retest again, if it works I'll move it to the shared dtsi (or even the SoC's?) >> diff --git a/arch/arm64/boot/dts/qcom/sc8180x-microsoft-surface-pro-x.dtsi b/arch/arm64/boot/dts/qcom/sc8180x-microsoft-surface-pro-x.dtsi >> new file mode 100644 >> index 000000000000..17fb01c6b164 >> --- /dev/null >> +++ b/arch/arm64/boot/dts/qcom/sc8180x-microsoft-surface-pro-x.dtsi > [...] >> +&smb2351_2 { >> + status = "disabled"; >> +}; >> + >> +&smb2351_a { >> + status = "disabled"; >> +}; > Confirmed on hardware that labeling pmic@2 and pmic@a in > sc8180x-pmics.dtsi fixes the dtc build failure here. Yeahh, forgot to include, will be in v2 > [...]> +&uart13 { >> + pinctrl-0 = <&uart13_state>; >> + pinctrl-names = "default"; >> + >> + status = "okay"; > [...] > > On linux-surface, ad1bb617a15a from Maximilian Luz had > > &qupv3_id_2 { > status = "okay"; > }; > > Would it be helpful to add here? I confirmed on hardware that adding it > allows uart13 (WCN3998 Bluetooth) and uart15 (SAM EC) to populate and > probe properly. Of course; it should've been the _2 in the first place but I made a mistake during last-minute cleanup and left out the wrong ones… > Thanks, > Haipeng BTW, please send me the output of `sudo fwupdtool hwids`, these are needed to add support to dtbloader/systemd-stub/stubble DT auto-selection. (If anyone with the cellular variants reads this: you too :)) Thanks, ~val ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/5] arm64: dts: qcom: sc8180x: Add Microsoft Surface Pro X 2026-11-15 8:20 ` Val Packett @ 2026-11-15 16:28 ` Haipeng Lin 0 siblings, 0 replies; 8+ messages in thread From: Haipeng Lin @ 2026-11-15 16:28 UTC (permalink / raw) To: Val Packett, Bjorn Andersson, Konrad Dybcio, Abel Vesa, Rob Herring, Krzysztof Kozlowski, Conor Dooley Cc: Maximilian Luz, Hans de Goede, Ilpo Järvinen, Alexandre Belloni, linux-arm-msm, devicetree, linux-kernel, linux-rtc On 11/15/26 3:20 AM, Val Packett wrote: [...]>> Would it make sense to move opp-3072000000 and opp-3148800000 into the >> shared sc8180x-microsoft-surface-pro-x.dtsi? qcom-cpufreq-hw disables >> all DT OPPs first and only re-enables freqs present in the hardware LUT >> so this would work for SQ1 and caspar.dtb will cover both the SQ1 and >> SQ2 Wi-Fi models out of the box and carina.dts won't need its own >> &cpu4_opp_table override. > > I'm pretty sure mine *did* complain very loudly about having these OPPs and might've even had broken scaling. > > I'll retest again, if it works I'll move it to the shared dtsi (or even the SoC's?) I like the idea of moving it to the SoC. Did a test on my SQ2 Wi-Fi with opp-3072000000/opp-3148800000 moved into sc8180x.dtsi, dropping it from carina.dts, plus a dummy opp-32256000000 above my LUT's top entry so I can "simulate" the SQ1 situation where there's a DT OPP that the LUT does not have. Booting that with caspar.dtb: - no cpufreq/OPP messages at all (e.g., "Voltage update failed" or "failed to update OPP" as observed for caspar.dts in this v1 on SQ2) - policy4 scaling_available_frequencies tops out at 3148800, the dummy 3225600 is disabled silently (by qcom_cpufreq_hw_read_lut() ?) - under load time_in_state shows gold cluster sits at 3148800 Hopefully, this solution should work for both SQ1 and SQ2. sc8180x.dtsi looks like it tops out at 2995200, and that is SQ1's bin above the "regular" 8cx Gen 1's 2.84 GHz on the gold cluster so if it was broken it would already be broken for the 8cx G1 due to the SQ1 entries... [...]> > BTW, please send me the output of `sudo fwupdtool hwids`, these are needed to add support to dtbloader/systemd-stub/stubble DT auto-selection. > > (If anyone with the cellular variants reads this: you too :)) > > > Thanks, > > ~val This is not the latest BIOS which is 11.504.140 according to https://support.microsoft.com/en-us/surface/updates/surface-pro-x-update-history but I don't have dual boot to update it... Surface Pro X SQ2 Wi-Fi only: Computer Information -------------------- BiosVendor: Microsoft Corporation BiosVersion: 11.311.140 BiosMajorRelease: 255 BiosMinorRelease: 255 BiosReleaseDate: 2/03/2026 FirmwareMajorRelease: ff FirmwareMinorRelease: ff Manufacturer: Microsoft Corporation Family: Surface ProductName: Surface Pro X ProductSku: Surface_Pro_X_2010 EnclosureKind: 9 BaseboardManufacturer: Microsoft Corporation BaseboardProduct: Surface Pro X Hardware IDs ------------ {bf87a823-6823-50f1-9f18-2030fd86b087} <- Manufacturer + Family + ProductName + ProductSku + BiosVendor + BiosVersion + BiosMajorRelease + BiosMinorRelease {43cb3df2-05e6-5637-a89c-718381284f3d} <- Manufacturer + Family + ProductName + BiosVendor + BiosVersion + BiosMajorRelease + BiosMinorRelease {1d2505b3-3329-5a15-b934-e1990787e978} <- Manufacturer + ProductName + BiosVendor + BiosVersion + BiosMajorRelease + BiosMinorRelease {75b4817e-50ec-5e63-a904-1175cd1abff6} <- Manufacturer + Family + ProductName + ProductSku + BaseboardManufacturer + BaseboardProduct {cdf510a8-d41c-54bf-b2c5-61ba10957019} <- Manufacturer + Family + ProductName + ProductSku {cc2bc434-a08a-59c0-85ac-2576ed611de6} <- Manufacturer + Family + ProductName {69c2fd0d-8593-575f-b6af-5f70f0299ea4} <- Manufacturer + ProductSku + BaseboardManufacturer + BaseboardProduct {aa2c30e9-117c-5aeb-a8aa-4b01761cf493} <- Manufacturer + ProductSku {b07028e2-19c1-577d-a3c9-2eabef35c2a1} <- Manufacturer + ProductName + BaseboardManufacturer + BaseboardProduct {5d018db8-6de6-55f8-8d8b-4b773caf8450} <- Manufacturer + ProductName {db7e6e61-56bf-531d-b594-e4b1660d04aa} <- Manufacturer + Family + BaseboardManufacturer + BaseboardProduct {ca2e5189-1d32-509f-88a0-d4ebcc721899} <- Manufacturer + Family {aca387a9-183e-5da9-8f9d-f460c3f50f54} <- Manufacturer + EnclosureKind {f199ec04-d0d9-542b-b035-209532a4d1f6} <- Manufacturer + BaseboardManufacturer + BaseboardProduct {cc0aea32-ad2c-5013-8bed-cede6be8c9f4} <- Manufacturer Thanks, Haipeng ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2026-11-17 23:07 UTC | newest] Thread overview: 8+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2026-11-17 23:07 [PATCH 2/5] arm64: dts: qcom: sc8180x: Add Microsoft Surface Pro X kernel test robot -- strict thread matches above, loose matches on Subject: below -- 2026-11-04 7:04 [PATCH 0/5] Add support for the " Val Packett 2026-11-04 7:04 ` [PATCH 2/5] arm64: dts: qcom: sc8180x: Add " Val Packett 2026-11-04 7:22 ` sashiko-bot 2026-11-04 8:36 ` Konrad Dybcio 2026-11-04 9:05 ` Val Packett 2026-11-15 3:16 ` Haipeng Lin 2026-11-15 8:20 ` Val Packett 2026-11-15 16:28 ` Haipeng Lin
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.