All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/3] drm/xe/pcode: Add MEMORY_CONFIG mailbox definitions
@ 2026-11-18  6:22 Nareshkumar Gollakoti
  2026-11-18  6:45 ` Nilawar, Badal
  0 siblings, 1 reply; 6+ messages in thread
From: Nareshkumar Gollakoti @ 2026-11-18  6:22 UTC (permalink / raw)
  To: intel-xe
  Cc: badal.nilawar, sk.anirban, Himal Prasad Ghimiray,
	Nareshkumar Gollakoti

From: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>

Add the PCODE MEMORY_CONFIG command and its READ_MAX_BANDWIDTH and
READ_MAX_FREQUENCY sub-commands. They report the maximum achievable
memory bandwidth in Mbps and the maximum achievable memory frequency
in MHz.

Signed-off-by: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>
Signed-off-by: Nareshkumar Gollakoti <naresh.kumar.g@intel.com>
---
 drivers/gpu/drm/xe/xe_pcode_api.h | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/gpu/drm/xe/xe_pcode_api.h b/drivers/gpu/drm/xe/xe_pcode_api.h
index 00c4fc7d0124..f05846931059 100644
--- a/drivers/gpu/drm/xe/xe_pcode_api.h
+++ b/drivers/gpu/drm/xe/xe_pcode_api.h
@@ -81,6 +81,10 @@
 /* Domain IDs (param2) */
 #define     PCODE_MBOX_DOMAIN_HBM		0x2
 
+#define   PCODE_MEMORY_CONFIG		0x70
+#define     MEMORY_CONFIG_SUBCOMMAND_READ_MAX_BANDWIDTH 0x0
+#define     MEMORY_CONFIG_SUBCOMMAND_READ_MAX_FREQUENCY 0x1
+
 #define   FAN_SPEED_CONTROL			0x7D
 #define     FSC_READ_NUM_FANS			0x4
 
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/3] drm/xe/pcode: Add MEMORY_CONFIG mailbox definitions
  2026-11-18  6:22 Nareshkumar Gollakoti
@ 2026-11-18  6:45 ` Nilawar, Badal
  0 siblings, 0 replies; 6+ messages in thread
From: Nilawar, Badal @ 2026-11-18  6:45 UTC (permalink / raw)
  To: Nareshkumar Gollakoti, intel-xe; +Cc: sk.anirban, Himal Prasad Ghimiray


On 18-11-2026 11:52, Nareshkumar Gollakoti wrote:
> From: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>
>
> Add the PCODE MEMORY_CONFIG command and its READ_MAX_BANDWIDTH and
> READ_MAX_FREQUENCY sub-commands. They report the maximum achievable
> memory bandwidth in Mbps and the maximum achievable memory frequency
> in MHz.
>
> Signed-off-by: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>
> Signed-off-by: Nareshkumar Gollakoti <naresh.kumar.g@intel.com>
> ---
>   drivers/gpu/drm/xe/xe_pcode_api.h | 4 ++++
>   1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/xe/xe_pcode_api.h b/drivers/gpu/drm/xe/xe_pcode_api.h
> index 00c4fc7d0124..f05846931059 100644
> --- a/drivers/gpu/drm/xe/xe_pcode_api.h
> +++ b/drivers/gpu/drm/xe/xe_pcode_api.h
> @@ -81,6 +81,10 @@
>   /* Domain IDs (param2) */
>   #define     PCODE_MBOX_DOMAIN_HBM		0x2
>   
> +#define   PCODE_MEMORY_CONFIG		0x70
> +#define     MEMORY_CONFIG_SUBCOMMAND_READ_MAX_BANDWIDTH 0x0
> +#define     MEMORY_CONFIG_SUBCOMMAND_READ_MAX_FREQUENCY 0x1
> +

The PCode mailbox ordering seems inconsistent: 7E, 7D, 25, 5C, 6E, 70, 
7E. Clean up can be done in separate patch.

Reviewed-by: Badal Nilawar <badal.nilawar@intel.com>

Thanks,
Badal

>   #define   FAN_SPEED_CONTROL			0x7D
>   #define     FSC_READ_NUM_FANS			0x4
>   

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH 0/3] drm/xe: Expose CRI memory capability limits via sysfs
@ 2026-11-18  7:23 Nareshkumar Gollakoti
  2026-11-18  7:23 ` [PATCH 1/3] drm/xe/pcode: Add MEMORY_CONFIG mailbox definitions Nareshkumar Gollakoti
  2026-11-18  7:23 ` [PATCH 2/3] drm/xe: Rename xe_vram_freq to xe_vram_config Nareshkumar Gollakoti
  0 siblings, 2 replies; 6+ messages in thread
From: Nareshkumar Gollakoti @ 2026-11-18  7:23 UTC (permalink / raw)
  To: intel-xe; +Cc: badal.nilawar, sk.anirban, Nareshkumar Gollakoti

This series adds read-only sysfs attributes for CRI devices to expose the
maximum supported memory frequency and memory bandwidth.

These attributes allow userspace to discover platform memory capability
limits. They are needed by compute runtime software, including NEO [1], for
capability discovery on CRI.

The existing tile memory sysfs support currently focuses on frequency-
related handling. Since it is now being extended to cover broader memory
configuration information, rename the component/files from "freq" to
"config" to better reflect their scope.

The new attributes provide a stable userspace interface for discovering
platform memory capability limits.

The series consists of:
  1. Add PCODE MEMORY_CONFIG mailbox definitions and subcommands
  2. Rename xe_vram_freq to xe_vram_config
  3. Expose maximum memory frequency and bandwidth through sysfs for CRI

Reference:[1]
https://github.com/intel-innersource/drivers.gpu.compute.runtime/pull/57544

Himal Prasad Ghimiray (3):
  drm/xe/pcode: Add MEMORY_CONFIG mailbox definitions
  drm/xe: Rename xe_vram_freq to xe_vram_config
  drm/xe: Expose CRI maximum memory frequency and bandwidth in sysfs

 .../ABI/testing/sysfs-driver-intel-xe-gpu     | 24 +++++
 drivers/gpu/drm/xe/Makefile                   |  2 +-
 drivers/gpu/drm/xe/xe_pcode_api.h             |  4 +
 drivers/gpu/drm/xe/xe_tile_sysfs.c            |  4 +-
 .../xe/{xe_vram_freq.c => xe_vram_config.c}   | 93 +++++++++++++++++--
 drivers/gpu/drm/xe/xe_vram_config.h           | 13 +++
 drivers/gpu/drm/xe/xe_vram_freq.h             | 13 ---
 7 files changed, 129 insertions(+), 24 deletions(-)
 rename drivers/gpu/drm/xe/{xe_vram_freq.c => xe_vram_config.c} (53%)
 create mode 100644 drivers/gpu/drm/xe/xe_vram_config.h
 delete mode 100644 drivers/gpu/drm/xe/xe_vram_freq.h

-- 
2.43.0


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH 1/3] drm/xe/pcode: Add MEMORY_CONFIG mailbox definitions
  2026-11-18  7:23 [PATCH 0/3] drm/xe: Expose CRI memory capability limits via sysfs Nareshkumar Gollakoti
@ 2026-11-18  7:23 ` Nareshkumar Gollakoti
  2026-11-18  7:23 ` [PATCH 2/3] drm/xe: Rename xe_vram_freq to xe_vram_config Nareshkumar Gollakoti
  1 sibling, 0 replies; 6+ messages in thread
From: Nareshkumar Gollakoti @ 2026-11-18  7:23 UTC (permalink / raw)
  To: intel-xe
  Cc: badal.nilawar, sk.anirban, Himal Prasad Ghimiray,
	Nareshkumar Gollakoti

From: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>

Add the PCODE MEMORY_CONFIG command and its READ_MAX_BANDWIDTH and
READ_MAX_FREQUENCY sub-commands. They report the maximum achievable
memory bandwidth in Mbps and the maximum achievable memory frequency
in MHz.

Signed-off-by: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>
Signed-off-by: Nareshkumar Gollakoti <naresh.kumar.g@intel.com>
---
 drivers/gpu/drm/xe/xe_pcode_api.h | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/gpu/drm/xe/xe_pcode_api.h b/drivers/gpu/drm/xe/xe_pcode_api.h
index 00c4fc7d01244..f058469310593 100644
--- a/drivers/gpu/drm/xe/xe_pcode_api.h
+++ b/drivers/gpu/drm/xe/xe_pcode_api.h
@@ -81,6 +81,10 @@
 /* Domain IDs (param2) */
 #define     PCODE_MBOX_DOMAIN_HBM		0x2
 
+#define   PCODE_MEMORY_CONFIG		0x70
+#define     MEMORY_CONFIG_SUBCOMMAND_READ_MAX_BANDWIDTH 0x0
+#define     MEMORY_CONFIG_SUBCOMMAND_READ_MAX_FREQUENCY 0x1
+
 #define   FAN_SPEED_CONTROL			0x7D
 #define     FSC_READ_NUM_FANS			0x4
 
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 2/3] drm/xe: Rename xe_vram_freq to xe_vram_config
  2026-11-18  7:23 [PATCH 0/3] drm/xe: Expose CRI memory capability limits via sysfs Nareshkumar Gollakoti
  2026-11-18  7:23 ` [PATCH 1/3] drm/xe/pcode: Add MEMORY_CONFIG mailbox definitions Nareshkumar Gollakoti
@ 2026-11-18  7:23 ` Nareshkumar Gollakoti
  1 sibling, 0 replies; 6+ messages in thread
From: Nareshkumar Gollakoti @ 2026-11-18  7:23 UTC (permalink / raw)
  To: intel-xe
  Cc: badal.nilawar, sk.anirban, Himal Prasad Ghimiray,
	Nareshkumar Gollakoti

From: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>

The tile memory sysfs component is about to expose memory configuration
beyond frequency, such as maximum bandwidth. Rename xe_vram_freq.c
and xe_vram_freq.h to xe_vram_config.c xe_vram_config.h.
xe_vram_freq_sysfs_init() to xe_vram_config_sysfs_init() to reflect that.

No functional change.

Signed-off-by: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>
Signed-off-by: Nareshkumar Gollakoti <naresh.kumar.g@intel.com>
---
 drivers/gpu/drm/xe/Makefile                         |  2 +-
 drivers/gpu/drm/xe/xe_tile_sysfs.c                  |  4 ++--
 .../gpu/drm/xe/{xe_vram_freq.c => xe_vram_config.c} |  8 ++++----
 drivers/gpu/drm/xe/xe_vram_config.h                 | 13 +++++++++++++
 drivers/gpu/drm/xe/xe_vram_freq.h                   | 13 -------------
 5 files changed, 20 insertions(+), 20 deletions(-)
 rename drivers/gpu/drm/xe/{xe_vram_freq.c => xe_vram_config.c} (94%)
 create mode 100644 drivers/gpu/drm/xe/xe_vram_config.h
 delete mode 100644 drivers/gpu/drm/xe/xe_vram_freq.h

diff --git a/drivers/gpu/drm/xe/Makefile b/drivers/gpu/drm/xe/Makefile
index 4377f60f5dabe..b0ce47fbac9d5 100644
--- a/drivers/gpu/drm/xe/Makefile
+++ b/drivers/gpu/drm/xe/Makefile
@@ -150,7 +150,7 @@ xe-y += xe_bb.o \
 	xe_vm.o \
 	xe_vm_madvise.o \
 	xe_vram.o \
-	xe_vram_freq.o \
+	xe_vram_config.o \
 	xe_vsec.o \
 	xe_wa.o \
 	xe_wait_user_fence.o \
diff --git a/drivers/gpu/drm/xe/xe_tile_sysfs.c b/drivers/gpu/drm/xe/xe_tile_sysfs.c
index 510aa0ac44287..c944579a17c85 100644
--- a/drivers/gpu/drm/xe/xe_tile_sysfs.c
+++ b/drivers/gpu/drm/xe/xe_tile_sysfs.c
@@ -10,7 +10,7 @@
 #include "xe_device_types.h"
 #include "xe_pm.h"
 #include "xe_tile_sysfs.h"
-#include "xe_vram_freq.h"
+#include "xe_vram_config.h"
 
 static void xe_tile_sysfs_kobj_release(struct kobject *kobj)
 {
@@ -49,7 +49,7 @@ int xe_tile_sysfs_init(struct xe_tile *tile)
 
 	tile->sysfs = &kt->base;
 
-	err = xe_vram_freq_sysfs_init(tile);
+	err = xe_vram_config_sysfs_init(tile);
 	if (err)
 		goto err_object;
 
diff --git a/drivers/gpu/drm/xe/xe_vram_freq.c b/drivers/gpu/drm/xe/xe_vram_config.c
similarity index 94%
rename from drivers/gpu/drm/xe/xe_vram_freq.c
rename to drivers/gpu/drm/xe/xe_vram_config.c
index 8717367ccd4c7..31a3405c39abd 100644
--- a/drivers/gpu/drm/xe/xe_vram_freq.c
+++ b/drivers/gpu/drm/xe/xe_vram_config.c
@@ -9,10 +9,10 @@
 #include "xe_pcode.h"
 #include "xe_pcode_api.h"
 #include "xe_tile_sysfs.h"
-#include "xe_vram_freq.h"
+#include "xe_vram_config.h"
 
 /**
- * DOC: Xe VRAM freq
+ * DOC: Xe VRAM config
  *
  * Provides sysfs entries for vram frequency in tile
  *
@@ -93,14 +93,14 @@ static void vram_freq_sysfs_fini(void *arg)
 }
 
 /**
- * xe_vram_freq_sysfs_init - Initialize vram frequency sysfs component
+ * xe_vram_config_sysfs_init - Initialize vram configuration sysfs component
  * @tile: Xe Tile object
  *
  * It needs to be initialized after the main tile component is ready
  *
  * Returns: 0 on success, negative error code on error.
  */
-int xe_vram_freq_sysfs_init(struct xe_tile *tile)
+int xe_vram_config_sysfs_init(struct xe_tile *tile)
 {
 	struct xe_device *xe = tile_to_xe(tile);
 	struct kobject *kobj;
diff --git a/drivers/gpu/drm/xe/xe_vram_config.h b/drivers/gpu/drm/xe/xe_vram_config.h
new file mode 100644
index 0000000000000..98903911f6583
--- /dev/null
+++ b/drivers/gpu/drm/xe/xe_vram_config.h
@@ -0,0 +1,13 @@
+/* SPDX-License-Identifier: MIT */
+/*
+ * Copyright © 2023 Intel Corporation
+ */
+
+#ifndef _XE_VRAM_CONFIG_H_
+#define _XE_VRAM_CONFIG_H_
+
+struct xe_tile;
+
+int xe_vram_config_sysfs_init(struct xe_tile *tile);
+
+#endif /* _XE_VRAM_CONFIG_H_ */
diff --git a/drivers/gpu/drm/xe/xe_vram_freq.h b/drivers/gpu/drm/xe/xe_vram_freq.h
deleted file mode 100644
index bf726bc5881f2..0000000000000
--- a/drivers/gpu/drm/xe/xe_vram_freq.h
+++ /dev/null
@@ -1,13 +0,0 @@
-/* SPDX-License-Identifier: MIT */
-/*
- * Copyright © 2023 Intel Corporation
- */
-
-#ifndef _XE_VRAM_FREQ_H_
-#define _XE_VRAM_FREQ_H_
-
-struct xe_tile;
-
-int xe_vram_freq_sysfs_init(struct xe_tile *tile);
-
-#endif /* _XE_VRAM_FREQ_H_ */
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 1/3] drm/xe/pcode: Add MEMORY_CONFIG mailbox definitions
  2026-11-18  7:25 [PATCH 0/3] drm/xe: Expose CRI memory capability limits via sysfs Nareshkumar Gollakoti
@ 2026-11-18  7:25 ` Nareshkumar Gollakoti
  0 siblings, 0 replies; 6+ messages in thread
From: Nareshkumar Gollakoti @ 2026-11-18  7:25 UTC (permalink / raw)
  To: intel-xe
  Cc: badal.nilawar, sk.anirban, Himal Prasad Ghimiray,
	Nareshkumar Gollakoti

From: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>

Add the PCODE MEMORY_CONFIG command and its READ_MAX_BANDWIDTH and
READ_MAX_FREQUENCY sub-commands. They report the maximum achievable
memory bandwidth in Mbps and the maximum achievable memory frequency
in MHz.

Signed-off-by: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>
Signed-off-by: Nareshkumar Gollakoti <naresh.kumar.g@intel.com>
---
 drivers/gpu/drm/xe/xe_pcode_api.h | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/gpu/drm/xe/xe_pcode_api.h b/drivers/gpu/drm/xe/xe_pcode_api.h
index 00c4fc7d01244..f058469310593 100644
--- a/drivers/gpu/drm/xe/xe_pcode_api.h
+++ b/drivers/gpu/drm/xe/xe_pcode_api.h
@@ -81,6 +81,10 @@
 /* Domain IDs (param2) */
 #define     PCODE_MBOX_DOMAIN_HBM		0x2
 
+#define   PCODE_MEMORY_CONFIG		0x70
+#define     MEMORY_CONFIG_SUBCOMMAND_READ_MAX_BANDWIDTH 0x0
+#define     MEMORY_CONFIG_SUBCOMMAND_READ_MAX_FREQUENCY 0x1
+
 #define   FAN_SPEED_CONTROL			0x7D
 #define     FSC_READ_NUM_FANS			0x4
 
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2026-11-18  7:28 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-18  7:23 [PATCH 0/3] drm/xe: Expose CRI memory capability limits via sysfs Nareshkumar Gollakoti
2026-11-18  7:23 ` [PATCH 1/3] drm/xe/pcode: Add MEMORY_CONFIG mailbox definitions Nareshkumar Gollakoti
2026-11-18  7:23 ` [PATCH 2/3] drm/xe: Rename xe_vram_freq to xe_vram_config Nareshkumar Gollakoti
  -- strict thread matches above, loose matches on Subject: below --
2026-11-18  7:25 [PATCH 0/3] drm/xe: Expose CRI memory capability limits via sysfs Nareshkumar Gollakoti
2026-11-18  7:25 ` [PATCH 1/3] drm/xe/pcode: Add MEMORY_CONFIG mailbox definitions Nareshkumar Gollakoti
2026-11-18  6:22 Nareshkumar Gollakoti
2026-11-18  6:45 ` Nilawar, Badal

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.