* [PATCH 1/4] spdx30: Take name, version and PURL of downloads from the fetcher
2026-11-18 9:29 [PATCH 0/4] spdx30: identity and purls of dependency downloads Stefano Tondo
@ 2026-11-18 9:29 ` Stefano Tondo
2026-11-18 9:29 ` [PATCH 2/4] spdx30: Record the lifecycle scope of crate dependencies Stefano Tondo
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Stefano Tondo @ 2026-11-18 9:29 UTC (permalink / raw)
To: openembedded-core
Cc: Joshua Watt, Alexander Kanavin, Stefan Herbrechtsmeier,
Stefano Tondo, Stefano Tondo
From: Stefano Tondo <stefano.tondo.ext@siemens.com>
The fetchers of package registries (crate, gomod, npm) know the name
and the version of each package they download. Today the SPDX of such
a download only has the file name, so an SBOM scanner cannot match
the dependency.
Ask the fetcher with package_identity() and set the name, the version
and the PURL of the download. This needs package_identity() in
bitbake.
Signed-off-by: Stefano Tondo <stefano.tondo.ext@siemens.com>
---
meta/lib/oe/spdx30_tasks.py | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/meta/lib/oe/spdx30_tasks.py b/meta/lib/oe/spdx30_tasks.py
index 6eaa74ce3d..58fe45ec7e 100644
--- a/meta/lib/oe/spdx30_tasks.py
+++ b/meta/lib/oe/spdx30_tasks.py
@@ -463,6 +463,19 @@ def enrich_source_package(d, dl, fd, file_name, primary_purpose):
)
+def set_package_identity(d, dl, fd):
+ """Set name, version and PURL of a download that names a package.
+
+ Fetchers of package registries (crate, gomod, npm) know which package
+ a URL downloads, see FetchMethod.package_identity() in bitbake.
+ """
+ identity = fd.method.package_identity(fd, d)
+ if identity:
+ dl.name = identity["name"]
+ dl.software_packageVersion = identity["version"]
+ dl.software_packageUrl = identity["purl"]
+
+
def add_download_files(d, objset):
inputs = set()
release_date = get_release_date(d)
@@ -528,6 +541,7 @@ def add_download_files(d, objset):
)
enrich_source_package(d, dl, fd, file_name, primary_purpose)
+ set_package_identity(d, dl, fd)
if release_date is not None:
dl.releaseTime = release_date
--
2.56.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH 2/4] spdx30: Record the lifecycle scope of crate dependencies
2026-11-18 9:29 [PATCH 0/4] spdx30: identity and purls of dependency downloads Stefano Tondo
2026-11-18 9:29 ` [PATCH 1/4] spdx30: Take name, version and PURL of downloads from the fetcher Stefano Tondo
@ 2026-11-18 9:29 ` Stefano Tondo
2026-11-18 9:29 ` [PATCH 3/4] spdx30: Add the PURLs of the source downloads to the output packages Stefano Tondo
2026-11-18 9:29 ` [PATCH 4/4] oeqa/selftest: spdx: Test crate identity, scope and output PURLs Stefano Tondo
3 siblings, 0 replies; 5+ messages in thread
From: Stefano Tondo @ 2026-11-18 9:29 UTC (permalink / raw)
To: openembedded-core
Cc: Joshua Watt, Alexander Kanavin, Stefan Herbrechtsmeier,
Stefano Tondo, Stefano Tondo
From: Stefano Tondo <stefano.tondo.ext@siemens.com>
A Cargo.lock file lists the crates for all targets, and some crates
only run at build time (build scripts, proc-macros and the crates
they use). The fetcher downloads all of them, but only some end up in
the binary.
Add a do_cargo_metadata task that writes the dependency graph for the
target with cargo metadata --filter-platform. The create_spdx task
reads this graph. It links the build to each crate download with a
scoped dependsOn relationship: runtime, build or test. A crate that is
not used on the target gets an annotation instead.
Signed-off-by: Stefano Tondo <stefano.tondo.ext@siemens.com>
---
meta/classes-recipe/cargo.bbclass | 17 +++++++
meta/lib/oe/spdx30_tasks.py | 81 +++++++++++++++++++++++++++++++
2 files changed, 98 insertions(+)
diff --git a/meta/classes-recipe/cargo.bbclass b/meta/classes-recipe/cargo.bbclass
index 586071988a..b3e82f9d5b 100644
--- a/meta/classes-recipe/cargo.bbclass
+++ b/meta/classes-recipe/cargo.bbclass
@@ -26,6 +26,23 @@ cargo_do_compile () {
"${CARGO}" build ${CARGO_BUILD_FLAGS} ${PACKAGECONFIG_CONFARGS} "$@"
}
+# The crate dependency graph for the target, with the crates that are not
+# used on it removed. create-spdx uses it to give each crate download a
+# lifecycle scope.
+CARGO_METADATA_FILE = "${WORKDIR}/cargo-metadata.json"
+
+do_cargo_metadata () {
+ rm -f "${CARGO_METADATA_FILE}"
+ # Some recipes inherit cargo without being a cargo project
+ if [ ! -f "${CARGO_MANIFEST_PATH}" ]; then
+ return
+ fi
+ "${CARGO}" metadata --format-version 1 --offline --locked \
+ --manifest-path "${CARGO_MANIFEST_PATH}" \
+ --filter-platform "${RUST_HOST_SYS}" > "${CARGO_METADATA_FILE}"
+}
+addtask cargo_metadata after do_configure before do_compile do_create_spdx
+
cargo_do_install () {
local have_installed=false
for tgt in "${B}/target/${CARGO_TARGET_SUBDIR}/"*; do
diff --git a/meta/lib/oe/spdx30_tasks.py b/meta/lib/oe/spdx30_tasks.py
index 58fe45ec7e..e40716a6df 100644
--- a/meta/lib/oe/spdx30_tasks.py
+++ b/meta/lib/oe/spdx30_tasks.py
@@ -476,6 +476,85 @@ def set_package_identity(d, dl, fd):
dl.software_packageUrl = identity["purl"]
+def get_cargo_scopes(d):
+ """Return {(crate, version): scope} from CARGO_METADATA_FILE.
+
+ The file is the output of cargo metadata --filter-platform for the
+ target, so crates used only on other targets are absent. Walks the
+ dependency graph from the workspace members: normal dependencies are
+ runtime, build dependencies and proc-macro crates (and everything they
+ pull in) are build, dev dependencies of the members are test.
+ """
+ path = d.getVar("CARGO_METADATA_FILE")
+ if not path or not os.path.exists(path):
+ return None
+
+ with open(path) as f:
+ metadata = json.load(f)
+
+ packages = {p["id"]: p for p in metadata["packages"]}
+ nodes = {n["id"]: n for n in metadata["resolve"]["nodes"]}
+ members = set(metadata["workspace_members"])
+ rank = {"test": 1, "build": 2, "runtime": 3}
+
+ def is_proc_macro(pkg_id):
+ return any("proc-macro" in t["kind"] for t in packages[pkg_id]["targets"])
+
+ scopes = {}
+ stack = [(m, "runtime") for m in members]
+ while stack:
+ pkg_id, scope = stack.pop()
+ if pkg_id not in members:
+ if scope == "runtime" and is_proc_macro(pkg_id):
+ scope = "build"
+ if rank.get(scopes.get(pkg_id), 0) >= rank[scope]:
+ continue
+ scopes[pkg_id] = scope
+ for dep in nodes[pkg_id]["deps"]:
+ for kind in (k["kind"] for k in dep["dep_kinds"]):
+ if kind == "dev":
+ if pkg_id in members:
+ stack.append((dep["pkg"], "test"))
+ elif kind == "build":
+ stack.append((dep["pkg"], "test" if scope == "test" else "build"))
+ else:
+ stack.append((dep["pkg"], scope))
+
+ return {
+ (packages[i]["name"], packages[i]["version"]): s for i, s in scopes.items()
+ }
+
+
+def add_dependency_scopes(d, objset, build, source_files):
+ """Give crate downloads a lifecycle scope, see get_cargo_scopes()."""
+ scopes = get_cargo_scopes(d)
+ if scopes is None:
+ return
+
+ by_scope = {}
+ for dl in source_files:
+ if not (getattr(dl, "software_packageUrl", None) or "").startswith("pkg:cargo/"):
+ continue
+ scope = scopes.get((dl.name, dl.software_packageVersion))
+ if scope:
+ by_scope.setdefault(scope, []).append(dl)
+ else:
+ objset.new_annotation(
+ dl,
+ "%s %s is fetched but not built: not used on target %s"
+ % (dl.name, dl.software_packageVersion, d.getVar("RUST_HOST_SYS")),
+ oe.spdx30.AnnotationType.other,
+ )
+
+ for scope, dls in sorted(by_scope.items()):
+ objset.new_scoped_relationship(
+ [build],
+ oe.spdx30.RelationshipType.dependsOn,
+ getattr(oe.spdx30.LifecycleScopeType, scope),
+ sorted(oe.sbom30.get_element_link_id(dl) for dl in dls),
+ )
+
+
def add_download_files(d, objset):
inputs = set()
release_date = get_release_date(d)
@@ -978,6 +1057,8 @@ def create_spdx(d):
source_files = add_download_files(d, build_objset)
build_inputs |= source_files
+ if bb.data.inherits_class("cargo", d):
+ add_dependency_scopes(d, build_objset, build, source_files)
recipe_spdx_license = add_license_expression(
d, build_objset, d.getVar("LICENSE"), license_data, [recipe_objset]
--
2.56.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH 3/4] spdx30: Add the PURLs of the source downloads to the output packages
2026-11-18 9:29 [PATCH 0/4] spdx30: identity and purls of dependency downloads Stefano Tondo
2026-11-18 9:29 ` [PATCH 1/4] spdx30: Take name, version and PURL of downloads from the fetcher Stefano Tondo
2026-11-18 9:29 ` [PATCH 2/4] spdx30: Record the lifecycle scope of crate dependencies Stefano Tondo
@ 2026-11-18 9:29 ` Stefano Tondo
2026-11-18 9:29 ` [PATCH 4/4] oeqa/selftest: spdx: Test crate identity, scope and output PURLs Stefano Tondo
3 siblings, 0 replies; 5+ messages in thread
From: Stefano Tondo @ 2026-11-18 9:29 UTC (permalink / raw)
To: openembedded-core
Cc: Joshua Watt, Alexander Kanavin, Stefan Herbrechtsmeier,
Stefano Tondo, Stefano Tondo
From: Stefano Tondo <stefano.tondo.ext@siemens.com>
Statically linked code, for example a Rust crate, is part of the
binary, but the SPDX of the output package only names the recipe.
A vulnerability scanner that checks the packages of an image does
not find the dependency.
Add the PURLs of the source downloads to the external identifiers of
each output package. Leave out the crates that the cargo dependency
graph proves are not built into the target. The software_packageUrl
of the package stays the first PURL in SPDX_PACKAGE_URLS.
Signed-off-by: Stefano Tondo <stefano.tondo.ext@siemens.com>
---
meta/lib/oe/spdx30_tasks.py | 30 ++++++++++++++++++++++++++----
1 file changed, 26 insertions(+), 4 deletions(-)
diff --git a/meta/lib/oe/spdx30_tasks.py b/meta/lib/oe/spdx30_tasks.py
index e40716a6df..441df709a4 100644
--- a/meta/lib/oe/spdx30_tasks.py
+++ b/meta/lib/oe/spdx30_tasks.py
@@ -526,16 +526,24 @@ def get_cargo_scopes(d):
def add_dependency_scopes(d, objset, build, source_files):
- """Give crate downloads a lifecycle scope, see get_cargo_scopes()."""
+ """Give crate downloads a lifecycle scope, see get_cargo_scopes().
+
+ Returns the crate downloads that are not built into the target: crates
+ that are not used on it, build scripts, proc-macros and the crates
+ they use, and test-only crates.
+ """
scopes = get_cargo_scopes(d)
if scopes is None:
- return
+ return set()
by_scope = {}
+ not_in_target = set()
for dl in source_files:
if not (getattr(dl, "software_packageUrl", None) or "").startswith("pkg:cargo/"):
continue
scope = scopes.get((dl.name, dl.software_packageVersion))
+ if scope != "runtime":
+ not_in_target.add(dl)
if scope:
by_scope.setdefault(scope, []).append(dl)
else:
@@ -554,6 +562,8 @@ def add_dependency_scopes(d, objset, build, source_files):
sorted(oe.sbom30.get_element_link_id(dl) for dl in dls),
)
+ return not_in_target
+
def add_download_files(d, objset):
inputs = set()
@@ -1057,8 +1067,20 @@ def create_spdx(d):
source_files = add_download_files(d, build_objset)
build_inputs |= source_files
+
+ # The output packages inherit the PURLs of the downloads they are built
+ # from, as the code of statically linked dependencies is in them. Only
+ # the downloads known not to be built into the target are left out.
+ not_in_target = set()
if bb.data.inherits_class("cargo", d):
- add_dependency_scopes(d, build_objset, build, source_files)
+ not_in_target = add_dependency_scopes(d, build_objset, build, source_files)
+ dependency_purls = sorted(
+ {
+ dl.software_packageUrl
+ for dl in source_files
+ if getattr(dl, "software_packageUrl", None) and dl not in not_in_target
+ }
+ )
recipe_spdx_license = add_license_expression(
d, build_objset, d.getVar("LICENSE"), license_data, [recipe_objset]
@@ -1171,7 +1193,7 @@ def create_spdx(d):
d.getVar("SPDX_PACKAGE_URLS:%s" % package)
or d.getVar("SPDX_PACKAGE_URLS")
or ""
- ).split()
+ ).split() + dependency_purls
set_purls(spdx_package, purls)
--
2.56.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH 4/4] oeqa/selftest: spdx: Test crate identity, scope and output PURLs
2026-11-18 9:29 [PATCH 0/4] spdx30: identity and purls of dependency downloads Stefano Tondo
` (2 preceding siblings ...)
2026-11-18 9:29 ` [PATCH 3/4] spdx30: Add the PURLs of the source downloads to the output packages Stefano Tondo
@ 2026-11-18 9:29 ` Stefano Tondo
3 siblings, 0 replies; 5+ messages in thread
From: Stefano Tondo @ 2026-11-18 9:29 UTC (permalink / raw)
To: openembedded-core
Cc: Joshua Watt, Alexander Kanavin, Stefan Herbrechtsmeier,
Stefano Tondo, Stefano Tondo
From: Stefano Tondo <stefano.tondo.ext@siemens.com>
python3-bcrypt fetches 42 crates. The new tests check three things:
- Each crate download has its name, version and PURL.
- Each crate download has a lifecycle scope, or an annotation that it
is not built.
- The output package gets the PURLs of the runtime crates only.
The tests name only crates that do not change on recipe upgrades.
blowfish is the cipher of bcrypt. Only the pyo3 proc-macros use syn,
at build time. The other checks do not use crate names.
Signed-off-by: Stefano Tondo <stefano.tondo.ext@siemens.com>
---
meta/lib/oeqa/selftest/cases/spdx.py | 122 +++++++++++++++++++++++++++
1 file changed, 122 insertions(+)
diff --git a/meta/lib/oeqa/selftest/cases/spdx.py b/meta/lib/oeqa/selftest/cases/spdx.py
index ce9a8af4f6..d75c6146c7 100644
--- a/meta/lib/oeqa/selftest/cases/spdx.py
+++ b/meta/lib/oeqa/selftest/cases/spdx.py
@@ -9,6 +9,7 @@ import hashlib
from datetime import datetime, timezone
from oeqa.selftest.case import OESelftestTestCase
from oeqa.utils.commands import bitbake, get_bb_var, get_bb_vars
+import oe.purl
import oe.spdx30
@@ -543,3 +544,124 @@ class SPDX30Check(SPDX3CheckBase, OESelftestTestCase):
# Document should be fully linked
self.check_objset_missing_ids(objset)
+
+ def test_crate_package_identity(self):
+ """Test that crate downloads carry name, version and a cargo PURL."""
+ objset = self.check_recipe_spdx(
+ "python3-bcrypt",
+ "{DEPLOY_DIR_SPDX}/{SSTATE_PKGARCH}/builds/build-python3-bcrypt.spdx.json",
+ )
+
+ prefix = "https://static.crates.io/crates/"
+ crates = 0
+ for pkg in objset.foreach_type(oe.spdx30.software_Package):
+ location = pkg.software_downloadLocation or ""
+ if not location.startswith(prefix):
+ continue
+ name, version, _ = location[len(prefix):].split("/")
+ self.assertEqual(pkg.name, name)
+ self.assertEqual(pkg.software_packageVersion, version)
+ self.assertEqual(
+ pkg.software_packageUrl,
+ f"pkg:cargo/{oe.purl.quote(name)}@{oe.purl.quote(version)}",
+ )
+ crates += 1
+
+ self.assertGreater(crates, 0, "no crate downloads found")
+
+ def test_crate_dependency_scope(self):
+ """Test that crate downloads get a lifecycle scope for the target.
+
+ Every crate download is either the target of one scoped dependsOn
+ relationship or annotated as not built. python3-bcrypt fetches crates
+ for other platforms (WebAssembly, UEFI), which are never built for a
+ Linux target. blowfish is the cipher of bcrypt, and syn only runs at
+ build time in proc-macros, so these names do not change on upgrades.
+ """
+ objset = self.check_recipe_spdx(
+ "python3-bcrypt",
+ "{DEPLOY_DIR_SPDX}/{SSTATE_PKGARCH}/builds/build-python3-bcrypt.spdx.json",
+ )
+
+ crates = {
+ pkg._id: pkg.name
+ for pkg in objset.foreach_type(oe.spdx30.software_Package)
+ if (pkg.software_packageUrl or "").startswith("pkg:cargo/")
+ and (pkg.software_downloadLocation or "").startswith("https://static.crates.io/")
+ }
+
+ scope_of = {}
+ for rel in objset.foreach_type(oe.spdx30.LifecycleScopedRelationship):
+ if rel.relationshipType != oe.spdx30.RelationshipType.dependsOn:
+ continue
+ for to in rel.to:
+ to_id = to if isinstance(to, str) else to._id
+ if to_id in crates:
+ self.assertNotIn(crates[to_id], scope_of)
+ scope_of[crates[to_id]] = rel.scope
+
+ not_built = set()
+ for annotation in objset.foreach_type(oe.spdx30.Annotation):
+ subject = annotation.subject
+ subject_id = subject if isinstance(subject, str) else subject._id
+ if subject_id in crates and "not built" in annotation.statement:
+ not_built.add(crates[subject_id])
+
+ self.assertEqual(set(scope_of) | not_built, set(crates.values()))
+ self.assertFalse(set(scope_of) & not_built)
+ self.assertTrue(not_built, "no crate for another platform found")
+ self.assertEqual(scope_of["syn"], oe.spdx30.LifecycleScopeType.build)
+ self.assertEqual(scope_of["blowfish"], oe.spdx30.LifecycleScopeType.runtime)
+
+ def test_crate_purls_in_output_package(self):
+ """Test that the output package inherits the PURLs of its crates.
+
+ The package gets the PURLs of the crates with the runtime scope in
+ the build SPDX, and no other crate PURLs. syn only runs at build
+ time in proc-macros, so it is not in the binary.
+ """
+ objset = self.check_recipe_spdx(
+ "python3-bcrypt",
+ "{DEPLOY_DIR_SPDX}/{SSTATE_PKGARCH}/packages/package-python3-bcrypt.spdx.json",
+ )
+
+ package = next(
+ pkg
+ for pkg in objset.foreach_type(oe.spdx30.software_Package)
+ if pkg.name == "python3-bcrypt"
+ )
+ purls = {
+ e.identifier
+ for e in package.externalIdentifier
+ if e.externalIdentifierType == oe.spdx30.ExternalIdentifierType.packageUrl
+ }
+ crates = {p[len("pkg:cargo/"):].split("@")[0] for p in purls if p.startswith("pkg:cargo/")}
+
+ # The package's own PURL stays first
+ own_purls = get_bb_var("SPDX_PACKAGE_URLS", "python3-bcrypt").split()
+ self.assertEqual(package.software_packageUrl, own_purls[0])
+ self.assertTrue(set(own_purls) <= purls)
+ self.assertIn("blowfish", crates)
+ self.assertNotIn("syn", crates)
+
+ spdx_vars = get_bb_vars(["DEPLOY_DIR_SPDX", "SSTATE_PKGARCH"], "python3-bcrypt")
+ build_objset = self.check_spdx_file(
+ "{DEPLOY_DIR_SPDX}/{SSTATE_PKGARCH}/builds/build-python3-bcrypt.spdx.json".format(**spdx_vars)
+ )
+ downloads = {
+ pkg._id: pkg.software_packageUrl
+ for pkg in build_objset.foreach_type(oe.spdx30.software_Package)
+ if (pkg.software_packageUrl or "").startswith("pkg:cargo/")
+ }
+ runtime = set()
+ for rel in build_objset.foreach_type(oe.spdx30.LifecycleScopedRelationship):
+ if rel.scope != oe.spdx30.LifecycleScopeType.runtime:
+ continue
+ for to in rel.to:
+ to_id = to if isinstance(to, str) else to._id
+ if to_id in downloads:
+ runtime.add(downloads[to_id])
+
+ self.assertTrue(runtime, "no crate with the runtime scope found")
+ cargo_purls = {p for p in purls if p.startswith("pkg:cargo/")}
+ self.assertEqual(cargo_purls - set(own_purls), runtime)
--
2.56.1
^ permalink raw reply related [flat|nested] 5+ messages in thread