All of lore.kernel.org
 help / color / mirror / Atom feed
* Re: [PATCH] vfio: Allow untainted use of driver_override
@ 2026-11-19 20:00 kernel test robot
  0 siblings, 0 replies; 13+ messages in thread
From: kernel test robot @ 2026-11-19 20:00 UTC (permalink / raw)
  To: oe-kbuild; +Cc: lkp

:::::: 
:::::: Manual check reason: "too many reports for this commit"
:::::: 

BCC: lkp@intel.com
CC: llvm@lists.linux.dev
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <20261118235645.2907908-2-alex@shazbot.org>
References: <20261118235645.2907908-2-alex@shazbot.org>
TO: Alex Williamson <alex@shazbot.org>
TO: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>
CC: Alex Williamson <alex@shazbot.org>
CC: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
CC: Jonathan Corbet <corbet@lwn.net>
CC: Shuah Khan <skhan@linuxfoundation.org>
CC: Randy Dunlap <rdunlap@infradead.org>
CC: "Rafael J . Wysocki" <rafael@kernel.org>
CC: Danilo Krummrich <dakr@kernel.org>
CC: Johan Hovold <johan@kernel.org>
CC: Steven Rostedt <rostedt@goodmis.org>
CC: Masami Hiramatsu <mhiramat@kernel.org>
CC: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
CC: David Lechner <dlechner@baylibre.com>
CC: Armin Wolf <W_Armin@gmx.de>
CC: Thierry Reding <thierry.reding@kernel.org>
CC: Mike Rapoport <rppt@kernel.org>
CC: Arnd Bergmann <arnd@arndb.de>
CC: Karl Mehltretter <kmehltretter@gmail.com>
CC: "Paul E . McKenney" <paulmck@kernel.org>
CC: Borislav Petkov <bp@alien8.de>
CC: Dapeng Mi <dapeng1.mi@linux.intel.com>
CC: Marco Elver <elver@google.com>
CC: "Ethan Nelson-Moore" <enelsonmoore@gmail.com>
CC: Jeff Layton <jlayton@kernel.org>
CC: Bradley Morgan <brads@mainlining.org>
CC: Andrew Morton <akpm@linux-foundation.org>
CC: Linux Memory Management List <linux-mm@kvack.org>
CC: Petr Mladek <pmladek@suse.com>
CC: Pnina Feder <pnina.feder@mobileye.com>
CC: Mete Durlu <meted@linux.ibm.com>

Hi Alex,

kernel test robot noticed the following build errors:

[auto build test ERROR on awilliam-vfio/next]
[also build test ERROR on linus/master v7.4-rc3 next-20261116]
[cannot apply to awilliam-vfio/for-linus]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Alex-Williamson/vfio-Allow-untainted-use-of-driver_override/20261118-165644
base:   https://github.com/awilliam/linux-vfio.git next
patch link:    https://lore.kernel.org/r/20261118235645.2907908-2-alex%40shazbot.org
patch subject: [PATCH] vfio: Allow untainted use of driver_override
:::::: branch date: 10 hours ago
:::::: commit date: 10 hours ago
config: s390-defconfig (https://download.01.org/0day-ci/archive/20261120/202611200348.62aJTdIu-lkp@intel.com/config)
compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20261120/202611200348.62aJTdIu-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/r/202611200348.62aJTdIu-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/vfio/pci/mlx5/main.c:1455:8: error: field designator 'support_driver_override' does not refer to any field in type 'struct device_driver'
    1455 |                     .support_driver_override = true },
         |                     ~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   1 error generated.


vim +1455 drivers/vfio/pci/mlx5/main.c

88faa5e8ead62a Yishai Hadas    2022-02-24  1448  
6fadb021266d03 Yishai Hadas    2022-02-24  1449  static struct pci_driver mlx5vf_pci_driver = {
6fadb021266d03 Yishai Hadas    2022-02-24  1450  	.name = KBUILD_MODNAME,
6fadb021266d03 Yishai Hadas    2022-02-24  1451  	.id_table = mlx5vf_pci_table,
6fadb021266d03 Yishai Hadas    2022-02-24  1452  	.probe = mlx5vf_pci_probe,
6fadb021266d03 Yishai Hadas    2022-02-24  1453  	.remove = mlx5vf_pci_remove,
722a3b248ee211 Alex Williamson 2026-11-18  1454  	.driver	= { .pm = pm_ptr(&mlx5vf_pm_ops),
722a3b248ee211 Alex Williamson 2026-11-18 @1455  		    .support_driver_override = true },
88faa5e8ead62a Yishai Hadas    2022-02-24  1456  	.err_handler = &mlx5vf_err_handlers,
c490513c818d1e Jason Gunthorpe 2022-05-19  1457  	.driver_managed_dma = true,
6fadb021266d03 Yishai Hadas    2022-02-24  1458  };
6fadb021266d03 Yishai Hadas    2022-02-24  1459  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

^ permalink raw reply	[flat|nested] 13+ messages in thread
* Re: [PATCH] vfio: Allow untainted use of driver_override
@ 2026-11-19 19:08 kernel test robot
  0 siblings, 0 replies; 13+ messages in thread
From: kernel test robot @ 2026-11-19 19:08 UTC (permalink / raw)
  To: oe-kbuild; +Cc: lkp

:::::: 
:::::: Manual check reason: "too many reports for this commit"
:::::: 

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <20261118235645.2907908-2-alex@shazbot.org>
References: <20261118235645.2907908-2-alex@shazbot.org>
TO: Alex Williamson <alex@shazbot.org>
TO: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>
CC: Alex Williamson <alex@shazbot.org>
CC: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
CC: Jonathan Corbet <corbet@lwn.net>
CC: Shuah Khan <skhan@linuxfoundation.org>
CC: Randy Dunlap <rdunlap@infradead.org>
CC: "Rafael J . Wysocki" <rafael@kernel.org>
CC: Danilo Krummrich <dakr@kernel.org>
CC: Johan Hovold <johan@kernel.org>
CC: Steven Rostedt <rostedt@goodmis.org>
CC: Masami Hiramatsu <mhiramat@kernel.org>
CC: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
CC: David Lechner <dlechner@baylibre.com>
CC: Armin Wolf <W_Armin@gmx.de>
CC: Thierry Reding <thierry.reding@kernel.org>
CC: Mike Rapoport <rppt@kernel.org>
CC: Arnd Bergmann <arnd@arndb.de>
CC: Karl Mehltretter <kmehltretter@gmail.com>
CC: "Paul E . McKenney" <paulmck@kernel.org>
CC: Borislav Petkov <bp@alien8.de>
CC: Dapeng Mi <dapeng1.mi@linux.intel.com>
CC: Marco Elver <elver@google.com>
CC: "Ethan Nelson-Moore" <enelsonmoore@gmail.com>
CC: Jeff Layton <jlayton@kernel.org>
CC: Bradley Morgan <brads@mainlining.org>
CC: Andrew Morton <akpm@linux-foundation.org>
CC: Linux Memory Management List <linux-mm@kvack.org>
CC: Petr Mladek <pmladek@suse.com>
CC: Pnina Feder <pnina.feder@mobileye.com>
CC: Mete Durlu <meted@linux.ibm.com>

Hi Alex,

kernel test robot noticed the following build errors:

[auto build test ERROR on awilliam-vfio/next]
[also build test ERROR on linus/master v7.4-rc3 next-20261116]
[cannot apply to awilliam-vfio/for-linus]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Alex-Williamson/vfio-Allow-untainted-use-of-driver_override/20261118-165644
base:   https://github.com/awilliam/linux-vfio.git next
patch link:    https://lore.kernel.org/r/20261118235645.2907908-2-alex%40shazbot.org
patch subject: [PATCH] vfio: Allow untainted use of driver_override
:::::: branch date: 9 hours ago
:::::: commit date: 9 hours ago
config: s390-randconfig-1001-20261119 (https://download.01.org/0day-ci/archive/20261120/202611200233.KNmMbpyn-lkp@intel.com/config)
compiler: s390-linux-gcc (GCC) 14.4.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20261120/202611200233.KNmMbpyn-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/r/202611200233.KNmMbpyn-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/vfio/platform/vfio_amba.c:140:18: error: 'struct device_driver' has no member named 'support_driver_override'
     140 |                 .support_driver_override = true,
         |                  ^~~~~~~~~~~~~~~~~~~~~~~
>> drivers/vfio/platform/vfio_amba.c:140:44: error: initialization of 'const struct bus_type *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
     140 |                 .support_driver_override = true,
         |                                            ^~~~
   drivers/vfio/platform/vfio_amba.c:140:44: note: (near initialization for 'vfio_amba_driver.drv.bus')


vim +140 drivers/vfio/platform/vfio_amba.c

36fe431f2811fa3 Antonios Motakis   2015-03-16  133  
36fe431f2811fa3 Antonios Motakis   2015-03-16  134  static struct amba_driver vfio_amba_driver = {
36fe431f2811fa3 Antonios Motakis   2015-03-16  135  	.probe = vfio_amba_probe,
36fe431f2811fa3 Antonios Motakis   2015-03-16  136  	.remove = vfio_amba_remove,
ec29d22caea85d9 Geert Uytterhoeven 2024-02-26  137  	.id_table = vfio_amba_ids,
36fe431f2811fa3 Antonios Motakis   2015-03-16  138  	.drv = {
36fe431f2811fa3 Antonios Motakis   2015-03-16  139  		.name = "vfio-amba",
722a3b248ee2110 Alex Williamson    2026-11-18 @140  		.support_driver_override = true,
36fe431f2811fa3 Antonios Motakis   2015-03-16  141  	},
70693f470848f05 Lu Baolu           2022-04-18  142  	.driver_managed_dma = true,
36fe431f2811fa3 Antonios Motakis   2015-03-16  143  };
36fe431f2811fa3 Antonios Motakis   2015-03-16  144  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

^ permalink raw reply	[flat|nested] 13+ messages in thread
* Re: [PATCH] vfio: Allow untainted use of driver_override
@ 2026-11-19 16:53 kernel test robot
  0 siblings, 0 replies; 13+ messages in thread
From: kernel test robot @ 2026-11-19 16:53 UTC (permalink / raw)
  To: oe-kbuild; +Cc: lkp

:::::: 
:::::: Manual check reason: "too many reports for this commit"
:::::: 

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <20261118235645.2907908-2-alex@shazbot.org>
References: <20261118235645.2907908-2-alex@shazbot.org>
TO: Alex Williamson <alex@shazbot.org>
TO: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>
CC: Alex Williamson <alex@shazbot.org>
CC: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
CC: Jonathan Corbet <corbet@lwn.net>
CC: Shuah Khan <skhan@linuxfoundation.org>
CC: Randy Dunlap <rdunlap@infradead.org>
CC: "Rafael J . Wysocki" <rafael@kernel.org>
CC: Danilo Krummrich <dakr@kernel.org>
CC: Johan Hovold <johan@kernel.org>
CC: Steven Rostedt <rostedt@goodmis.org>
CC: Masami Hiramatsu <mhiramat@kernel.org>
CC: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
CC: David Lechner <dlechner@baylibre.com>
CC: Armin Wolf <W_Armin@gmx.de>
CC: Thierry Reding <thierry.reding@kernel.org>
CC: Mike Rapoport <rppt@kernel.org>
CC: Arnd Bergmann <arnd@arndb.de>
CC: Karl Mehltretter <kmehltretter@gmail.com>
CC: "Paul E . McKenney" <paulmck@kernel.org>
CC: Borislav Petkov <bp@alien8.de>
CC: Dapeng Mi <dapeng1.mi@linux.intel.com>
CC: Marco Elver <elver@google.com>
CC: "Ethan Nelson-Moore" <enelsonmoore@gmail.com>
CC: Jeff Layton <jlayton@kernel.org>
CC: Bradley Morgan <brads@mainlining.org>
CC: Andrew Morton <akpm@linux-foundation.org>
CC: Linux Memory Management List <linux-mm@kvack.org>
CC: Petr Mladek <pmladek@suse.com>
CC: Pnina Feder <pnina.feder@mobileye.com>
CC: Mete Durlu <meted@linux.ibm.com>

Hi Alex,

kernel test robot noticed the following build errors:

[auto build test ERROR on awilliam-vfio/next]
[also build test ERROR on linus/master v7.4-rc3 next-20261116]
[cannot apply to awilliam-vfio/for-linus]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Alex-Williamson/vfio-Allow-untainted-use-of-driver_override/20261118-165644
base:   https://github.com/awilliam/linux-vfio.git next
patch link:    https://lore.kernel.org/r/20261118235645.2907908-2-alex%40shazbot.org
patch subject: [PATCH] vfio: Allow untainted use of driver_override
:::::: branch date: 7 hours ago
:::::: commit date: 7 hours ago
config: x86_64-rhel-9.4 (https://download.01.org/0day-ci/archive/20261120/202611200026.gDtr55Vd-lkp@intel.com/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20261120/202611200026.gDtr55Vd-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/r/202611200026.gDtr55Vd-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/vfio/pci/vfio_pci.c:264:30: error: 'struct device_driver' has no member named 'support_driver_override'
     264 |                             .support_driver_override = true },
         |                              ^~~~~~~~~~~~~~~~~~~~~~~
>> drivers/vfio/pci/vfio_pci.c:264:56: error: initialization of 'void (*)(struct device *)' from 'int' makes pointer from integer without a cast [-Wint-conversion]
     264 |                             .support_driver_override = true },
         |                                                        ^~~~
   drivers/vfio/pci/vfio_pci.c:264:56: note: (near initialization for 'vfio_pci_driver.driver.coredump')
--
>> drivers/vfio/pci/mlx5/main.c:1455:22: error: 'struct device_driver' has no member named 'support_driver_override'
    1455 |                     .support_driver_override = true },
         |                      ^~~~~~~~~~~~~~~~~~~~~~~
>> drivers/vfio/pci/mlx5/main.c:1455:48: error: initialization of 'void (*)(struct device *)' from 'int' makes pointer from integer without a cast [-Wint-conversion]
    1455 |                     .support_driver_override = true },
         |                                                ^~~~
   drivers/vfio/pci/mlx5/main.c:1455:48: note: (near initialization for 'mlx5vf_pci_driver.driver.coredump')


vim +264 drivers/vfio/pci/vfio_pci.c

6a5f427bee12c82 Simon Song      2026-10-05  255  
ff53edf6d6ab097 Max Gurtovoy    2021-08-26  256  static struct pci_driver vfio_pci_driver = {
ff53edf6d6ab097 Max Gurtovoy    2021-08-26  257  	.name			= "vfio-pci",
cc6711b0bf36de0 Max Gurtovoy    2021-08-26  258  	.id_table		= vfio_pci_table,
ff53edf6d6ab097 Max Gurtovoy    2021-08-26  259  	.probe			= vfio_pci_probe,
ff53edf6d6ab097 Max Gurtovoy    2021-08-26  260  	.remove			= vfio_pci_remove,
ff53edf6d6ab097 Max Gurtovoy    2021-08-26  261  	.sriov_configure	= vfio_pci_sriov_configure,
6a5f427bee12c82 Simon Song      2026-10-05  262  	.err_handler		= &vfio_pci_err_handlers,
722a3b248ee2110 Alex Williamson 2026-11-18  263  	.driver		= { .pm = pm_ptr(&vfio_pci_pm_ops),
722a3b248ee2110 Alex Williamson 2026-11-18 @264  			    .support_driver_override = true },
70693f470848f05 Lu Baolu        2022-04-18  265  	.driver_managed_dma	= true,
ff53edf6d6ab097 Max Gurtovoy    2021-08-26  266  };
ff53edf6d6ab097 Max Gurtovoy    2021-08-26  267  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

^ permalink raw reply	[flat|nested] 13+ messages in thread
* Re: [PATCH] driver core: Disable driver overriding by default
@ 2026-11-18 16:22 Danilo Krummrich
  2026-11-18 23:56 ` [PATCH] vfio: Allow untainted use of driver_override Alex Williamson
  0 siblings, 1 reply; 13+ messages in thread
From: Danilo Krummrich @ 2026-11-18 16:22 UTC (permalink / raw)
  To: Uwe Kleine-König
  Cc: Greg Kroah-Hartman, Jonathan Corbet, Shuah Khan, Randy Dunlap,
	Rafael J. Wysocki, Johan Hovold, Steven Rostedt, Masami Hiramatsu,
	Mathieu Desnoyers, David Lechner, Armin Wolf, Thierry Reding,
	Mike Rapoport (Microsoft), Arnd Bergmann, Karl Mehltretter,
	Paul E. McKenney, Borislav Petkov (AMD), Dapeng Mi, Marco Elver,
	Ethan Nelson-Moore, Jeff Layton, Bradley Morgan, Andrew Morton,
	Petr Mladek, Pnina Feder, Mete Durlu, Aaron Tomlin, Rio,
	Feng Tang, linux-doc, linux-kernel, driver-core,
	linux-trace-kernel, Mark Brown, Bjorn Helgaas, Alex Williamson

On Mon Nov 16, 2026 at 12:08 PM CET, Uwe Kleine-König wrote:
> If this patch is accepted, a number of drivers that are supposed to be
> force-bound need to get their .support_driver_override property set. I'm
> aware of the following:
>
>  - spidev_spi_driver in drivers/spi/spidev.c
>  - stub_driver in drivers/pci/pci-stub.c
>  - uio_dmem_genirq in drivers/uio/uio_dmem_genirq.c
>  - uio_pci_driver in drivers/uio/uio_pci_generic.c
>  - uio_pdrv_genirq in drivers/uio/uio_pdrv_genirq.c
>  - vfio_amba_driver in drivers/vfio/platform/vfio_amba.c
>  - vfio_ccw_sch_driver in drivers/s390/cio/vfio_ccw_drv.c
>  - vfio_pci_driver in drivers/vfio/pci/vfio_pci.c
>  - vfio_platform_driver in drivers/vfio/platform/vfio_platform.c
>
> This is not needed for the userspace i2c driver.
>
> As the flag to set is only introduced in this patch and assuming this
> patch is accepted, I suggest to create an immutable branch for it to
> allow setting the needed flags in driver trees. Alternatively let all
> these go together via a single tree or branch.

Either is fine with me, but it's probably easier to just include the
corresponding patches in this series and merge them all together such that we
avoid having things broken in individual trees.

Can you please add the corresponding patches in a v2?

^ permalink raw reply	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2026-11-20 14:10 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-19 20:00 [PATCH] vfio: Allow untainted use of driver_override kernel test robot
  -- strict thread matches above, loose matches on Subject: below --
2026-11-19 19:08 kernel test robot
2026-11-19 16:53 kernel test robot
2026-11-18 16:22 [PATCH] driver core: Disable driver overriding by default Danilo Krummrich
2026-11-18 23:56 ` [PATCH] vfio: Allow untainted use of driver_override Alex Williamson
2026-11-19  0:09   ` sashiko-bot
2026-11-19  0:12   ` Creeley, Brett
2026-11-19 14:56   ` Mostafa Saleh
2026-11-19 16:51   ` kernel test robot
2026-11-19 16:51   ` kernel test robot
2026-11-19 17:40   ` kernel test robot
2026-11-19 18:36   ` Ankit Agrawal
2026-11-20  2:17   ` Yao Yuan
2026-11-20 14:10     ` Uwe Kleine-König

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.