From: sashiko-bot@kernel.org
To: "Alex Williamson" <alex@shazbot.org>
Cc: linux-trace-kernel@vger.kernel.org,
virtualization@lists.linux.dev, intel-xe@lists.freedesktop.org,
kvm@vger.kernel.org, "Michael S. Tsirkin" <mst@redhat.com>,
"Eugenio Perez" <eperezma@redhat.com>
Subject: Re: [PATCH] vfio: Allow untainted use of driver_override
Date: Thu, 19 Nov 2026 00:09:22 +0000 [thread overview]
Message-ID: <sashiko-outbox-222233@kernel.org> (raw)
In-Reply-To: <20261118235645.2907908-2-alex@shazbot.org>
Thank you for your contribution! Sashiko AI review found 2 potential
issues to consider:
- [High] vfio: build failure due to missing support_driver_override in
device_driver
- [Medium] vfio: missing support_driver_override on s390 vfio_ccw and
vfio_ap drivers
--
commit e1a4bdaaf4e34e9a150096261c67507d2bd63625
Author: Alex Williamson <alex@shazbot.org>
vfio: Allow untainted use of driver_override
This commit sets the support_driver_override flag on the embedded device
driver structures across vfio drivers so that binding devices via
driver_override continues to work without tainting the kernel.
> Set the support_driver_override flag on the driver struct across all
> vfio drivers.
[Severity: Medium]
Should the s390 vfio drivers outside drivers/vfio/ also set
support_driver_override?
Both vfio_ccw_sch_driver in drivers/s390/cio/vfio_ccw_drv.c and
vfio_ap_drv in drivers/s390/crypto/vfio_ap_drv.c bind to devices via
device_match_driver_override() on css_bus_type and ap_bus_type, so
omitting them will deny or taint driver_override bindings for vfio_ccw
subchannels and vfio_ap queues.
> diff --git a/drivers/vfio/cdx/main.c b/drivers/vfio/cdx/main.c
> index 28dc8c8256006..fb7679bf92fd3 100644
> --- a/drivers/vfio/cdx/main.c
> +++ b/drivers/vfio/cdx/main.c
> @@ -358,6 +358,7 @@ static struct cdx_driver vfio_cdx_driver = {
> .match_id_table = vfio_cdx_table,
> .driver = {
> .name = "vfio-cdx",
> + .support_driver_override = true,
> },
> .driver_managed_dma = true,
> };
[Severity: High]
Is this missing the prerequisite driver-core patch that adds
support_driver_override to struct device_driver? In this tree, struct
device_driver in include/linux/device/driver.h has no
support_driver_override member, so building any of the 13 modified vfio
drivers fails with an unknown field in initializer error.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261118235645.2907908-2-alex@shazbot.org?part=1
next prev parent reply other threads:[~2026-11-19 0:09 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 11:08 [PATCH] driver core: Disable driver overriding by default Uwe Kleine-König
2026-11-16 11:36 ` sashiko-bot
2026-11-16 15:48 ` Uwe Kleine-König
2026-11-18 5:51 ` Michael Kelley
2026-11-18 7:43 ` Uwe Kleine-König
2026-11-18 15:45 ` Michael Kelley
2026-11-18 16:04 ` Bradley Morgan
2026-11-18 16:22 ` Danilo Krummrich
2026-11-18 23:56 ` [PATCH] PCI: Allow untainted driver_override for PCI stub drivers Alex Williamson
2026-11-19 0:03 ` sashiko-bot
2026-11-20 2:32 ` kernel test robot
2026-11-20 4:20 ` kernel test robot
2026-11-20 6:58 ` kernel test robot
2026-11-18 23:56 ` [PATCH] vfio: Allow untainted use of driver_override Alex Williamson
2026-11-19 0:09 ` sashiko-bot [this message]
2026-11-19 0:12 ` Creeley, Brett
2026-11-19 14:56 ` Mostafa Saleh
2026-11-19 16:51 ` kernel test robot
2026-11-19 16:51 ` kernel test robot
2026-11-19 17:40 ` kernel test robot
2026-11-19 18:36 ` Ankit Agrawal
2026-11-20 2:17 ` Yao Yuan
2026-11-20 14:10 ` Uwe Kleine-König
2026-11-19 5:15 ` [PATCH] s390/vfio: " Alex Williamson
2026-11-19 5:22 ` sashiko-bot
2026-11-19 12:14 ` Anthony Krowiak
2026-11-19 18:03 ` Uwe Kleine-König
2026-11-19 22:55 ` kernel test robot
2026-11-19 23:16 ` kernel test robot
2026-11-20 2:12 ` kernel test robot
2026-11-19 17:01 ` ✗ LGCI.VerificationFailed: failure for vfio: " Patchwork
2026-11-19 3:35 ` [PATCH] driver core: Disable driver overriding by default Armin Wolf
-- strict thread matches above, loose matches on Subject: below --
2026-11-19 16:53 [PATCH] vfio: Allow untainted use of driver_override kernel test robot
2026-11-19 19:08 kernel test robot
2026-11-19 20:00 kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-222233@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=alex@shazbot.org \
--cc=eperezma@redhat.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=kvm@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=sashiko-reviews@lists.linux.dev \
--cc=virtualization@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.