From: sashiko-bot@kernel.org
To: "Alex Williamson" <alex@shazbot.org>
Cc: linux-trace-kernel@vger.kernel.org, linux-s390@vger.kernel.org,
"Heiko Carstens" <hca@linux.ibm.com>,
"Vasily Gorbik" <gor@linux.ibm.com>,
"Alexander Gordeev" <agordeev@linux.ibm.com>,
"Christian Borntraeger" <borntraeger@linux.ibm.com>
Subject: Re: [PATCH] s390/vfio: Allow untainted use of driver_override
Date: Thu, 19 Nov 2026 05:22:54 +0000 [thread overview]
Message-ID: <sashiko-outbox-222474@kernel.org> (raw)
In-Reply-To: <20261119051507.3306075-1-alex@shazbot.org>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] s390/vfio: unknown field support_driver_override in struct
device_driver
--
commit a91edca560e83afe4c0101413f2c0a4218259662
Author: Alex Williamson <alex@shazbot.org>
s390/vfio: Allow untainted use of driver_override
This commit sets the support_driver_override flag on the vfio_ccw_sch_driver
and vfio_ap_drv driver structs.
> diff --git a/drivers/s390/cio/vfio_ccw_drv.c b/drivers/s390/cio/vfio_ccw_drv.c
> index 7546bd137e4e1..77765cde87f78 100644
> --- a/drivers/s390/cio/vfio_ccw_drv.c
> +++ b/drivers/s390/cio/vfio_ccw_drv.c
> @@ -375,6 +375,7 @@ static struct css_driver vfio_ccw_sch_driver = {
> .drv = {
> .name = "vfio_ccw",
> .owner = THIS_MODULE,
> + .support_driver_override = true,
> },
> .subchannel_type = vfio_ccw_sch_ids,
> .irq = vfio_ccw_sch_irq,
> diff --git a/drivers/s390/crypto/vfio_ap_drv.c b/drivers/s390/crypto/vfio_ap_drv.c
> index 8e69ed286bb9c..2d47dc6432698 100644
> --- a/drivers/s390/crypto/vfio_ap_drv.c
> +++ b/drivers/s390/crypto/vfio_ap_drv.c
> @@ -62,6 +62,7 @@ static struct ap_driver vfio_ap_drv = {
> .on_config_changed = vfio_ap_on_cfg_changed,
> .on_scan_complete = vfio_ap_on_scan_complete,
> .ids = ap_queue_ids,
> + .driver.support_driver_override = true,
> };
[Severity: High]
Does struct device_driver have a support_driver_override member in this
tree? Without the driver-core prerequisite adding that field to struct
device_driver in include/linux/device/driver.h, building vfio_ccw_drv.c or
vfio_ap_drv.c fails with an unknown field error.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261119051507.3306075-1-alex@shazbot.org?part=1
next prev parent reply other threads:[~2026-11-19 5:22 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 11:08 [PATCH] driver core: Disable driver overriding by default Uwe Kleine-König
2026-11-16 11:36 ` sashiko-bot
2026-11-16 15:48 ` Uwe Kleine-König
2026-11-18 5:51 ` Michael Kelley
2026-11-18 7:43 ` Uwe Kleine-König
2026-11-18 15:45 ` Michael Kelley
2026-11-18 16:04 ` Bradley Morgan
2026-11-18 16:22 ` Danilo Krummrich
2026-11-18 23:56 ` [PATCH] PCI: Allow untainted driver_override for PCI stub drivers Alex Williamson
2026-11-19 0:03 ` sashiko-bot
2026-11-20 2:32 ` kernel test robot
2026-11-20 4:20 ` kernel test robot
2026-11-20 6:58 ` kernel test robot
2026-11-18 23:56 ` [PATCH] vfio: Allow untainted use of driver_override Alex Williamson
2026-11-19 0:09 ` sashiko-bot
2026-11-19 0:12 ` Creeley, Brett
2026-11-19 14:56 ` Mostafa Saleh
2026-11-19 16:51 ` kernel test robot
2026-11-19 16:51 ` kernel test robot
2026-11-19 17:40 ` kernel test robot
2026-11-19 18:36 ` Ankit Agrawal
2026-11-20 2:17 ` Yao Yuan
2026-11-20 14:10 ` Uwe Kleine-König
2026-11-19 5:15 ` [PATCH] s390/vfio: " Alex Williamson
2026-11-19 5:22 ` sashiko-bot [this message]
2026-11-19 12:14 ` Anthony Krowiak
2026-11-19 18:03 ` Uwe Kleine-König
2026-11-19 22:55 ` kernel test robot
2026-11-19 23:16 ` kernel test robot
2026-11-20 2:12 ` kernel test robot
2026-11-19 17:01 ` ✗ LGCI.VerificationFailed: failure for vfio: " Patchwork
2026-11-19 3:35 ` [PATCH] driver core: Disable driver overriding by default Armin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-222474@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=agordeev@linux.ibm.com \
--cc=alex@shazbot.org \
--cc=borntraeger@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=linux-s390@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.