From: sashiko-bot@kernel.org
To: "Alex Williamson" <alex@shazbot.org>
Cc: linux-trace-kernel@vger.kernel.org, linux-pci@vger.kernel.org
Subject: Re: [PATCH] PCI: Allow untainted driver_override for PCI stub drivers
Date: Thu, 19 Nov 2026 00:03:27 +0000 [thread overview]
Message-ID: <sashiko-outbox-222222@kernel.org> (raw)
In-Reply-To: <20261118235645.2907908-1-alex@shazbot.org>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] PCI: build failure due to missing support_driver_override in
device_driver
--
commit 6d515d8bf97cee4e2be39125c16fa6391240af86
Author: Alex Williamson <alex@shazbot.org>
PCI: Allow untainted driver_override for PCI stub drivers
This commit sets .driver.support_driver_override = true on pf_stub_driver and
stub_driver to declare them safe for driver_override bindings.
> diff --git a/drivers/pci/pci-pf-stub.c b/drivers/pci/pci-pf-stub.c
> index da4db4928907e..328fb4a57092c 100644
> --- a/drivers/pci/pci-pf-stub.c
> +++ b/drivers/pci/pci-pf-stub.c
> @@ -36,6 +36,7 @@ static struct pci_driver pf_stub_driver = {
> .id_table = pci_pf_stub_whitelist,
> .probe = pci_pf_stub_probe,
> .sriov_configure = pci_sriov_configure_simple,
> + .driver.support_driver_override = true,
> };
> module_pci_driver(pf_stub_driver);
>
> diff --git a/drivers/pci/pci-stub.c b/drivers/pci/pci-stub.c
> index 9bc478df4e8f0..acbd43c17adc7 100644
> --- a/drivers/pci/pci-stub.c
> +++ b/drivers/pci/pci-stub.c
> @@ -37,6 +37,7 @@ static struct pci_driver stub_driver = {
> .id_table = NULL, /* only dynamic id's */
> .probe = pci_stub_probe,
> .driver_managed_dma = true,
> + .driver.support_driver_override = true,
> };
>
> static int __init pci_stub_init(void)
[Severity: High]
Does this fail to build when CONFIG_PCI_PF_STUB or CONFIG_PCI_STUB is
enabled? struct device_driver in include/linux/device/driver.h has no
support_driver_override member in this tree, as the prerequisite driver-core
patch introducing it is missing.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261118235645.2907908-1-alex@shazbot.org?part=1
next prev parent reply other threads:[~2026-11-19 0:03 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 11:08 [PATCH] driver core: Disable driver overriding by default Uwe Kleine-König
2026-11-16 11:36 ` sashiko-bot
2026-11-16 15:48 ` Uwe Kleine-König
2026-11-18 5:51 ` Michael Kelley
2026-11-18 7:43 ` Uwe Kleine-König
2026-11-18 15:45 ` Michael Kelley
2026-11-18 16:04 ` Bradley Morgan
2026-11-18 16:22 ` Danilo Krummrich
2026-11-18 23:56 ` [PATCH] PCI: Allow untainted driver_override for PCI stub drivers Alex Williamson
2026-11-19 0:03 ` sashiko-bot [this message]
2026-11-20 2:32 ` kernel test robot
2026-11-20 4:20 ` kernel test robot
2026-11-20 6:58 ` kernel test robot
2026-11-18 23:56 ` [PATCH] vfio: Allow untainted use of driver_override Alex Williamson
2026-11-19 0:09 ` sashiko-bot
2026-11-19 0:12 ` Creeley, Brett
2026-11-19 14:56 ` Mostafa Saleh
2026-11-19 16:51 ` kernel test robot
2026-11-19 16:51 ` kernel test robot
2026-11-19 17:40 ` kernel test robot
2026-11-19 18:36 ` Ankit Agrawal
2026-11-20 2:17 ` Yao Yuan
2026-11-20 14:10 ` Uwe Kleine-König
2026-11-19 5:15 ` [PATCH] s390/vfio: " Alex Williamson
2026-11-19 5:22 ` sashiko-bot
2026-11-19 12:14 ` Anthony Krowiak
2026-11-19 18:03 ` Uwe Kleine-König
2026-11-19 22:55 ` kernel test robot
2026-11-19 23:16 ` kernel test robot
2026-11-20 2:12 ` kernel test robot
2026-11-19 17:01 ` ✗ LGCI.VerificationFailed: failure for vfio: " Patchwork
2026-11-19 3:35 ` [PATCH] driver core: Disable driver overriding by default Armin Wolf
-- strict thread matches above, loose matches on Subject: below --
2026-11-20 10:35 [PATCH] PCI: Allow untainted driver_override for PCI stub drivers kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-222222@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=alex@shazbot.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.