All of lore.kernel.org
 help / color / mirror / Atom feed
From: saiprakash.ranjan@codeaurora.org
To: Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org,
	Rajendra Nayak <rnayak@codeaurora.org>,
	Suzuki K Poulose <suzuki.poulose@arm.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
	David Brown <david.brown@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	Sibi Sankar <sibis@codeaurora.org>,
	Vivek Gautam <vivek.gautam@codeaurora.org>,
	Leo Yan <leo.yan@linaro.org>, Andy Gross <andy.gross@linaro.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/3] coresight: etm4x: Add support to enable ETMv4.2
Date: Sat, 12 Jan 2019 18:03:57 +0530	[thread overview]
Message-ID: <2039d8fcb6c09efeeb5df3f373a4d6dd@codeaurora.org> (raw)
In-Reply-To: <20190111185242.GB22691@xps15>

Hi Mathieu,

> I think it would be better to simply mask out the minor version number 
> bits in
> function etm4_arch_supported().  That way we can add more intelligence 
> in there
> in the future if we have to and we don't have to touch the calling code 
> again.
> 

Thanks for the review. Yes it seems good, I will make this change in 
next version of the patch.

  - Sai

WARNING: multiple messages have this Message-ID (diff)
From: saiprakash.ranjan@codeaurora.org
To: Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org,
	Rajendra Nayak <rnayak@codeaurora.org>,
	Suzuki K Poulose <suzuki.poulose@arm.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
	David Brown <david.brown@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	Sibi Sankar <sibis@codeaurora.org>,
	Vivek Gautam <vivek.gautam@codeaurora.org>,
	Leo Yan <leo.yan@linaro.org>, Andy Gross <andy.gross@linaro.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/3] coresight: etm4x: Add support to enable ETMv4.2
Date: Sat, 12 Jan 2019 18:03:57 +0530	[thread overview]
Message-ID: <2039d8fcb6c09efeeb5df3f373a4d6dd@codeaurora.org> (raw)
In-Reply-To: <20190111185242.GB22691@xps15>

Hi Mathieu,

> I think it would be better to simply mask out the minor version number 
> bits in
> function etm4_arch_supported().  That way we can add more intelligence 
> in there
> in the future if we have to and we don't have to touch the calling code 
> again.
> 

Thanks for the review. Yes it seems good, I will make this change in 
next version of the patch.

  - Sai

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2019-01-12 12:33 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-09 17:46 [PATCH 0/3] Add coresight support for SDM845 Sai Prakash Ranjan
2019-01-09 17:46 ` Sai Prakash Ranjan
2019-01-09 17:46 ` [PATCH 1/3] arm64: dts: qcom: sdm845: Add Coresight support Sai Prakash Ranjan
2019-01-09 17:46   ` Sai Prakash Ranjan
2019-01-11 18:46   ` Mathieu Poirier
2019-01-11 18:46     ` Mathieu Poirier
2019-01-12 12:51     ` saiprakash.ranjan
2019-01-12 12:51       ` saiprakash.ranjan
2019-01-12 12:51       ` saiprakash.ranjan
2019-01-14 15:35       ` Mathieu Poirier
2019-01-14 15:35         ` Mathieu Poirier
2019-01-15 16:29         ` Sai Prakash Ranjan
2019-01-15 16:29           ` Sai Prakash Ranjan
2019-01-13  7:23   ` Bjorn Andersson
2019-01-13  7:23     ` Bjorn Andersson
2019-01-13  7:23     ` Bjorn Andersson
2019-01-15 16:27     ` Sai Prakash Ranjan
2019-01-15 16:27       ` Sai Prakash Ranjan
2019-01-17 19:50       ` Bjorn Andersson
2019-01-17 19:50         ` Bjorn Andersson
2019-01-18  3:00         ` Sai Prakash Ranjan
2019-01-18  3:00           ` Sai Prakash Ranjan
2019-01-09 17:46 ` [PATCH 2/3] coresight: etm4x: Add support to enable ETMv4.2 Sai Prakash Ranjan
2019-01-09 17:46   ` Sai Prakash Ranjan
2019-01-11 18:52   ` Mathieu Poirier
2019-01-11 18:52     ` Mathieu Poirier
2019-01-12 12:33     ` saiprakash.ranjan [this message]
2019-01-12 12:33       ` saiprakash.ranjan
2019-01-09 17:46 ` [PATCH 3/3] arm64: dts: qcom: sdm845: Remove the duplicate header inclusion Sai Prakash Ranjan
2019-01-09 17:46   ` Sai Prakash Ranjan
2019-01-09 17:46   ` Sai Prakash Ranjan
2019-01-09 22:57   ` Doug Anderson
2019-01-09 22:57     ` Doug Anderson
2019-01-09 22:57     ` Doug Anderson
2019-01-10  4:42     ` Sai Prakash Ranjan
2019-01-10  4:42       ` Sai Prakash Ranjan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2039d8fcb6c09efeeb5df3f373a4d6dd@codeaurora.org \
    --to=saiprakash.ranjan@codeaurora.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=andy.gross@linaro.org \
    --cc=david.brown@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=leo.yan@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mathieu.poirier@linaro.org \
    --cc=rnayak@codeaurora.org \
    --cc=robh+dt@kernel.org \
    --cc=sibis@codeaurora.org \
    --cc=suzuki.poulose@arm.com \
    --cc=vivek.gautam@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.