All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Alexander Graf <agraf@suse.de>
Cc: kvm@vger.kernel.org, kvm-ppc@vger.kernel.org,
	Stuart Yoder <stuart.yoder@freescale.com>,
	Scott Wood <scottwood@freescale.com>,
	Paul Mackerras <paulus@samba.org>,
	Peter Maydell <peter.maydell@linaro.org>,
	Gleb Natapov <gleb@redhat.com>
Subject: Re: in-kernel interrupt controller steering
Date: Wed, 06 Mar 2013 11:46:15 +0000	[thread overview]
Message-ID: <2040163825.3174283.1362570375614.JavaMail.root@redhat.com> (raw)
In-Reply-To: <13C727C1-19A2-47FA-A55A-2F34A3BEB68D@suse.de>

> Please go ahead and try to describe an interface the way you envision
> it. It needs to fulfill the following criteria:
> 
>   * different machine models have different interrupt controller
>   types
>   * we need to be able to fetch information from interrupt
>   controllers, this should be as flexible as possible because we
>   don't know all future state we want to synchronize today
>   * user space creates its virtual representation of an interrupt
>   controller after the vcpus got created
>   * user space needs a token to an interrupt controller, so that we
>   have the possibility to add a second in-kernel irqchip if the need
>   arises
> 
> What the current interface does is:
> 
>   SET_IRQCHIP_TYPE:
> 
>     * declare CPUs as listeners to a specific irqchip bus
>     * set the path that interrupt injection takes (this could
>     probably be changed to dynamic lookups though, based on device
>     tokens)
> 
>   CREATE_DEVICE:
> 
>     * spawn one or multiple in-kernel irqchip devices that hook up to
>     CPUs using the irqchip bus
>     * tell user space a token to access this irqchip
> 
> I really don't see why you wouldn't want to have that split.

I agree.  But is the device really being created at CREATE_DEVICE time?
What happens if you create N CPUs and N-1 irqchips?

On x86, the LAPIC is created magically together with the VCPU.

Paolo

WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: Alexander Graf <agraf@suse.de>
Cc: kvm@vger.kernel.org, kvm-ppc@vger.kernel.org,
	Stuart Yoder <stuart.yoder@freescale.com>,
	Scott Wood <scottwood@freescale.com>,
	Paul Mackerras <paulus@samba.org>,
	Peter Maydell <peter.maydell@linaro.org>,
	Gleb Natapov <gleb@redhat.com>
Subject: Re: in-kernel interrupt controller steering
Date: Wed, 6 Mar 2013 06:46:15 -0500 (EST)	[thread overview]
Message-ID: <2040163825.3174283.1362570375614.JavaMail.root@redhat.com> (raw)
In-Reply-To: <13C727C1-19A2-47FA-A55A-2F34A3BEB68D@suse.de>

> Please go ahead and try to describe an interface the way you envision
> it. It needs to fulfill the following criteria:
> 
>   * different machine models have different interrupt controller
>   types
>   * we need to be able to fetch information from interrupt
>   controllers, this should be as flexible as possible because we
>   don't know all future state we want to synchronize today
>   * user space creates its virtual representation of an interrupt
>   controller after the vcpus got created
>   * user space needs a token to an interrupt controller, so that we
>   have the possibility to add a second in-kernel irqchip if the need
>   arises
> 
> What the current interface does is:
> 
>   SET_IRQCHIP_TYPE:
> 
>     * declare CPUs as listeners to a specific irqchip bus
>     * set the path that interrupt injection takes (this could
>     probably be changed to dynamic lookups though, based on device
>     tokens)
> 
>   CREATE_DEVICE:
> 
>     * spawn one or multiple in-kernel irqchip devices that hook up to
>     CPUs using the irqchip bus
>     * tell user space a token to access this irqchip
> 
> I really don't see why you wouldn't want to have that split.

I agree.  But is the device really being created at CREATE_DEVICE time?
What happens if you create N CPUs and N-1 irqchips?

On x86, the LAPIC is created magically together with the VCPU.

Paolo

  reply	other threads:[~2013-03-06 11:46 UTC|newest]

Thread overview: 94+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-04 22:20 in-kernel interrupt controller steering Alexander Graf
2013-03-04 22:20 ` Alexander Graf
2013-03-05  0:59 ` Scott Wood
2013-03-05  0:59   ` Scott Wood
2013-03-05  5:44   ` Paul Mackerras
2013-03-05  5:44     ` Paul Mackerras
2013-03-05 15:25 ` Gleb Natapov
2013-03-05 15:25   ` Gleb Natapov
2013-03-06  9:40   ` Paolo Bonzini
2013-03-06  9:40     ` Paolo Bonzini
2013-03-06  9:58     ` Gleb Natapov
2013-03-06  9:58       ` Gleb Natapov
2013-03-06 10:04       ` Alexander Graf
2013-03-06 10:04         ` Alexander Graf
2013-03-06 10:12         ` Gleb Natapov
2013-03-06 10:12           ` Gleb Natapov
2013-03-06 10:38       ` Paolo Bonzini
2013-03-06 10:38         ` Paolo Bonzini
2013-03-06 10:38       ` Paolo Bonzini
2013-03-06 10:38         ` Paolo Bonzini
2013-03-06 11:26         ` Gleb Natapov
2013-03-06 11:26           ` Gleb Natapov
2013-03-06 11:44           ` Paolo Bonzini
2013-03-06 11:44             ` Paolo Bonzini
2013-03-06 11:46             ` Alexander Graf
2013-03-06 11:46               ` Alexander Graf
2013-03-06 11:59               ` Gleb Natapov
2013-03-06 11:59                 ` Gleb Natapov
2013-03-06 12:02                 ` Alexander Graf
2013-03-06 12:02                   ` Alexander Graf
2013-03-06 12:14                 ` Paolo Bonzini
2013-03-06 12:14                   ` Paolo Bonzini
2013-03-06 12:20                   ` Alexander Graf
2013-03-06 12:20                     ` Alexander Graf
2013-03-06 12:28                     ` Paolo Bonzini
2013-03-06 12:28                       ` Paolo Bonzini
2013-03-06 13:14                     ` Gleb Natapov
2013-03-06 13:14                       ` Gleb Natapov
2013-03-06 13:22                       ` Alexander Graf
2013-03-06 13:22                         ` Alexander Graf
2013-03-06 13:56                         ` Gleb Natapov
2013-03-06 13:56                           ` Gleb Natapov
2013-03-06 14:03                           ` Alexander Graf
2013-03-06 14:03                             ` Alexander Graf
2013-03-06 14:12                             ` Paolo Bonzini
2013-03-06 14:12                               ` Paolo Bonzini
2013-03-06 14:30                               ` Alexander Graf
2013-03-06 14:30                                 ` Alexander Graf
2013-03-06 14:37                                 ` Paolo Bonzini
2013-03-06 14:37                                   ` Paolo Bonzini
2013-03-06 14:40                                   ` Alexander Graf
2013-03-06 14:40                                     ` Alexander Graf
2013-03-06 14:41                             ` Gleb Natapov
2013-03-06 14:41                               ` Gleb Natapov
2013-03-06 14:48                               ` Alexander Graf
2013-03-06 14:48                                 ` Alexander Graf
2013-03-06 14:59                                 ` Alexander Graf
2013-03-06 14:59                                   ` Alexander Graf
2013-03-06 15:02                                   ` Paolo Bonzini
2013-03-06 15:02                                     ` Paolo Bonzini
2013-03-06 15:30                                 ` Gleb Natapov
2013-03-06 15:30                                   ` Gleb Natapov
2013-03-06 16:33                                   ` Alexander Graf
2013-03-06 16:33                                     ` Alexander Graf
2013-03-07  0:32                                 ` Paul Mackerras
2013-03-07  0:32                                   ` Paul Mackerras
2013-03-07  7:43                                   ` Paolo Bonzini
2013-03-07  7:43                                     ` Paolo Bonzini
2013-03-06 13:41                       ` Paolo Bonzini
2013-03-06 13:41                         ` Paolo Bonzini
2013-03-06 14:11                         ` Gleb Natapov
2013-03-06 14:11                           ` Gleb Natapov
2013-03-06 14:31                           ` Alexander Graf
2013-03-06 14:31                             ` Alexander Graf
2013-03-06 18:46                             ` Peter Maydell
2013-03-06 18:46                               ` Peter Maydell
2013-03-06 19:20                               ` Alexander Graf
2013-03-06 19:20                                 ` Alexander Graf
2013-03-06 11:44           ` Alexander Graf
2013-03-06 11:44             ` Alexander Graf
2013-03-06 11:46             ` Paolo Bonzini [this message]
2013-03-06 11:46               ` Paolo Bonzini
2013-03-06 11:47               ` Alexander Graf
2013-03-06 11:47                 ` Alexander Graf
2013-03-06 11:57                 ` Paolo Bonzini
2013-03-06 11:57                   ` Paolo Bonzini
2013-03-06 11:58                   ` Alexander Graf
2013-03-06 11:58                     ` Alexander Graf
2013-03-06 13:16                     ` Gleb Natapov
2013-03-06 13:16                       ` Gleb Natapov
2013-03-06  0:23 ` Benjamin Herrenschmidt
2013-03-06  0:23   ` Benjamin Herrenschmidt
2013-03-06  0:33   ` Alexander Graf
2013-03-06  0:33     ` Alexander Graf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2040163825.3174283.1362570375614.JavaMail.root@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=agraf@suse.de \
    --cc=gleb@redhat.com \
    --cc=kvm-ppc@vger.kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=paulus@samba.org \
    --cc=peter.maydell@linaro.org \
    --cc=scottwood@freescale.com \
    --cc=stuart.yoder@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.