Re: [PATCH 2/9] ARM: sh-mobile: mackerel: Add error IRQ resource

All of lore.kernel.org
 help / color / mirror / Atom feed

From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Bastian Hecht <hechtb@googlemail.com>
Cc: Magnus Damm <magnus.damm@gmail.com>,
	linux-mtd@lists.infradead.org, linux-sh@vger.kernel.org
Subject: Re: [PATCH 2/9] ARM: sh-mobile: mackerel: Add error IRQ resource
Date: Sat, 21 Apr 2012 16:30:36 +0200	[thread overview]
Message-ID: <2098300.FxL39kQn7a@avalon> (raw)
In-Reply-To: <1334913230-23615-3-git-send-email-hechtb@gmail.com>

Hi Bastian,

Thanks for the patch.

On Friday 20 April 2012 11:13:43 Bastian Hecht wrote:
> Supply the platform data for the FLSTEI error IRQ.

This should come before your 1/9 patch, otherwise the FLCTL driver will fail 
to get the IRQ, breaking git bisect.

> Signed-off-by: Bastian Hecht <hechtb@gmail.com>
> ---
>  arch/arm/mach-shmobile/board-mackerel.c |    6 +++++-
>  1 files changed, 5 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/arm/mach-shmobile/board-mackerel.c
> b/arch/arm/mach-shmobile/board-mackerel.c index 8758f94..1de1fb7 100644
> --- a/arch/arm/mach-shmobile/board-mackerel.c
> +++ b/arch/arm/mach-shmobile/board-mackerel.c
> @@ -990,7 +990,11 @@ static struct resource nand_flash_resources[] = {
>  		.start	= 0xe6a30000,
>  		.end	= 0xe6a3009b,
>  		.flags	= IORESOURCE_MEM,
> -	}
> +	},
> +	[1] = {
> +		.start	= evt2irq(0x0d80), /* flstei: status error irq */
> +		.flags	= IORESOURCE_IRQ,
> +	},
>  };
> 
>  static struct sh_flctl_platform_data nand_flash_data = {
-- 
Regards,

Laurent Pinchart

WARNING: multiple messages have this Message-ID (diff)

From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Bastian Hecht <hechtb@googlemail.com>
Cc: Magnus Damm <magnus.damm@gmail.com>,
	linux-mtd@lists.infradead.org, linux-sh@vger.kernel.org
Subject: Re: [PATCH 2/9] ARM: sh-mobile: mackerel: Add error IRQ resource
Date: Sat, 21 Apr 2012 14:30:36 +0000	[thread overview]
Message-ID: <2098300.FxL39kQn7a@avalon> (raw)
In-Reply-To: <1334913230-23615-3-git-send-email-hechtb@gmail.com>

Hi Bastian,

Thanks for the patch.

On Friday 20 April 2012 11:13:43 Bastian Hecht wrote:
> Supply the platform data for the FLSTEI error IRQ.

This should come before your 1/9 patch, otherwise the FLCTL driver will fail 
to get the IRQ, breaking git bisect.

> Signed-off-by: Bastian Hecht <hechtb@gmail.com>
> ---
>  arch/arm/mach-shmobile/board-mackerel.c |    6 +++++-
>  1 files changed, 5 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/arm/mach-shmobile/board-mackerel.c
> b/arch/arm/mach-shmobile/board-mackerel.c index 8758f94..1de1fb7 100644
> --- a/arch/arm/mach-shmobile/board-mackerel.c
> +++ b/arch/arm/mach-shmobile/board-mackerel.c
> @@ -990,7 +990,11 @@ static struct resource nand_flash_resources[] = {
>  		.start	= 0xe6a30000,
>  		.end	= 0xe6a3009b,
>  		.flags	= IORESOURCE_MEM,
> -	}
> +	},
> +	[1] = {
> +		.start	= evt2irq(0x0d80), /* flstei: status error irq */
> +		.flags	= IORESOURCE_IRQ,
> +	},
>  };
> 
>  static struct sh_flctl_platform_data nand_flash_data = {
-- 
Regards,

Laurent Pinchart

next prev parent reply	other threads:[~2012-04-21 20:07 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-20  9:13 [PATCH 0/9] sh_flctl hardware ECC mode cleanup Bastian Hecht
2012-04-20  9:13 ` Bastian Hecht
2012-04-20  9:13 ` [PATCH 1/9] mtd: sh_flctl: Add support for error IRQ Bastian Hecht
2012-04-20  9:13   ` Bastian Hecht
2012-04-21 14:29   ` Laurent Pinchart
2012-04-21 14:29     ` Laurent Pinchart
2012-04-23  8:41     ` Bastian Hecht
2012-04-23  8:41       ` Bastian Hecht
2012-04-20  9:13 ` [PATCH 2/9] ARM: sh-mobile: mackerel: Add error IRQ resource Bastian Hecht
2012-04-20  9:13   ` Bastian Hecht
2012-04-21 14:30   ` Laurent Pinchart [this message]
2012-04-21 14:30     ` Laurent Pinchart
2012-04-23  8:43     ` Bastian Hecht
2012-04-23  8:43       ` Bastian Hecht
2012-04-20  9:13 ` [PATCH 3/9] mtd: sh_flctl: Use different OOB layout Bastian Hecht
2012-04-20  9:13   ` Bastian Hecht
2012-04-21 14:41   ` Laurent Pinchart
2012-04-21 14:41     ` Laurent Pinchart
2012-04-23  8:51     ` Bastian Hecht
2012-04-23  8:51       ` Bastian Hecht
2012-04-20  9:13 ` [PATCH 4/9] mtd: sh_flctl: Fix hardware ECC behaviour Bastian Hecht
2012-04-20  9:13   ` Bastian Hecht
2012-04-20  9:13 ` [PATCH 5/9] mtd: sh_flctl: Simplify the hardware ecc page read/write Bastian Hecht
2012-04-20  9:13   ` Bastian Hecht
2012-04-20  9:13 ` [PATCH 6/9] mtd: sh_flctl: Group sector accesses into a single transfer Bastian Hecht
2012-04-20  9:13   ` Bastian Hecht
2012-04-20  9:13 ` [PATCH 7/9] mtd: sh_flctl: Restructure the hardware ECC handling Bastian Hecht
2012-04-20  9:13   ` Bastian Hecht
2012-04-20  9:13 ` [PATCH 8/9] mtd: sh_flctl: Use user oob data in hardware ECC mode Bastian Hecht
2012-04-20  9:13   ` Bastian Hecht
2012-04-21 15:00   ` Laurent Pinchart
2012-04-21 15:00     ` Laurent Pinchart
2012-04-23  9:05     ` Bastian Hecht
2012-04-23  9:05       ` Bastian Hecht
2012-04-23  9:36       ` Bastian Hecht
2012-04-23  9:36         ` Bastian Hecht
2012-04-24  9:33         ` Laurent Pinchart
2012-04-24  9:33           ` Laurent Pinchart
2012-04-25  4:01           ` Brian Norris
2012-04-25  4:01             ` Brian Norris
2012-04-25 13:26             ` Bastian Hecht
2012-04-25 13:26               ` Bastian Hecht
2012-04-20  9:13 ` [PATCH 9/9] ARM: sh-mobile: mackerel: Use hardware error correction Bastian Hecht
2012-04-20  9:13   ` Bastian Hecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2098300.FxL39kQn7a@avalon \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=hechtb@googlemail.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.