All of lore.kernel.org
 help / color / mirror / Atom feed
From: Luca Weiss <luca@z3ntu.xyz>
To: Rob Clark <robdclark@gmail.com>, ~postmarketos/upstreaming@lists.sr.ht
Cc: ~postmarketos/upstreaming@lists.sr.ht,
	Iskren Chernev <iskren.chernev@gmail.com>,
	Sean Paul <sean@poorly.run>, David Airlie <airlied@linux.ie>,
	Daniel Vetter <daniel@ffwll.ch>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Maxime Ripard <maxime@cerno.tech>,
	Abhinav Kumar <abhinavk@codeaurora.org>,
	Emil Velikov <emil.velikov@collabora.com>,
	Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
	Lee Jones <lee.jones@linaro.org>,
	Brian Masney <masneyb@onstation.org>,
	linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
	freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	Iskren Chernev <iskren.chernev@gmail.com>
Subject: Re: [PATCH] drm/msm/mdp5: Fix wait-for-commit for cmd panels
Date: Mon, 01 Feb 2021 00:06:01 +0100	[thread overview]
Message-ID: <2117852.HdQyuLfLX8@g550jk> (raw)
In-Reply-To: <20210127152442.533468-1-iskren.chernev@gmail.com>

Hi Iskren,

On Mittwoch, 27. Jänner 2021 16:24:40 CET Iskren Chernev wrote:
> Before the offending commit in msm_atomic_commit_tail wait_flush was
> called once per frame, after the commit was submitted. After it
> wait_flush is also called at the beginning to ensure previous
> potentially async commits are done.
> 
> For cmd panels the source of wait_flush is a ping-pong irq notifying
> a completion. The completion needs to be notified with complete_all so
> multiple waiting parties (new async committers) can proceed.
> 
> Signed-off-by: Iskren Chernev <iskren.chernev@gmail.com>
> Suggested-by: Rob Clark <robdclark@gmail.com>
> Fixes: 2d99ced787e3d ("drm/msm: async commit support")
> ---

I've tested this now on fairphone-fp2 and lge-nexus5-hammerhead, works great!

Tested-by: Luca Weiss <luca@z3ntu.xyz>

Regards
Luca



WARNING: multiple messages have this Message-ID (diff)
From: Luca Weiss <luca@z3ntu.xyz>
To: Rob Clark <robdclark@gmail.com>, ~postmarketos/upstreaming@lists.sr.ht
Cc: freedreno@lists.freedesktop.org,
	Thomas Zimmermann <tzimmermann@suse.de>,
	David Airlie <airlied@linux.ie>, Lee Jones <lee.jones@linaro.org>,
	dri-devel@lists.freedesktop.org,
	Brian Masney <masneyb@onstation.org>,
	Abhinav Kumar <abhinavk@codeaurora.org>,
	linux-kernel@vger.kernel.org,
	Iskren Chernev <iskren.chernev@gmail.com>,
	~postmarketos/upstreaming@lists.sr.ht,
	linux-arm-msm@vger.kernel.org,
	Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
	Emil Velikov <emil.velikov@collabora.com>,
	Sean Paul <sean@poorly.run>, Maxime Ripard <maxime@cerno.tech>
Subject: Re: [PATCH] drm/msm/mdp5: Fix wait-for-commit for cmd panels
Date: Mon, 01 Feb 2021 00:06:01 +0100	[thread overview]
Message-ID: <2117852.HdQyuLfLX8@g550jk> (raw)
In-Reply-To: <20210127152442.533468-1-iskren.chernev@gmail.com>

Hi Iskren,

On Mittwoch, 27. Jänner 2021 16:24:40 CET Iskren Chernev wrote:
> Before the offending commit in msm_atomic_commit_tail wait_flush was
> called once per frame, after the commit was submitted. After it
> wait_flush is also called at the beginning to ensure previous
> potentially async commits are done.
> 
> For cmd panels the source of wait_flush is a ping-pong irq notifying
> a completion. The completion needs to be notified with complete_all so
> multiple waiting parties (new async committers) can proceed.
> 
> Signed-off-by: Iskren Chernev <iskren.chernev@gmail.com>
> Suggested-by: Rob Clark <robdclark@gmail.com>
> Fixes: 2d99ced787e3d ("drm/msm: async commit support")
> ---

I've tested this now on fairphone-fp2 and lge-nexus5-hammerhead, works great!

Tested-by: Luca Weiss <luca@z3ntu.xyz>

Regards
Luca


_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2021-01-31 23:08 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-27 15:24 [PATCH] drm/msm/mdp5: Fix wait-for-commit for cmd panels Iskren Chernev
2021-01-27 15:24 ` Iskren Chernev
2021-01-31 22:53 ` Brian Masney
2021-01-31 22:53   ` Brian Masney
2021-01-31 23:06 ` Luca Weiss [this message]
2021-01-31 23:06   ` Luca Weiss
2021-02-01  5:57 ` Alexey Minnekhanov
2021-02-01  5:57   ` Alexey Minnekhanov
2021-03-01 19:59 ` patchwork-bot+linux-arm-msm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2117852.HdQyuLfLX8@g550jk \
    --to=luca@z3ntu.xyz \
    --cc=abhinavk@codeaurora.org \
    --cc=airlied@linux.ie \
    --cc=christophe.jaillet@wanadoo.fr \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=emil.velikov@collabora.com \
    --cc=freedreno@lists.freedesktop.org \
    --cc=iskren.chernev@gmail.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masneyb@onstation.org \
    --cc=maxime@cerno.tech \
    --cc=robdclark@gmail.com \
    --cc=sean@poorly.run \
    --cc=tzimmermann@suse.de \
    --cc=~postmarketos/upstreaming@lists.sr.ht \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.