From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
rfoss@kernel.org, todor.too@gmail.com, agross@kernel.org,
andersson@kernel.org, mchehab@kernel.org,
hverkuil-cisco@xs4all.nl, laurent.pinchart@ideasonboard.com,
sakari.ailus@linux.intel.com, andrey.konovalov@linaro.org
Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 11/15] media: qcom: camss: Functionally decompose CSIPHY clock lookups
Date: Sat, 26 Aug 2023 14:48:58 +0200 [thread overview]
Message-ID: <21610b1d-8294-4c3e-8aaa-b6c8dfaeea58@linaro.org> (raw)
In-Reply-To: <0510a774-07b9-e902-ccac-2fcd44a358dc@linaro.org>
On 26.08.2023 14:14, Bryan O'Donoghue wrote:
> On 26/08/2023 13:11, Konrad Dybcio wrote:
>>>> adding something like csiphy_timer_clks and cisphy_clks and stuff
>>>> would make this string comparison mess unnecessary
>>> I don't understand your comment.
>>>
>>> Having a litany of static comparisons is definitely inferior to a generic helper function.
>> portray this
>>
>> struct camss_whatever_it_was_called {
>> struct clk_bulk_data *csiphy_clks;
>> struct clk_bulk_data *csiphy_timer_clks;
>> [...]
>> }
>>
>> and then
>>
>> clk_bulk_prepare_enable(csiphy_clks)
>
> Ah would be grateful if you had just said "hey could you try using clk_bulk_prepare_enable()"
Right I could have been more clear
Konrad
next prev parent reply other threads:[~2023-08-26 12:49 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-23 10:44 [PATCH v3 00/15] media: qcom: camss: Add parameter passing to remove several outstanding bugs Bryan O'Donoghue
2023-08-23 10:44 ` [PATCH v3 01/15] media: qcom: camss: Amalgamate struct resource with struct resource_ispif Bryan O'Donoghue
2023-08-26 9:55 ` Konrad Dybcio
2023-08-28 17:30 ` Laurent Pinchart
2023-08-23 10:44 ` [PATCH v3 02/15] media: qcom: camss: Start to move to module compat matched resources Bryan O'Donoghue
2023-08-28 17:33 ` Laurent Pinchart
2023-08-23 10:44 ` [PATCH v3 03/15] media: qcom: camss: Pass icc bandwidth table as a platform parameter Bryan O'Donoghue
2023-08-28 17:35 ` Laurent Pinchart
2023-08-23 10:44 ` [PATCH v3 04/15] media: qcom: camss: Pass remainder of variables as resources Bryan O'Donoghue
2023-08-26 9:57 ` Konrad Dybcio
2023-08-28 17:51 ` Laurent Pinchart
2023-08-23 10:44 ` [PATCH v3 05/15] media: qcom: camss: Pass line_num from compat resources Bryan O'Donoghue
2023-08-28 18:36 ` Laurent Pinchart
2023-08-28 19:31 ` Bryan O'Donoghue
2023-08-23 10:44 ` [PATCH v3 06/15] media: qcom: camss: Assign the correct number of RDIs per VFE Bryan O'Donoghue
2023-08-28 18:43 ` Laurent Pinchart
2023-08-23 10:44 ` [PATCH v3 07/15] media: qcom: camss: Capture VFE CSID dependency in a helper function Bryan O'Donoghue
2023-08-26 10:02 ` Konrad Dybcio
2023-08-26 12:01 ` Bryan O'Donoghue
2023-08-26 12:04 ` Konrad Dybcio
2023-08-26 12:12 ` Bryan O'Donoghue
2023-08-26 12:13 ` Konrad Dybcio
2023-08-26 12:16 ` Bryan O'Donoghue
2023-08-28 18:47 ` Laurent Pinchart
2023-08-28 19:37 ` Bryan O'Donoghue
2023-08-28 19:40 ` Laurent Pinchart
2023-08-28 19:41 ` Bryan O'Donoghue
2023-09-04 10:15 ` Bryan O'Donoghue
2023-08-23 10:44 ` [PATCH v3 08/15] media: qcom: camss: Untangle if/else spaghetti in camss Bryan O'Donoghue
2023-08-26 10:03 ` Konrad Dybcio
2023-08-28 18:51 ` Laurent Pinchart
2023-08-28 19:43 ` Bryan O'Donoghue
2023-09-04 12:24 ` Bryan O'Donoghue
2023-08-23 10:44 ` [PATCH v3 09/15] media: qcom: camss: Improve error printout on icc_get fail Bryan O'Donoghue
2023-08-26 10:05 ` Konrad Dybcio
2023-08-26 12:01 ` Bryan O'Donoghue
2023-08-23 10:44 ` [PATCH v3 10/15] media: qcom: camss: Allow clocks vfeN vfe_liteN or vfe_lite Bryan O'Donoghue
2023-08-26 10:08 ` Konrad Dybcio
2023-08-26 12:05 ` Bryan O'Donoghue
2023-08-28 18:55 ` Laurent Pinchart
2023-08-23 10:44 ` [PATCH v3 11/15] media: qcom: camss: Functionally decompose CSIPHY clock lookups Bryan O'Donoghue
2023-08-26 10:12 ` Konrad Dybcio
2023-08-26 12:07 ` Bryan O'Donoghue
2023-08-26 12:11 ` Konrad Dybcio
2023-08-26 12:14 ` Bryan O'Donoghue
2023-08-26 12:48 ` Konrad Dybcio [this message]
2023-08-28 18:59 ` Laurent Pinchart
2023-08-23 10:44 ` [PATCH v3 12/15] media: qcom: camss: Fix support for setting CSIPHY clock name csiphyX Bryan O'Donoghue
2023-08-26 10:13 ` Konrad Dybcio
2023-08-26 12:08 ` Bryan O'Donoghue
2023-08-26 12:12 ` Konrad Dybcio
2023-09-04 19:11 ` Bryan O'Donoghue
2023-09-04 19:32 ` Konrad Dybcio
2023-09-04 19:33 ` Bryan O'Donoghue
2023-08-23 10:44 ` [PATCH v3 13/15] media: qcom: camss: Support RDI3 for VFE 17x Bryan O'Donoghue
2023-08-28 19:03 ` Laurent Pinchart
2023-08-23 10:44 ` [PATCH v3 14/15] media: qcom: camss: Convert vfe_disable() from int to void Bryan O'Donoghue
2023-08-26 10:16 ` Konrad Dybcio
2023-08-23 10:44 ` [PATCH v3 15/15] media: qcom: camss: Comment CSID dt_id field Bryan O'Donoghue
2023-08-26 10:18 ` Konrad Dybcio
2023-08-28 15:34 ` Bryan O'Donoghue
2023-08-28 15:38 ` Konrad Dybcio
2023-08-28 15:43 ` Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21610b1d-8294-4c3e-8aaa-b6c8dfaeea58@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=andrey.konovalov@linaro.org \
--cc=bryan.odonoghue@linaro.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=rfoss@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=todor.too@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.