From: Wen Gong <wgong@codeaurora.org>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: ath11k@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH v3 0/3] ath11k: add feature for device recovery
Date: Wed, 17 Nov 2021 17:35:14 +0800 [thread overview]
Message-ID: <21a93f4c93e636b47bd04e75cae90461@codeaurora.org> (raw)
In-Reply-To: <87sfvvdx1f.fsf@codeaurora.org>
On 2021-11-17 16:08, Kalle Valo wrote:
> Wen Gong <wgong@codeaurora.org> writes:
>
>> On 2021-11-15 20:53, Kalle Valo wrote:
>>> Wen Gong <wgong@codeaurora.org> writes:
>>>
>>>> From: Wen Gong <quic_wgong@quicinc.com>
>>>>
...
>>>
>>
>> I have sent v4, it is not to fix your fail:)
>> It added patch "ath11k: fix invalid m3 buffer address".
>> https://patchwork.kernel.org/project/linux-wireless/cover/20211116041522.23529-1-quic_wgong@quicinc.com/
>>
>>
>>> Also there should be a clear ath11k_warn() message when firmware
>>> recovery was successful, I could not find one from patches.
>>
>> Yes, if recovery succes, it will have "success" log.
>
> Where are the printouts? I cannot find any ath11k_warn() messages in
> v4.
> Basically I would want to see something like this when the firmware
> crashes:
It is not print in this patch.
It is here:
ath11k_mac_op_reconfig_complete(struct ieee80211_hw *hw,
enum ieee80211_reconfig_type reconfig_type)
if (ar->state == ATH11K_STATE_RESTARTED) {
ath11k_warn(ar->ab, "pdev %d successfully recovered\n",
ar->pdev->pdev_id);
>
> firmware crashed, restarting it
>
> And once the firmware is running again:
>
> firmware restarted succesfully
"firmware crashed" log is here:
static void ath11k_mhi_op_status_cb(struct mhi_controller *mhi_cntrl,
enum mhi_callback cb)
{
struct ath11k_base *ab = dev_get_drvdata(mhi_cntrl->cntrl_dev);
struct ath11k_pci *ar_pci = ath11k_pci_priv(ab);
switch (cb) {
case MHI_CB_SYS_ERROR:
ath11k_warn(ab, "firmware crashed: MHI_CB_SYS_ERROR\n");
--
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
WARNING: multiple messages have this Message-ID (diff)
From: Wen Gong <wgong@codeaurora.org>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: ath11k@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH v3 0/3] ath11k: add feature for device recovery
Date: Wed, 17 Nov 2021 17:35:14 +0800 [thread overview]
Message-ID: <21a93f4c93e636b47bd04e75cae90461@codeaurora.org> (raw)
In-Reply-To: <87sfvvdx1f.fsf@codeaurora.org>
On 2021-11-17 16:08, Kalle Valo wrote:
> Wen Gong <wgong@codeaurora.org> writes:
>
>> On 2021-11-15 20:53, Kalle Valo wrote:
>>> Wen Gong <wgong@codeaurora.org> writes:
>>>
>>>> From: Wen Gong <quic_wgong@quicinc.com>
>>>>
...
>>>
>>
>> I have sent v4, it is not to fix your fail:)
>> It added patch "ath11k: fix invalid m3 buffer address".
>> https://patchwork.kernel.org/project/linux-wireless/cover/20211116041522.23529-1-quic_wgong@quicinc.com/
>>
>>
>>> Also there should be a clear ath11k_warn() message when firmware
>>> recovery was successful, I could not find one from patches.
>>
>> Yes, if recovery succes, it will have "success" log.
>
> Where are the printouts? I cannot find any ath11k_warn() messages in
> v4.
> Basically I would want to see something like this when the firmware
> crashes:
It is not print in this patch.
It is here:
ath11k_mac_op_reconfig_complete(struct ieee80211_hw *hw,
enum ieee80211_reconfig_type reconfig_type)
if (ar->state == ATH11K_STATE_RESTARTED) {
ath11k_warn(ar->ab, "pdev %d successfully recovered\n",
ar->pdev->pdev_id);
>
> firmware crashed, restarting it
>
> And once the firmware is running again:
>
> firmware restarted succesfully
"firmware crashed" log is here:
static void ath11k_mhi_op_status_cb(struct mhi_controller *mhi_cntrl,
enum mhi_callback cb)
{
struct ath11k_base *ab = dev_get_drvdata(mhi_cntrl->cntrl_dev);
struct ath11k_pci *ar_pci = ath11k_pci_priv(ab);
switch (cb) {
case MHI_CB_SYS_ERROR:
ath11k_warn(ab, "firmware crashed: MHI_CB_SYS_ERROR\n");
next prev parent reply other threads:[~2021-11-17 9:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-15 3:54 [PATCH v3 0/3] ath11k: add feature for device recovery Wen Gong
2021-10-15 3:54 ` Wen Gong
2021-10-15 3:54 ` [PATCH v3 1/3] ath11k: add ath11k_qmi_free_resource() for recovery Wen Gong
2021-10-15 3:54 ` Wen Gong
2021-10-15 3:54 ` [PATCH v3 2/3] ath11k: add support for device recovery for QCA6390 Wen Gong
2021-10-15 3:54 ` Wen Gong
2021-10-15 3:54 ` [PATCH v3 3/3] ath11k: add synchronization operation between reconfigure of mac80211 and ath11k_base Wen Gong
2021-10-15 3:54 ` Wen Gong
2021-11-15 12:53 ` [PATCH v3 0/3] ath11k: add feature for device recovery Kalle Valo
2021-11-15 12:53 ` Kalle Valo
2021-11-16 4:19 ` Wen Gong
2021-11-16 4:19 ` Wen Gong
2021-11-17 8:08 ` Kalle Valo
2021-11-17 8:08 ` Kalle Valo
2021-11-17 9:35 ` Wen Gong [this message]
2021-11-17 9:35 ` Wen Gong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21a93f4c93e636b47bd04e75cae90461@codeaurora.org \
--to=wgong@codeaurora.org \
--cc=ath11k@lists.infradead.org \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.