Re: [PATCH 1/4] dt-bindings: sound: amlogic: t9015: Add missing AVDD-supply property

[Alexander Stein <alexander.stein@mailbox.org>]

Hello Jerome,

Am Montag, 25. Oktober 2021, 17:53:04 CEST schrieb Jerome Brunet:
> On Sat 23 Oct 2021 at 23:48, Alexander Stein <alexander.stein@mailbox.org> 
wrote:
> > Fixes the schema check warning "audio-controller@32000: 'AVDD-supply'
> > do not match any of the regexes: 'pinctrl-[0-9]+'"
> > 
> > Fixes: 5c36abcd2621 ("ASoC: meson: add t9015 internal codec binding
> > documentation") Signed-off-by: Alexander Stein
> > <alexander.stein@mailbox.org>
> 
> Hey Alexander,
> 
> First, thanks for picking this up.
> 
> I think Rob's automated reply is because you forgot to update the
> example (if the property is required, it should be there)

Thanks for pointing that out, I noticed too that examples are validated as 
well, nice feature.

> Also, I believe this change could have been sent separately, to Marc
> (instead of Cc) and with the "ASoC" prefix.
> 
> With this changed
> Reviewed-by: Jerome Brunet <jbrunet@baylibre.com>

Yeah, I'll split the set during v2. Thanks for the review.

Best regards,
Alexander

> 
> > ---
> > I am aware that adding required properties to bindings is frowned upon.
> > But in this case it seems acceptable for the following reasons:
> > * AVDD-supply was used from the very first driver commit
> > * All DT (g12 and gxl) using t9015 controller provide AVDD-supply
> > 
> >   already
> > 
> > But I'm ok to not add it to required properties as well. The driver uses
> > it nevertheless though.
> > 
> >  Documentation/devicetree/bindings/sound/amlogic,t9015.yaml | 5 +++++
> >  1 file changed, 5 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/sound/amlogic,t9015.yaml
> > b/Documentation/devicetree/bindings/sound/amlogic,t9015.yaml index
> > c7613ea728d4..5f4e25ab5af6 100644
> > --- a/Documentation/devicetree/bindings/sound/amlogic,t9015.yaml
> > +++ b/Documentation/devicetree/bindings/sound/amlogic,t9015.yaml
> > 
> > @@ -34,6 +34,10 @@ properties:
> >    resets:
> >      maxItems: 1
> > 
> > +  AVDD-supply:
> > +    description:
> > +      Analogue power supply.
> > +
> > 
> >  required:
> >    - "#sound-dai-cells"
> >    - compatible
> > 
> > @@ -41,6 +45,7 @@ required:
> >    - clocks
> >    - clock-names
> >    - resets
> > 
> > +  - AVDD-supply
> > 
> >  additionalProperties: false





_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic