From: Alexander Stein <alexander.stein@mailbox.org>
To: Jerome Brunet <jbrunet@baylibre.com>,
Rob Herring <robh+dt@kernel.org>,
Kevin Hilman <khilman@baylibre.com>,
Neil Armstrong <narmstrong@baylibre.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
devicetree@vger.kernel.org, linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/4] arm64: dts: amlogic: meson-g12: Fix thermal-zones indent
Date: Tue, 26 Oct 2021 18:21:41 +0200 [thread overview]
Message-ID: <5508780.DvuYhMxLoT@natsu> (raw)
In-Reply-To: <fd76f9e2-f3e1-8520-7569-2390edaa538e@baylibre.com>
Hello,
Am Dienstag, 26. Oktober 2021, 09:27:42 CEST schrieb Neil Armstrong:
> On 23/10/2021 23:48, Alexander Stein wrote:
> > This node is currently at /soc/thermal-zones, but the later introduced
> > bindings in commit 1202a442a31f ("dt-bindings: thermal: Add yaml bindings
> > for thermal zones") put this at /thermal-zones.
> > Fix dtb_check warning by moving the thermal-zones node to /
> >
> > Fixes: e7251ed74ef7 ("arm64: dts: meson: g12: Add minimal thermal zone")
> > Signed-off-by: Alexander Stein <alexander.stein@mailbox.org>
> > ---
> > I admit I'm a bit unsure about the 'Fixes' tag as at the time when those
> > thermal-zones were added there was no schema present. So there was no bug
> > at the time of writing. I'm ok either way.
>
> I'm also unsure about it, either you list all commits that must be present
> for the fix to be applied, or remove it since it's not a bug.
Alright, I'll remove the Fixes tag then and send a v2 with your Reviewed-By
for patches 3 & 4.
Best regards,
Alexander
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
WARNING: multiple messages have this Message-ID (diff)
From: Alexander Stein <alexander.stein@mailbox.org>
To: Jerome Brunet <jbrunet@baylibre.com>,
Rob Herring <robh+dt@kernel.org>,
Kevin Hilman <khilman@baylibre.com>,
Neil Armstrong <narmstrong@baylibre.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
devicetree@vger.kernel.org, linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/4] arm64: dts: amlogic: meson-g12: Fix thermal-zones indent
Date: Tue, 26 Oct 2021 18:21:41 +0200 [thread overview]
Message-ID: <5508780.DvuYhMxLoT@natsu> (raw)
In-Reply-To: <fd76f9e2-f3e1-8520-7569-2390edaa538e@baylibre.com>
Hello,
Am Dienstag, 26. Oktober 2021, 09:27:42 CEST schrieb Neil Armstrong:
> On 23/10/2021 23:48, Alexander Stein wrote:
> > This node is currently at /soc/thermal-zones, but the later introduced
> > bindings in commit 1202a442a31f ("dt-bindings: thermal: Add yaml bindings
> > for thermal zones") put this at /thermal-zones.
> > Fix dtb_check warning by moving the thermal-zones node to /
> >
> > Fixes: e7251ed74ef7 ("arm64: dts: meson: g12: Add minimal thermal zone")
> > Signed-off-by: Alexander Stein <alexander.stein@mailbox.org>
> > ---
> > I admit I'm a bit unsure about the 'Fixes' tag as at the time when those
> > thermal-zones were added there was no schema present. So there was no bug
> > at the time of writing. I'm ok either way.
>
> I'm also unsure about it, either you list all commits that must be present
> for the fix to be applied, or remove it since it's not a bug.
Alright, I'll remove the Fixes tag then and send a v2 with your Reviewed-By
for patches 3 & 4.
Best regards,
Alexander
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Alexander Stein <alexander.stein@mailbox.org>
To: Jerome Brunet <jbrunet@baylibre.com>,
Rob Herring <robh+dt@kernel.org>,
Kevin Hilman <khilman@baylibre.com>,
Neil Armstrong <narmstrong@baylibre.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
devicetree@vger.kernel.org, linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/4] arm64: dts: amlogic: meson-g12: Fix thermal-zones indent
Date: Tue, 26 Oct 2021 18:21:41 +0200 [thread overview]
Message-ID: <5508780.DvuYhMxLoT@natsu> (raw)
In-Reply-To: <fd76f9e2-f3e1-8520-7569-2390edaa538e@baylibre.com>
Hello,
Am Dienstag, 26. Oktober 2021, 09:27:42 CEST schrieb Neil Armstrong:
> On 23/10/2021 23:48, Alexander Stein wrote:
> > This node is currently at /soc/thermal-zones, but the later introduced
> > bindings in commit 1202a442a31f ("dt-bindings: thermal: Add yaml bindings
> > for thermal zones") put this at /thermal-zones.
> > Fix dtb_check warning by moving the thermal-zones node to /
> >
> > Fixes: e7251ed74ef7 ("arm64: dts: meson: g12: Add minimal thermal zone")
> > Signed-off-by: Alexander Stein <alexander.stein@mailbox.org>
> > ---
> > I admit I'm a bit unsure about the 'Fixes' tag as at the time when those
> > thermal-zones were added there was no schema present. So there was no bug
> > at the time of writing. I'm ok either way.
>
> I'm also unsure about it, either you list all commits that must be present
> for the fix to be applied, or remove it since it's not a bug.
Alright, I'll remove the Fixes tag then and send a v2 with your Reviewed-By
for patches 3 & 4.
Best regards,
Alexander
next prev parent reply other threads:[~2021-10-26 16:22 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-23 21:48 [PATCH 1/4] dt-bindings: sound: amlogic: t9015: Add missing AVDD-supply property Alexander Stein
2021-10-23 21:48 ` Alexander Stein
2021-10-23 21:48 ` Alexander Stein
2021-10-23 21:48 ` [PATCH 2/4] arm64: dts: amlogic: meson-g12: Fix thermal-zones indent Alexander Stein
2021-10-23 21:48 ` Alexander Stein
2021-10-23 21:48 ` Alexander Stein
2021-10-26 7:27 ` Neil Armstrong
2021-10-26 7:27 ` Neil Armstrong
2021-10-26 7:27 ` Neil Armstrong
2021-10-26 16:21 ` Alexander Stein [this message]
2021-10-26 16:21 ` Alexander Stein
2021-10-26 16:21 ` Alexander Stein
2021-10-23 21:48 ` [PATCH 3/4] arm64: dts: amlogic: meson-g12: Fix GPU operating point table node name Alexander Stein
2021-10-23 21:48 ` Alexander Stein
2021-10-23 21:48 ` Alexander Stein
2021-10-25 8:19 ` Neil Armstrong
2021-10-25 8:19 ` Neil Armstrong
2021-10-25 8:19 ` Neil Armstrong
2021-10-23 21:48 ` [PATCH 4/4] arm64: dts: amlogic: Fix SPI NOR flash node name for ODROID N2/N2+ Alexander Stein
2021-10-23 21:48 ` Alexander Stein
2021-10-23 21:48 ` Alexander Stein
2021-10-25 8:20 ` Neil Armstrong
2021-10-25 8:20 ` Neil Armstrong
2021-10-25 8:20 ` Neil Armstrong
2021-10-24 14:27 ` [PATCH 1/4] dt-bindings: sound: amlogic: t9015: Add missing AVDD-supply property Rob Herring
2021-10-24 14:27 ` Rob Herring
2021-10-24 14:27 ` Rob Herring
2021-10-25 9:44 ` Mark Brown
2021-10-25 9:44 ` Mark Brown
2021-10-25 9:44 ` Mark Brown
2021-10-25 15:53 ` Jerome Brunet
2021-10-25 15:53 ` Jerome Brunet
2021-10-25 15:53 ` Jerome Brunet
2021-10-26 16:30 ` Alexander Stein
2021-10-26 16:30 ` Alexander Stein
2021-10-26 16:30 ` Alexander Stein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5508780.DvuYhMxLoT@natsu \
--to=alexander.stein@mailbox.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=lgirdwood@gmail.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=narmstrong@baylibre.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.