All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tomasz Figa <tomasz.figa@gmail.com>
To: linux-arm-kernel@lists.infradead.org
Cc: "Linus Walleij" <linus.walleij@linaro.org>,
	"Tomasz Figa" <t.figa@samsung.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
	"Heiko Stübner" <heiko@sntech.de>,
	"Stephen Warren" <swarren@wwwdotorg.org>,
	"Doug Anderson" <dianders@chromium.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Kyungmin Park" <kyungmin.park@samsung.com>,
	"Kukjin Kim" <kgene.kim@samsung.com>,
	"Thomas Abraham" <thomas.abraham@linaro.org>,
	"Marek Szyprowski" <m.szyprowski@samsung.com>
Subject: Re: [PATCH] pinctrl: samsung: Allow grouping multiple pinmux/pinconf nodes
Date: Tue, 26 Nov 2013 01:32:07 +0100	[thread overview]
Message-ID: <2242006.0l244SkK9j@flatron> (raw)
In-Reply-To: <CACRpkdZHUfZinS20OFm+DkziiACxDOvJNhDMvdw3LdDbau1tCA@mail.gmail.com>

On Monday 25 of November 2013 15:46:12 Linus Walleij wrote:
> On Wed, Nov 20, 2013 at 3:00 PM, Tomasz Figa <t.figa@samsung.com> wrote:
> > Stephen:
> >> Is the lifetime of the string "returned" by
> >> of_property_read_string_index() really so short that you must copy the
> >> string? I'd be tempted just to store the pointer, although perhaps you
> >> need to get() the node so that's safe.
> >
> > Right. I have done it the copy-less way in other places, but missed this
> > one. Thanks.
> 
> So I guess I'm waiting for a new version of this patch, right?

Right.

Best regards,
Tomasz

WARNING: multiple messages have this Message-ID (diff)
From: tomasz.figa@gmail.com (Tomasz Figa)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] pinctrl: samsung: Allow grouping multiple pinmux/pinconf nodes
Date: Tue, 26 Nov 2013 01:32:07 +0100	[thread overview]
Message-ID: <2242006.0l244SkK9j@flatron> (raw)
In-Reply-To: <CACRpkdZHUfZinS20OFm+DkziiACxDOvJNhDMvdw3LdDbau1tCA@mail.gmail.com>

On Monday 25 of November 2013 15:46:12 Linus Walleij wrote:
> On Wed, Nov 20, 2013 at 3:00 PM, Tomasz Figa <t.figa@samsung.com> wrote:
> > Stephen:
> >> Is the lifetime of the string "returned" by
> >> of_property_read_string_index() really so short that you must copy the
> >> string? I'd be tempted just to store the pointer, although perhaps you
> >> need to get() the node so that's safe.
> >
> > Right. I have done it the copy-less way in other places, but missed this
> > one. Thanks.
> 
> So I guess I'm waiting for a new version of this patch, right?

Right.

Best regards,
Tomasz

  reply	other threads:[~2013-11-26  0:32 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-19 17:10 [PATCH] pinctrl: samsung: Allow grouping multiple pinmux/pinconf nodes Tomasz Figa
2013-11-19 17:10 ` Tomasz Figa
2013-11-19 19:10 ` Stephen Warren
2013-11-19 19:10   ` Stephen Warren
2013-11-20 14:00   ` Tomasz Figa
2013-11-20 14:00     ` Tomasz Figa
2013-11-25 14:46     ` Linus Walleij
2013-11-25 14:46       ` Linus Walleij
2013-11-26  0:32       ` Tomasz Figa [this message]
2013-11-26  0:32         ` Tomasz Figa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2242006.0l244SkK9j@flatron \
    --to=tomasz.figa@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dianders@chromium.org \
    --cc=heiko@sntech.de \
    --cc=kgene.kim@samsung.com \
    --cc=kyungmin.park@samsung.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=swarren@wwwdotorg.org \
    --cc=t.figa@samsung.com \
    --cc=thomas.abraham@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.