From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Linux PM <linux-pm@vger.kernel.org>
Cc: Pratyush Yadav <ptyadav@amazon.de>,
LKML <linux-kernel@vger.kernel.org>,
Linux ACPI <linux-acpi@vger.kernel.org>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Subject: [PATCH v2 3/3] cpufreq: intel_pstate: Drop ACPI _PSS states table patching
Date: Wed, 28 Dec 2022 22:26:04 +0100 [thread overview]
Message-ID: <2269998.ElGaqSPkdT@kreacher> (raw)
In-Reply-To: <12138067.O9o76ZdvQC@kreacher>
From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
After making acpi_processor_get_platform_limit() use the "no limit"
value for its frequency QoS request when _PPC returns 0, it is not
necessary to replace the frequency corresponding to the first _PSS
return package entry with the maximum turbo frequency of the given
CPU in intel_pstate_init_acpi_perf_limits() any more, so drop the
code doing that along with the comment explaining it.
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---
v1 -> v2:
* Same as the previous [2/2], no changes.
---
drivers/cpufreq/intel_pstate.c | 14 --------------
1 file changed, 14 deletions(-)
Index: linux-pm/drivers/cpufreq/intel_pstate.c
===================================================================
--- linux-pm.orig/drivers/cpufreq/intel_pstate.c
+++ linux-pm/drivers/cpufreq/intel_pstate.c
@@ -452,20 +452,6 @@ static void intel_pstate_init_acpi_perf_
(u32) cpu->acpi_perf_data.states[i].control);
}
- /*
- * The _PSS table doesn't contain whole turbo frequency range.
- * This just contains +1 MHZ above the max non turbo frequency,
- * with control value corresponding to max turbo ratio. But
- * when cpufreq set policy is called, it will call with this
- * max frequency, which will cause a reduced performance as
- * this driver uses real max turbo frequency as the max
- * frequency. So correct this frequency in _PSS table to
- * correct max turbo frequency based on the turbo state.
- * Also need to convert to MHz as _PSS freq is in MHz.
- */
- if (!global.turbo_disabled)
- cpu->acpi_perf_data.states[0].core_frequency =
- policy->cpuinfo.max_freq / 1000;
cpu->valid_pss_table = true;
pr_debug("_PPC limits will be enforced\n");
prev parent reply other threads:[~2022-12-28 21:27 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-27 19:51 [PATCH v1 1/2] ACPI: processor: perflib: Use the "no limit" frequency QoS Rafael J. Wysocki
2022-12-27 19:52 ` [PATCH v1 2/2] cpufreq: intel_pstate: Drop ACPI _PSS states table patching Rafael J. Wysocki
2022-12-27 20:40 ` [PATCH v1 1/2] ACPI: processor: perflib: Use the "no limit" frequency QoS srinivas pandruvada
2022-12-28 20:41 ` Rafael J. Wysocki
2022-12-28 14:22 ` Pratyush Yadav
2022-12-28 21:21 ` [PATCH v2 1/3] " Rafael J. Wysocki
2022-12-29 12:58 ` Pratyush Yadav
2022-12-29 19:26 ` Rafael J. Wysocki
2023-01-30 14:17 ` Pratyush Yadav
2023-01-30 14:58 ` Rafael J. Wysocki
2023-01-30 15:23 ` Pratyush Yadav
2023-02-14 13:40 ` srinivas pandruvada
2023-02-14 13:57 ` Rafael J. Wysocki
2023-02-14 14:25 ` srinivas pandruvada
2023-02-14 14:41 ` Rafael J. Wysocki
2022-12-28 21:24 ` [PATCH v2 2/3] ACPI: processor: perflib: Avoid updating frequency QoS unnecessarily Rafael J. Wysocki
2022-12-28 21:26 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2269998.ElGaqSPkdT@kreacher \
--to=rjw@rjwysocki.net \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=ptyadav@amazon.de \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.