From: Pratyush Yadav <ptyadav@amazon.de>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Linux PM <linux-pm@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Linux ACPI <linux-acpi@vger.kernel.org>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Subject: Re: [PATCH v1 1/2] ACPI: processor: perflib: Use the "no limit" frequency QoS
Date: Wed, 28 Dec 2022 15:22:33 +0100 [thread overview]
Message-ID: <mafs0zgb7boba.fsf@amazon.de> (raw)
In-Reply-To: <12138067.O9o76ZdvQC@kreacher> (Rafael J. Wysocki's message of "Tue, 27 Dec 2022 20:51:43 +0100")
On Tue, Dec 27 2022, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>
> When _PPC returns 0, it means that the CPU frequency is not limited by
> the platform firmware, so make acpi_processor_get_platform_limit()
> update the frequency QoS request used by it to "no limit" in that case
> and avoid updating the QoS request when the _PPC return value has not
> changed.
>
> This addresses a problem with limiting CPU frequency artificially on
> some systems after CPU offline/online to the frequency that corresponds
> to the first entry in the _PSS return package.
>
> While at it, move the _PPC return value check against the state count
> earlier to avoid setting performance_platform_limit to an invalid value.
>
> Reported-by: Pratyush Yadav <ptyadav@amazon.de>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Tested-by: Pratyush Yadav <ptyadav@amazon.de>
--
Regards,
Pratyush Yadav
Amazon Development Center Germany GmbH
Krausenstr. 38
10117 Berlin
Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss
Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B
Sitz: Berlin
Ust-ID: DE 289 237 879
next prev parent reply other threads:[~2022-12-28 14:22 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-27 19:51 [PATCH v1 1/2] ACPI: processor: perflib: Use the "no limit" frequency QoS Rafael J. Wysocki
2022-12-27 19:52 ` [PATCH v1 2/2] cpufreq: intel_pstate: Drop ACPI _PSS states table patching Rafael J. Wysocki
2022-12-27 20:40 ` [PATCH v1 1/2] ACPI: processor: perflib: Use the "no limit" frequency QoS srinivas pandruvada
2022-12-28 20:41 ` Rafael J. Wysocki
2022-12-28 14:22 ` Pratyush Yadav [this message]
2022-12-28 21:21 ` [PATCH v2 1/3] " Rafael J. Wysocki
2022-12-29 12:58 ` Pratyush Yadav
2022-12-29 19:26 ` Rafael J. Wysocki
2023-01-30 14:17 ` Pratyush Yadav
2023-01-30 14:58 ` Rafael J. Wysocki
2023-01-30 15:23 ` Pratyush Yadav
2023-02-14 13:40 ` srinivas pandruvada
2023-02-14 13:57 ` Rafael J. Wysocki
2023-02-14 14:25 ` srinivas pandruvada
2023-02-14 14:41 ` Rafael J. Wysocki
2022-12-28 21:24 ` [PATCH v2 2/3] ACPI: processor: perflib: Avoid updating frequency QoS unnecessarily Rafael J. Wysocki
2022-12-28 21:26 ` [PATCH v2 3/3] cpufreq: intel_pstate: Drop ACPI _PSS states table patching Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mafs0zgb7boba.fsf@amazon.de \
--to=ptyadav@amazon.de \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.