From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Mark Brown <broonie@kernel.org>,
linux-spi <linux-spi@vger.kernel.org>,
Linux-sh list <linux-sh@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Geert Uytterhoeven <geert+renesas@linux-m68k.org>,
Magnus Damm <magnus.damm@gmail.com>
Subject: Re: [PATCH 2/3] spi: sh-msiof: Convert to spi core auto_runtime_pm framework
Date: Tue, 11 Mar 2014 16:32:26 +0000 [thread overview]
Message-ID: <2274545.CyQ67zvVqo@avalon> (raw)
In-Reply-To: <CAMuHMdVOUuFsObEag_MwUT_jaqfOHMEcUScrkbaTEitmyJr+NQ@mail.gmail.com>
On Tuesday 11 March 2014 17:23:37 Geert Uytterhoeven wrote:
> Hi Laurent,
>
> On Tue, Mar 11, 2014 at 4:55 PM, Laurent Pinchart wrote:
> > Does this require drivers/sh/pm_runtime.c to be compiled in ?
>
> Let's check...
>
> My koelsch-legacy kernel has drivers/sh/pm_runtime.c compiled in.
> My koelsch-reference kernel hasn't.
>
> However, under the -reference kernel many MSTP clocks (incl. MSIOF)
> seem to be enabled all the time, while under -legacy they are enabled and
> disabled on demand.
Is PM_RUNTIME enabled in both cases ?
There's something fishy in there that we should try to fix without too further
much delay. Ben Dooks has pointed out the problem a couple of months ago, but
the discussion on the mailing list just died.
--
Regards,
Laurent Pinchart
WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Mark Brown <broonie@kernel.org>,
linux-spi <linux-spi@vger.kernel.org>,
Linux-sh list <linux-sh@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Geert Uytterhoeven <geert+renesas@linux-m68k.org>,
Magnus Damm <magnus.damm@gmail.com>
Subject: Re: [PATCH 2/3] spi: sh-msiof: Convert to spi core auto_runtime_pm framework
Date: Tue, 11 Mar 2014 17:32:26 +0100 [thread overview]
Message-ID: <2274545.CyQ67zvVqo@avalon> (raw)
In-Reply-To: <CAMuHMdVOUuFsObEag_MwUT_jaqfOHMEcUScrkbaTEitmyJr+NQ@mail.gmail.com>
On Tuesday 11 March 2014 17:23:37 Geert Uytterhoeven wrote:
> Hi Laurent,
>
> On Tue, Mar 11, 2014 at 4:55 PM, Laurent Pinchart wrote:
> > Does this require drivers/sh/pm_runtime.c to be compiled in ?
>
> Let's check...
>
> My koelsch-legacy kernel has drivers/sh/pm_runtime.c compiled in.
> My koelsch-reference kernel hasn't.
>
> However, under the -reference kernel many MSTP clocks (incl. MSIOF)
> seem to be enabled all the time, while under -legacy they are enabled and
> disabled on demand.
Is PM_RUNTIME enabled in both cases ?
There's something fishy in there that we should try to fix without too further
much delay. Ben Dooks has pointed out the problem a couple of months ago, but
the discussion on the mailing list just died.
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2014-03-11 16:32 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-11 9:59 [PATCH 1/3] spi: sh-hspi: Add missing call to pm_runtime_disable() in failure path Geert Uytterhoeven
2014-03-11 9:59 ` Geert Uytterhoeven
2014-03-11 9:59 ` [PATCH 2/3] spi: sh-msiof: Convert to spi core auto_runtime_pm framework Geert Uytterhoeven
2014-03-11 9:59 ` Geert Uytterhoeven
[not found] ` <1394531952-3905-2-git-send-email-geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>
2014-03-11 10:45 ` Mark Brown
2014-03-11 10:45 ` Mark Brown
2014-03-11 10:45 ` Mark Brown
2014-03-11 15:55 ` Laurent Pinchart
2014-03-11 15:55 ` Laurent Pinchart
2014-03-11 15:55 ` Laurent Pinchart
2014-03-11 16:23 ` Geert Uytterhoeven
2014-03-11 16:23 ` Geert Uytterhoeven
2014-03-11 16:23 ` Geert Uytterhoeven
2014-03-11 16:32 ` Laurent Pinchart [this message]
2014-03-11 16:32 ` Laurent Pinchart
2014-03-11 17:44 ` Geert Uytterhoeven
2014-03-11 17:44 ` Geert Uytterhoeven
[not found] ` <CAMuHMdXEOygh0--niiLcXFgnRNPi_b0EGPKVBg2Q6Ws01YmNjw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-03-11 17:57 ` Laurent Pinchart
2014-03-11 17:57 ` Laurent Pinchart
2014-03-11 17:57 ` Laurent Pinchart
2014-03-12 1:23 ` Magnus Damm
2014-03-12 1:23 ` Magnus Damm
2014-03-12 1:23 ` Magnus Damm
[not found] ` <CANqRtoRR9Q8Q=ACqhnLBpTavn0K5cD1=dBkjkfZ8kb+H68GuOw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-03-12 11:26 ` Laurent Pinchart
2014-03-12 11:26 ` Laurent Pinchart
2014-03-12 11:26 ` Laurent Pinchart
2014-03-12 11:28 ` Magnus Damm
2014-03-12 11:28 ` Magnus Damm
2014-03-12 11:28 ` Magnus Damm
[not found] ` <1394531952-3905-1-git-send-email-geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>
2014-03-11 9:59 ` [PATCH 3/3] spi: rspi: Add runtime PM support, using spi core auto_runtime_pm Geert Uytterhoeven
2014-03-11 9:59 ` Geert Uytterhoeven
2014-03-11 9:59 ` Geert Uytterhoeven
2014-03-11 10:47 ` Mark Brown
2014-03-11 13:10 ` Geert Uytterhoeven
2014-03-11 13:10 ` Geert Uytterhoeven
2014-03-11 13:26 ` Mark Brown
2014-03-11 13:35 ` Geert Uytterhoeven
2014-03-11 13:35 ` Geert Uytterhoeven
2014-03-11 14:18 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2274545.CyQ67zvVqo@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=broonie@kernel.org \
--cc=geert+renesas@linux-m68k.org \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=magnus.damm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.