Re: [drm-intel:drm-intel-nightly 243/249] undefined reference to `drm_agp_clear'

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

Hi David,

On Wednesday 07 August 2013 11:57:54 David Herrmann wrote:
> On Wed, Aug 7, 2013 at 10:19 AM, kbuild test robot wrote:
> > tree:   git://people.freedesktop.org/~danvet/drm-intel.git
> > drm-intel-nightly head:   3224cf6c3ee5ab9c280052c9fbed4f660310c411
> > commit: 28ec711cd427f8b61f73712a43b8100ba8ca933b [243/249] drm/agp: move
> > AGP cleanup paths to drm_agpsupport.c config: x86_64-randconfig-a02-0807
> > (attached as .config)
> > 
> > All error/warnings:
> >    drivers/built-in.o: In function `drm_lastclose':
> >>> (.text+0x904a0): undefined reference to `drm_agp_clear'
> 
> We called drm_agp_release() in the same code-path before. How did that
> work without CONFIG_AGP? Ugh, *confused*

drm_agp_release() was only called if drm_core_has_AGP() was true, and that 
function is defined as a macro that just returns 0 when __OS_HAS_AGP isn't 
defined. The compiler thus optimized the drm_agp_release() call away.

-- 
Regards,

Laurent Pinchart