* Re: [drm-intel:drm-intel-nightly 243/249] undefined reference to `drm_agp_clear'
[not found] <5202032e.Bh5xEyiO9yK+nGxr%fengguang.wu@intel.com>
@ 2013-08-07 9:57 ` David Herrmann
2013-08-07 11:16 ` Laurent Pinchart
0 siblings, 1 reply; 2+ messages in thread
From: David Herrmann @ 2013-08-07 9:57 UTC (permalink / raw)
To: kbuild test robot, dri-devel@lists.freedesktop.org
Cc: Dave Airlie, kbuild-all
Hi
On Wed, Aug 7, 2013 at 10:19 AM, kbuild test robot
<fengguang.wu@intel.com> wrote:
> tree: git://people.freedesktop.org/~danvet/drm-intel.git drm-intel-nightly
> head: 3224cf6c3ee5ab9c280052c9fbed4f660310c411
> commit: 28ec711cd427f8b61f73712a43b8100ba8ca933b [243/249] drm/agp: move AGP cleanup paths to drm_agpsupport.c
> config: x86_64-randconfig-a02-0807 (attached as .config)
>
> All error/warnings:
>
> drivers/built-in.o: In function `drm_lastclose':
>>> (.text+0x904a0): undefined reference to `drm_agp_clear'
We called drm_agp_release() in the same code-path before. How did that
work without CONFIG_AGP? Ugh, *confused*
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [drm-intel:drm-intel-nightly 243/249] undefined reference to `drm_agp_clear'
2013-08-07 9:57 ` [drm-intel:drm-intel-nightly 243/249] undefined reference to `drm_agp_clear' David Herrmann
@ 2013-08-07 11:16 ` Laurent Pinchart
0 siblings, 0 replies; 2+ messages in thread
From: Laurent Pinchart @ 2013-08-07 11:16 UTC (permalink / raw)
To: dri-devel; +Cc: Dave Airlie, kbuild test robot, kbuild-all
Hi David,
On Wednesday 07 August 2013 11:57:54 David Herrmann wrote:
> On Wed, Aug 7, 2013 at 10:19 AM, kbuild test robot wrote:
> > tree: git://people.freedesktop.org/~danvet/drm-intel.git
> > drm-intel-nightly head: 3224cf6c3ee5ab9c280052c9fbed4f660310c411
> > commit: 28ec711cd427f8b61f73712a43b8100ba8ca933b [243/249] drm/agp: move
> > AGP cleanup paths to drm_agpsupport.c config: x86_64-randconfig-a02-0807
> > (attached as .config)
> >
> > All error/warnings:
> > drivers/built-in.o: In function `drm_lastclose':
> >>> (.text+0x904a0): undefined reference to `drm_agp_clear'
>
> We called drm_agp_release() in the same code-path before. How did that
> work without CONFIG_AGP? Ugh, *confused*
drm_agp_release() was only called if drm_core_has_AGP() was true, and that
function is defined as a macro that just returns 0 when __OS_HAS_AGP isn't
defined. The compiler thus optimized the drm_agp_release() call away.
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-08-07 11:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <5202032e.Bh5xEyiO9yK+nGxr%fengguang.wu@intel.com>
2013-08-07 9:57 ` [drm-intel:drm-intel-nightly 243/249] undefined reference to `drm_agp_clear' David Herrmann
2013-08-07 11:16 ` Laurent Pinchart
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.