All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Alex Elder <elder@riscstar.com>,
	robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
	lpieralisi@kernel.org, kwilczynski@kernel.org, mani@kernel.org,
	bhelgaas@google.com, vkoul@kernel.org, kishon@kernel.org
Cc: dlan@gentoo.org, paul.walmsley@sifive.com, palmer@dabbelt.com,
	aou@eecs.berkeley.edu, alex@ghiti.fr, p.zabel@pengutronix.de,
	tglx@linutronix.de, johan+linaro@kernel.org,
	thippeswamy.havalige@amd.com, namcao@linutronix.de,
	mayank.rana@oss.qualcomm.com, shradha.t@samsung.com,
	inochiama@gmail.com, quic_schintav@quicinc.com,
	fan.ni@samsung.com, devicetree@vger.kernel.org,
	linux-phy@lists.infradead.org, linux-pci@vger.kernel.org,
	spacemit@lists.linux.dev, linux-riscv@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/6] dt-bindings: phy: spacemit: add SpacemiT PCIe/combo PHY
Date: Thu, 14 Aug 2025 08:11:24 +0200	[thread overview]
Message-ID: <22bd5b5b-ca06-4499-b21f-22c2ff202167@kernel.org> (raw)
In-Reply-To: <20250813184701.2444372-2-elder@riscstar.com>

On 13/08/2025 20:46, Alex Elder wrote:
> +                      "mstr",
> +                      "slv",
> +                      "global";
> +        spacemit,syscon-pmu = <&syscon_apmu>;
> +        #phy-cells = <1>;
> +        status = "disabled";

You cannot have disabled examples. This also means it could not be
checked/tested.

> +    };


Best regards,
Krzysztof

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Alex Elder <elder@riscstar.com>,
	robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
	lpieralisi@kernel.org, kwilczynski@kernel.org, mani@kernel.org,
	bhelgaas@google.com, vkoul@kernel.org, kishon@kernel.org
Cc: dlan@gentoo.org, paul.walmsley@sifive.com, palmer@dabbelt.com,
	aou@eecs.berkeley.edu, alex@ghiti.fr, p.zabel@pengutronix.de,
	tglx@linutronix.de, johan+linaro@kernel.org,
	thippeswamy.havalige@amd.com, namcao@linutronix.de,
	mayank.rana@oss.qualcomm.com, shradha.t@samsung.com,
	inochiama@gmail.com, quic_schintav@quicinc.com,
	fan.ni@samsung.com, devicetree@vger.kernel.org,
	linux-phy@lists.infradead.org, linux-pci@vger.kernel.org,
	spacemit@lists.linux.dev, linux-riscv@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/6] dt-bindings: phy: spacemit: add SpacemiT PCIe/combo PHY
Date: Thu, 14 Aug 2025 08:11:24 +0200	[thread overview]
Message-ID: <22bd5b5b-ca06-4499-b21f-22c2ff202167@kernel.org> (raw)
In-Reply-To: <20250813184701.2444372-2-elder@riscstar.com>

On 13/08/2025 20:46, Alex Elder wrote:
> +                      "mstr",
> +                      "slv",
> +                      "global";
> +        spacemit,syscon-pmu = <&syscon_apmu>;
> +        #phy-cells = <1>;
> +        status = "disabled";

You cannot have disabled examples. This also means it could not be
checked/tested.

> +    };


Best regards,
Krzysztof

WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Alex Elder <elder@riscstar.com>,
	robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
	lpieralisi@kernel.org, kwilczynski@kernel.org, mani@kernel.org,
	bhelgaas@google.com, vkoul@kernel.org, kishon@kernel.org
Cc: dlan@gentoo.org, paul.walmsley@sifive.com, palmer@dabbelt.com,
	aou@eecs.berkeley.edu, alex@ghiti.fr, p.zabel@pengutronix.de,
	tglx@linutronix.de, johan+linaro@kernel.org,
	thippeswamy.havalige@amd.com, namcao@linutronix.de,
	mayank.rana@oss.qualcomm.com, shradha.t@samsung.com,
	inochiama@gmail.com, quic_schintav@quicinc.com,
	fan.ni@samsung.com, devicetree@vger.kernel.org,
	linux-phy@lists.infradead.org, linux-pci@vger.kernel.org,
	spacemit@lists.linux.dev, linux-riscv@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/6] dt-bindings: phy: spacemit: add SpacemiT PCIe/combo PHY
Date: Thu, 14 Aug 2025 08:11:24 +0200	[thread overview]
Message-ID: <22bd5b5b-ca06-4499-b21f-22c2ff202167@kernel.org> (raw)
In-Reply-To: <20250813184701.2444372-2-elder@riscstar.com>

On 13/08/2025 20:46, Alex Elder wrote:
> +                      "mstr",
> +                      "slv",
> +                      "global";
> +        spacemit,syscon-pmu = <&syscon_apmu>;
> +        #phy-cells = <1>;
> +        status = "disabled";

You cannot have disabled examples. This also means it could not be
checked/tested.

> +    };


Best regards,
Krzysztof

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  parent reply	other threads:[~2025-08-14  6:11 UTC|newest]

Thread overview: 93+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-13 18:46 [PATCH 0/6] Introduce SpacemiT K1 PCIe phy and host controller Alex Elder
2025-08-13 18:46 ` Alex Elder
2025-08-13 18:46 ` Alex Elder
2025-08-13 18:46 ` [PATCH 1/6] dt-bindings: phy: spacemit: add SpacemiT PCIe/combo PHY Alex Elder
2025-08-13 18:46   ` Alex Elder
2025-08-13 18:46   ` Alex Elder
2025-08-14  2:52   ` Yao Zi
2025-08-14  2:52     ` Yao Zi
2025-08-14  2:52     ` Yao Zi
2025-08-14 12:30     ` Alex Elder
2025-08-14 12:30       ` Alex Elder
2025-08-14 12:30       ` Alex Elder
2025-08-14  6:11   ` Krzysztof Kozlowski [this message]
2025-08-14  6:11     ` Krzysztof Kozlowski
2025-08-14  6:11     ` Krzysztof Kozlowski
2025-08-14 11:59     ` Alex Elder
2025-08-14 11:59       ` Alex Elder
2025-08-14 11:59       ` Alex Elder
2025-08-14 20:51   ` Rob Herring
2025-08-14 20:51     ` Rob Herring
2025-08-14 20:51     ` Rob Herring
2025-08-14 21:48     ` Alex Elder
2025-08-14 21:48       ` Alex Elder
2025-08-14 21:48       ` Alex Elder
2025-08-13 18:46 ` [PATCH 2/6] dt-bindings: phy: spacemit: introduce PCIe PHY Alex Elder
2025-08-13 18:46   ` Alex Elder
2025-08-13 18:46   ` Alex Elder
2025-08-14  6:17   ` Krzysztof Kozlowski
2025-08-14  6:17     ` Krzysztof Kozlowski
2025-08-14  6:17     ` Krzysztof Kozlowski
2025-08-13 18:46 ` [PATCH 3/6] dt-bindings: phy: spacemit: introduce PCIe root complex Alex Elder
2025-08-13 18:46   ` Alex Elder
2025-08-13 18:46   ` Alex Elder
2025-08-13 20:49   ` Rob Herring (Arm)
2025-08-13 20:49     ` Rob Herring (Arm)
2025-08-13 20:49     ` Rob Herring (Arm)
2025-08-13 21:21     ` Alex Elder
2025-08-13 21:21       ` Alex Elder
2025-08-13 21:21       ` Alex Elder
2025-09-15  8:14   ` Manivannan Sadhasivam
2025-09-15  8:14     ` Manivannan Sadhasivam
2025-09-15  8:14     ` Manivannan Sadhasivam
2025-09-19 20:14     ` Alex Elder
2025-09-19 20:14       ` Alex Elder
2025-09-19 20:14       ` Alex Elder
2025-09-20  5:55       ` Manivannan Sadhasivam
2025-09-20  5:55         ` Manivannan Sadhasivam
2025-09-20  5:55         ` Manivannan Sadhasivam
2025-10-01  2:40         ` Alex Elder
2025-10-01  2:40           ` Alex Elder
2025-10-01  2:40           ` Alex Elder
2025-08-13 18:46 ` [PATCH 4/6] phy: spacemit: introduce PCIe/combo PHY Alex Elder
2025-08-13 18:46   ` Alex Elder
2025-08-13 18:46   ` Alex Elder
2025-08-13 23:42   ` Inochi Amaoto
2025-08-13 23:42     ` Inochi Amaoto
2025-08-13 23:42     ` Inochi Amaoto
2025-08-14 12:15     ` Alex Elder
2025-08-14 12:15       ` Alex Elder
2025-08-14 12:15       ` Alex Elder
2025-08-14 22:49       ` Inochi Amaoto
2025-08-14 22:49         ` Inochi Amaoto
2025-08-14 22:49         ` Inochi Amaoto
2025-08-14 23:57       ` Yixun Lan
2025-08-14 23:57         ` Yixun Lan
2025-08-14 23:57         ` Yixun Lan
2025-08-13 18:46 ` [PATCH 5/6] PCI: spacemit: introduce SpacemiT PCIe host driver Alex Elder
2025-08-13 18:46   ` Alex Elder
2025-08-13 18:46   ` Alex Elder
2025-08-13 21:22   ` Bjorn Helgaas
2025-08-13 21:22     ` Bjorn Helgaas
2025-08-13 21:22     ` Bjorn Helgaas
2025-08-13 21:27     ` Alex Elder
2025-08-13 21:27       ` Alex Elder
2025-08-13 21:27       ` Alex Elder
2025-09-19 18:06       ` Alex Elder
2025-09-19 18:06         ` Alex Elder
2025-09-19 18:06         ` Alex Elder
2025-09-15  8:09   ` Manivannan Sadhasivam
2025-09-15  8:09     ` Manivannan Sadhasivam
2025-09-15  8:09     ` Manivannan Sadhasivam
2025-09-19 22:10     ` Alex Elder
2025-09-19 22:10       ` Alex Elder
2025-09-19 22:10       ` Alex Elder
2025-09-20  5:33       ` Manivannan Sadhasivam
2025-09-20  5:33         ` Manivannan Sadhasivam
2025-09-20  5:33         ` Manivannan Sadhasivam
2025-10-01  2:40       ` Alex Elder
2025-10-01  2:40         ` Alex Elder
2025-10-01  2:40         ` Alex Elder
2025-08-13 18:47 ` [PATCH 6/6] riscv: dts: spacemit: PCIe and PHY-related updates Alex Elder
2025-08-13 18:47   ` Alex Elder
2025-08-13 18:47   ` Alex Elder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=22bd5b5b-ca06-4499-b21f-22c2ff202167@kernel.org \
    --to=krzk@kernel.org \
    --cc=alex@ghiti.fr \
    --cc=aou@eecs.berkeley.edu \
    --cc=bhelgaas@google.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dlan@gentoo.org \
    --cc=elder@riscstar.com \
    --cc=fan.ni@samsung.com \
    --cc=inochiama@gmail.com \
    --cc=johan+linaro@kernel.org \
    --cc=kishon@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=kwilczynski@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=lpieralisi@kernel.org \
    --cc=mani@kernel.org \
    --cc=mayank.rana@oss.qualcomm.com \
    --cc=namcao@linutronix.de \
    --cc=p.zabel@pengutronix.de \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    --cc=quic_schintav@quicinc.com \
    --cc=robh@kernel.org \
    --cc=shradha.t@samsung.com \
    --cc=spacemit@lists.linux.dev \
    --cc=tglx@linutronix.de \
    --cc=thippeswamy.havalige@amd.com \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.