All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laszlo Ersek <lersek@redhat.com>
To: Auger Eric <eric.auger@redhat.com>,
	eric.auger.pro@gmail.com, qemu-devel@nongnu.org,
	qemu-arm@nongnu.org, peter.maydell@linaro.org
Cc: drjones@redhat.com, zhaoshenglong@huawei.com, ard.biesheuvel@linaro.org
Subject: Re: [Qemu-arm] [Qemu-devel] [RFC 0/2] ARM virt: Support up to 256 PCIe buses
Date: Wed, 23 May 2018 22:52:34 +0200	[thread overview]
Message-ID: <22c4e504-a7b4-e6dd-b2cc-618d306b6f0c@redhat.com> (raw)
In-Reply-To: <bf99311a-823d-34e8-1892-be27534afc32@redhat.com>

On 05/23/18 22:40, Auger Eric wrote:
> On 05/23/2018 07:45 PM, Laszlo Ersek wrote:

>> Regarding the second patch, I do believe we need "more sophistication"
>> there. For example, I guess it could be possible to distinguish "-cpu
>> cortex-a15" from "-cpu cortex-a57" somehow, and stick with the low/small
>> ECAM in the former case. (The 32-bit firmware already runs on cortex-a15
>> only, and not on cortex-a57, according to my testing.)
> 
> So we should detect we are in ACPI boot  + aarch32 mode to force legacy
> ECAM region, right?

Agree about the aarch32 subcondition.

However, "ACPI vs. DT" is not the right "other" subcondition here;
instead we should (minimally) check "firmware vs. no firmware". See the
"firmware_loaded" boolean field.

I also suggest waiting for feedback from others! :)

Thanks,
Laszlo

WARNING: multiple messages have this Message-ID (diff)
From: Laszlo Ersek <lersek@redhat.com>
To: Auger Eric <eric.auger@redhat.com>,
	eric.auger.pro@gmail.com, qemu-devel@nongnu.org,
	qemu-arm@nongnu.org, peter.maydell@linaro.org
Cc: wei@redhat.com, drjones@redhat.com, ard.biesheuvel@linaro.org,
	zhaoshenglong@huawei.com
Subject: Re: [Qemu-devel] [RFC 0/2] ARM virt: Support up to 256 PCIe buses
Date: Wed, 23 May 2018 22:52:34 +0200	[thread overview]
Message-ID: <22c4e504-a7b4-e6dd-b2cc-618d306b6f0c@redhat.com> (raw)
In-Reply-To: <bf99311a-823d-34e8-1892-be27534afc32@redhat.com>

On 05/23/18 22:40, Auger Eric wrote:
> On 05/23/2018 07:45 PM, Laszlo Ersek wrote:

>> Regarding the second patch, I do believe we need "more sophistication"
>> there. For example, I guess it could be possible to distinguish "-cpu
>> cortex-a15" from "-cpu cortex-a57" somehow, and stick with the low/small
>> ECAM in the former case. (The 32-bit firmware already runs on cortex-a15
>> only, and not on cortex-a57, according to my testing.)
> 
> So we should detect we are in ACPI boot  + aarch32 mode to force legacy
> ECAM region, right?

Agree about the aarch32 subcondition.

However, "ACPI vs. DT" is not the right "other" subcondition here;
instead we should (minimally) check "firmware vs. no firmware". See the
"firmware_loaded" boolean field.

I also suggest waiting for feedback from others! :)

Thanks,
Laszlo

  reply	other threads:[~2018-05-23 20:52 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-23 16:03 [Qemu-arm] [RFC 0/2] ARM virt: Support up to 256 PCIe buses Eric Auger
2018-05-23 16:03 ` [Qemu-devel] " Eric Auger
2018-05-23 16:03 ` [Qemu-arm] [RFC 1/2] hw/arm/virt: Add a new 256MB ECAM region Eric Auger
2018-05-23 16:03   ` [Qemu-devel] " Eric Auger
2018-05-23 16:03 ` [Qemu-arm] [RFC 2/2] hw/arm/virt: Add virt-3.0 machine type Eric Auger
2018-05-23 16:03   ` [Qemu-devel] " Eric Auger
2018-05-23 17:45 ` [Qemu-arm] [RFC 0/2] ARM virt: Support up to 256 PCIe buses Laszlo Ersek
2018-05-23 17:45   ` [Qemu-devel] " Laszlo Ersek
2018-05-23 20:40   ` [Qemu-arm] " Auger Eric
2018-05-23 20:40     ` Auger Eric
2018-05-23 20:52     ` Laszlo Ersek [this message]
2018-05-23 20:52       ` Laszlo Ersek
2018-05-23 20:55       ` [Qemu-arm] " Auger Eric
2018-05-23 20:55         ` Auger Eric
2018-05-24  9:11       ` [Qemu-arm] " Peter Maydell
2018-05-24  9:11         ` Peter Maydell
2018-05-24 12:59         ` [Qemu-arm] " Laszlo Ersek
2018-05-24 12:59           ` Laszlo Ersek
2018-05-24 13:07           ` [Qemu-arm] " Peter Maydell
2018-05-24 13:07             ` Peter Maydell
2018-05-24 13:10             ` [Qemu-arm] " Auger Eric
2018-05-24 13:10               ` Auger Eric
2018-05-24 13:59             ` [Qemu-arm] " Laszlo Ersek
2018-05-24 13:59               ` Laszlo Ersek
2018-05-24 14:09               ` [Qemu-arm] " Auger Eric
2018-05-24 14:09                 ` Auger Eric
2018-05-24 16:58                 ` [Qemu-arm] " Laszlo Ersek
2018-05-24 16:58                   ` Laszlo Ersek
2018-05-24 14:14               ` [Qemu-arm] " Ard Biesheuvel
2018-05-24 14:14                 ` Ard Biesheuvel
2018-05-24 17:20                 ` [Qemu-arm] " Laszlo Ersek
2018-05-24 17:20                   ` Laszlo Ersek
2018-05-24 19:26                   ` [Qemu-arm] " Auger Eric
2018-05-24 19:26                     ` Auger Eric

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=22c4e504-a7b4-e6dd-b2cc-618d306b6f0c@redhat.com \
    --to=lersek@redhat.com \
    --cc=ard.biesheuvel@linaro.org \
    --cc=drjones@redhat.com \
    --cc=eric.auger.pro@gmail.com \
    --cc=eric.auger@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=zhaoshenglong@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.