From: "Heiko Stübner" <heiko@sntech.de>
To: Andy Yan <andyshrk@163.com>
Cc: hjc@rock-chips.com, dri-devel@lists.freedesktop.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org,
devicetree@vger.kernel.org, sebastian.reichel@collabora.com,
kever.yang@rock-chips.com, chris.obbard@collabora.com,
s.hauer@pengutronix.de, Andy Yan <andy.yan@rock-chips.com>
Subject: Re: [PATCH v2 03/12] drm/rockchip: vop2: set half_block_en bit in all mode
Date: Mon, 27 Nov 2023 16:01:22 +0100 [thread overview]
Message-ID: <23093643.0c2gjJ1VT2@diego> (raw)
In-Reply-To: <20231122125413.3454489-1-andyshrk@163.com>
Am Mittwoch, 22. November 2023, 13:54:13 CET schrieb Andy Yan:
> From: Andy Yan <andy.yan@rock-chips.com>
>
> At first we thought the half_block_en bit in AFBCD_CTRL register
> only work in afbc mode. But the fact is that it control the line
> buffer in all mode(afbc/tile/line), so we need configure it in
> all case.
>
> Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
This looks common to the rk3568 variant, right, so I guess this should
have a
Fixes: 604be85547ce ("drm/rockchip: Add VOP2 driver")
perhaps?
Heiko
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: "Heiko Stübner" <heiko@sntech.de>
To: Andy Yan <andyshrk@163.com>
Cc: hjc@rock-chips.com, dri-devel@lists.freedesktop.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org,
devicetree@vger.kernel.org, sebastian.reichel@collabora.com,
kever.yang@rock-chips.com, chris.obbard@collabora.com,
s.hauer@pengutronix.de, Andy Yan <andy.yan@rock-chips.com>
Subject: Re: [PATCH v2 03/12] drm/rockchip: vop2: set half_block_en bit in all mode
Date: Mon, 27 Nov 2023 16:01:22 +0100 [thread overview]
Message-ID: <23093643.0c2gjJ1VT2@diego> (raw)
In-Reply-To: <20231122125413.3454489-1-andyshrk@163.com>
Am Mittwoch, 22. November 2023, 13:54:13 CET schrieb Andy Yan:
> From: Andy Yan <andy.yan@rock-chips.com>
>
> At first we thought the half_block_en bit in AFBCD_CTRL register
> only work in afbc mode. But the fact is that it control the line
> buffer in all mode(afbc/tile/line), so we need configure it in
> all case.
>
> Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
This looks common to the rk3568 variant, right, so I guess this should
have a
Fixes: 604be85547ce ("drm/rockchip: Add VOP2 driver")
perhaps?
Heiko
WARNING: multiple messages have this Message-ID (diff)
From: "Heiko Stübner" <heiko@sntech.de>
To: Andy Yan <andyshrk@163.com>
Cc: devicetree@vger.kernel.org, s.hauer@pengutronix.de,
chris.obbard@collabora.com, hjc@rock-chips.com,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
kever.yang@rock-chips.com, linux-rockchip@lists.infradead.org,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
Andy Yan <andy.yan@rock-chips.com>,
sebastian.reichel@collabora.com
Subject: Re: [PATCH v2 03/12] drm/rockchip: vop2: set half_block_en bit in all mode
Date: Mon, 27 Nov 2023 16:01:22 +0100 [thread overview]
Message-ID: <23093643.0c2gjJ1VT2@diego> (raw)
In-Reply-To: <20231122125413.3454489-1-andyshrk@163.com>
Am Mittwoch, 22. November 2023, 13:54:13 CET schrieb Andy Yan:
> From: Andy Yan <andy.yan@rock-chips.com>
>
> At first we thought the half_block_en bit in AFBCD_CTRL register
> only work in afbc mode. But the fact is that it control the line
> buffer in all mode(afbc/tile/line), so we need configure it in
> all case.
>
> Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
This looks common to the rk3568 variant, right, so I guess this should
have a
Fixes: 604be85547ce ("drm/rockchip: Add VOP2 driver")
perhaps?
Heiko
next prev parent reply other threads:[~2023-11-27 15:01 UTC|newest]
Thread overview: 118+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-22 12:53 [PATCH v2 00/12] Add VOP2 support on rk3588 Andy Yan
2023-11-22 12:53 ` Andy Yan
2023-11-22 12:53 ` Andy Yan
2023-11-22 12:53 ` [PATCH v2 01/12] drm/rockchip: move output interface related definition to rockchip_drm_drv.h Andy Yan
2023-11-22 12:53 ` Andy Yan
2023-11-22 12:53 ` Andy Yan
2023-11-27 14:03 ` Sascha Hauer
2023-11-27 14:03 ` Sascha Hauer
2023-11-27 14:03 ` Sascha Hauer
2023-11-22 12:54 ` [PATCH v2 02/12] Revert "drm/rockchip: vop2: Use regcache_sync() to fix suspend/resume" Andy Yan
2023-11-22 12:54 ` Andy Yan
2023-11-22 12:54 ` Andy Yan
2023-11-27 14:04 ` Sascha Hauer
2023-11-27 14:04 ` Sascha Hauer
2023-11-27 14:04 ` Sascha Hauer
2023-11-22 12:54 ` [PATCH v2 03/12] drm/rockchip: vop2: set half_block_en bit in all mode Andy Yan
2023-11-22 12:54 ` Andy Yan
2023-11-22 12:54 ` Andy Yan
2023-11-27 14:04 ` Sascha Hauer
2023-11-27 14:04 ` Sascha Hauer
2023-11-27 14:04 ` Sascha Hauer
2023-11-27 15:01 ` Heiko Stübner [this message]
2023-11-27 15:01 ` Heiko Stübner
2023-11-27 15:01 ` Heiko Stübner
2023-11-22 12:54 ` [PATCH v2 04/12] drm/rockchip: vop2: clear afbc en and transform bit for cluster window at linear mode Andy Yan
2023-11-22 12:54 ` Andy Yan
2023-11-22 12:54 ` Andy Yan
2023-11-27 14:04 ` Sascha Hauer
2023-11-27 14:04 ` Sascha Hauer
2023-11-27 14:04 ` Sascha Hauer
2023-11-27 15:02 ` Heiko Stübner
2023-11-27 15:02 ` Heiko Stübner
2023-11-27 15:02 ` Heiko Stübner
2023-11-28 8:03 ` Andy Yan
2023-11-28 8:03 ` Andy Yan
2023-11-28 8:03 ` Andy Yan
2023-11-28 8:30 ` Heiko Stübner
2023-11-28 8:30 ` Heiko Stübner
2023-11-28 8:30 ` Heiko Stübner
2023-11-28 9:44 ` Andy Yan
2023-11-28 9:44 ` Andy Yan
2023-11-28 9:44 ` Andy Yan
2023-11-22 12:54 ` [PATCH v2 05/12] drm/rockchip: vop2: Set YUV/RGB overlay mode Andy Yan
2023-11-22 12:54 ` Andy Yan
2023-11-22 12:54 ` Andy Yan
2023-11-27 14:16 ` Sascha Hauer
2023-11-27 14:16 ` Sascha Hauer
2023-11-27 14:16 ` Sascha Hauer
2023-11-29 6:52 ` Andy Yan
2023-11-29 6:52 ` Andy Yan
2023-11-29 6:52 ` Andy Yan
2023-11-22 12:54 ` [PATCH v2 06/12] drm/rockchip: vop2: rename grf to sys_grf Andy Yan
2023-11-22 12:54 ` Andy Yan
2023-11-22 12:54 ` Andy Yan
2023-11-27 14:17 ` Sascha Hauer
2023-11-27 14:17 ` Sascha Hauer
2023-11-27 14:17 ` Sascha Hauer
2023-11-22 12:55 ` [PATCH v2 07/12] dt-bindings: soc: rockchip: add rk3588 vop/vo syscon Andy Yan
2023-11-22 12:55 ` Andy Yan
2023-11-22 12:55 ` Andy Yan
2023-11-22 12:55 ` [PATCH v2 08/12] dt-bindings: display: vop2: Add rk3588 support Andy Yan
2023-11-22 12:55 ` Andy Yan
2023-11-22 12:55 ` Andy Yan
2023-11-22 19:07 ` Krzysztof Kozlowski
2023-11-22 19:07 ` Krzysztof Kozlowski
2023-11-22 19:07 ` Krzysztof Kozlowski
2023-11-30 12:32 ` Andy Yan
2023-11-30 12:32 ` Andy Yan
2023-11-30 12:32 ` Andy Yan
2023-11-22 12:55 ` [PATCH v2 09/12] dt-bindings: soc: vop2: Add more endpoint definition Andy Yan
2023-11-22 12:55 ` Andy Yan
2023-11-22 12:55 ` Andy Yan
2023-11-22 19:08 ` Krzysztof Kozlowski
2023-11-22 19:08 ` Krzysztof Kozlowski
2023-11-22 19:08 ` Krzysztof Kozlowski
2023-11-22 12:55 ` [PATCH v2 10/12] drm/rockchip: vop2: Add support for rk3588 Andy Yan
2023-11-22 12:55 ` Andy Yan
2023-11-22 12:55 ` Andy Yan
2023-11-27 11:19 ` Sascha Hauer
2023-11-27 11:19 ` Sascha Hauer
2023-11-27 11:19 ` Sascha Hauer
2023-11-29 8:28 ` Andy Yan
2023-11-29 8:28 ` Andy Yan
2023-11-29 8:28 ` Andy Yan
2023-11-27 15:29 ` Heiko Stübner
2023-11-27 15:29 ` Heiko Stübner
2023-11-27 15:29 ` Heiko Stübner
2023-11-28 9:32 ` Andy Yan
2023-11-28 9:32 ` Andy Yan
2023-11-28 9:32 ` Andy Yan
2023-11-28 9:44 ` Heiko Stübner
2023-11-28 9:44 ` Heiko Stübner
2023-11-28 9:44 ` Heiko Stübner
2023-11-28 10:11 ` Andy Yan
2023-11-28 10:11 ` Andy Yan
2023-11-28 10:11 ` Andy Yan
2023-11-22 12:56 ` [PATCH v2 11/12] drm/rockchip: vop2: Add debugfs support Andy Yan
2023-11-22 12:56 ` Andy Yan
2023-11-22 12:56 ` Andy Yan
2023-11-27 10:13 ` Sascha Hauer
2023-11-27 10:13 ` Sascha Hauer
2023-11-27 10:13 ` Sascha Hauer
2023-11-27 10:56 ` Andy Yan
2023-11-29 8:52 ` Sascha Hauer
2023-11-29 8:52 ` Sascha Hauer
2023-11-29 8:52 ` Sascha Hauer
2023-11-29 11:01 ` Andy Yan
2023-11-29 11:01 ` Andy Yan
2023-11-29 11:01 ` Andy Yan
2023-11-29 12:59 ` Sascha Hauer
2023-11-29 12:59 ` Sascha Hauer
2023-11-29 12:59 ` Sascha Hauer
2023-11-30 1:15 ` Andy Yan
2023-11-30 1:15 ` Andy Yan
2023-11-30 1:15 ` Andy Yan
2023-11-22 12:56 ` [PATCH v2 12/12] arm64: dts: rockchip: Add vop on rk3588 Andy Yan
2023-11-22 12:56 ` Andy Yan
2023-11-22 12:56 ` Andy Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23093643.0c2gjJ1VT2@diego \
--to=heiko@sntech.de \
--cc=andy.yan@rock-chips.com \
--cc=andyshrk@163.com \
--cc=chris.obbard@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=hjc@rock-chips.com \
--cc=kever.yang@rock-chips.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=sebastian.reichel@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.