Re: [PATCH i-g-t,v7 2/8] tests/kms_colorop_helper: Add helpers to clear colorops data

["Borah, Chaitanya Kumar" <chaitanya.kumar.borah@intel.com>]

On 12/19/2025 4:56 PM, Swati Sharma wrote:
> Add new helper function `clear_colorops()` to reset color operations
> to their default/bypass state. These functions:
>   - Set the colorop to bypass mode.
>   - Clear associated data blobs for CTM, LUT1D, LUT3D.
>   - Reset multiplier values where applicable.
> 
> v2: -make internal helper static (Chaitanya)
>      -rename func() to clear_colorops() (Chaitanya)
> 
> Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
> ---
>   tests/kms_colorop_helper.c | 30 ++++++++++++++++++++++++++++++
>   tests/kms_colorop_helper.h |  1 +
>   2 files changed, 31 insertions(+)
> 
> diff --git a/tests/kms_colorop_helper.c b/tests/kms_colorop_helper.c
> index 6869590f3..da95ec72d 100644
> --- a/tests/kms_colorop_helper.c
> +++ b/tests/kms_colorop_helper.c
> @@ -400,3 +400,33 @@ void set_color_pipeline_bypass(igt_plane_t *plane)
>   {
>   	igt_plane_set_prop_enum(plane, IGT_PLANE_COLOR_PIPELINE, "Bypass");
>   }
> +
> +static void clear_colorop(igt_display_t *display, kms_colorop_t *colorop)
> +{
> +	igt_assert(colorop->colorop);
> +	igt_colorop_set_prop_value(colorop->colorop, IGT_COLOROP_BYPASS, 1);
> +
> +	switch (colorop->type) {
> +	case KMS_COLOROP_CTM_3X4:
> +	case KMS_COLOROP_CUSTOM_LUT1D:
> +	case KMS_COLOROP_LUT3D:
> +		igt_colorop_replace_prop_blob(colorop->colorop, IGT_COLOROP_DATA, NULL, 0);
> +		break;
> +	case KMS_COLOROP_MULTIPLIER:
> +		igt_colorop_set_prop_value(colorop->colorop, IGT_COLOROP_MULTIPLIER, 1);
> +		break;
> +	case KMS_COLOROP_ENUMERATED_LUT1D:
> +	default:
> +		return;
> +	}
> +}
> +
> +void clear_colorops(igt_display_t *display,
> +		    igt_plane_t *plane,
> +		    kms_colorop_t *colorops[])
> +{
> +	int i;
> +
> +	for(i = 0; colorops[i]; i++)
> +		clear_colorop(display, colorops[i]);
> +}

We don't even need display as a parameter here and probably we should 
call the functions reset_colorop*().

With above changes made.

Reviewed-by: Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com>

> diff --git a/tests/kms_colorop_helper.h b/tests/kms_colorop_helper.h
> index b807f122d..bdc812baa 100644
> --- a/tests/kms_colorop_helper.h
> +++ b/tests/kms_colorop_helper.h
> @@ -102,5 +102,6 @@ void set_color_pipeline(igt_display_t *display,
>   			kms_colorop_t *colorops[],
>   			igt_colorop_t *color_pipeline);
>   void set_color_pipeline_bypass(igt_plane_t *plane);
> +void clear_colorops(igt_display_t *display, igt_plane_t *plane, kms_colorop_t *colorops[]);
>   
>   #endif /* __KMS_COLOROP_HELPER_H__ */