Re: [PATCH i-g-t, v7 7/8] tests/kms_colorop_helper: Cast pixel values to double

["Borah, Chaitanya Kumar" <chaitanya.kumar.borah@intel.com>]

On 12/19/2025 4:56 PM, Swati Sharma wrote:
> Explicitly cast transformed pixel channel values to double before
> scaling by UINT_MAX.

We should mention that we need this to avoid overflows for values 
approaching 1.0

Also move this patch before the patches that deals with MAX LUT values.

Otherwise LGTM
Reviewed-by: Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com>

> 
> Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
> ---
>   tests/kms_colorop_helper.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/tests/kms_colorop_helper.c b/tests/kms_colorop_helper.c
> index da95ec72d..ffc81f01c 100644
> --- a/tests/kms_colorop_helper.c
> +++ b/tests/kms_colorop_helper.c
> @@ -300,9 +300,9 @@ static void fill_custom_1dlut(igt_display_t *display, kms_colorop_t *colorop)
>   
>   		colorop->transform(&pixel);
>   
> -		colorop->lut1d->lut[i].red = pixel.r * UINT_MAX;
> -		colorop->lut1d->lut[i].green = pixel.g * UINT_MAX;
> -		colorop->lut1d->lut[i].blue = pixel.b * UINT_MAX;
> +		colorop->lut1d->lut[i].red = (double)pixel.r * UINT_MAX;
> +		colorop->lut1d->lut[i].green = (double)pixel.g * UINT_MAX;
> +		colorop->lut1d->lut[i].blue = (double)pixel.b * UINT_MAX;
>   	}
>   }
>