Re: [PATCH i-g-t, v7 5/8] tests/kms_color: Add helper for plane color pipeline tests

["Borah, Chaitanya Kumar" <chaitanya.kumar.borah@intel.com>]

On 12/19/2025 4:56 PM, Swati Sharma wrote:
> Add a helper to run plane color pipeline tests across
> all pipes and outputs on primary plane.
> 
> TODO: Extend the test to multiple planes (HDR & SDR)
> 
> Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
> Reviewed-by: Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com>
> ---
>   tests/kms_color.c | 38 ++++++++++++++++++++++++++++++++++++++
>   1 file changed, 38 insertions(+)
> 
> diff --git a/tests/kms_color.c b/tests/kms_color.c
> index c3c064d53..85c7d89d6 100644
> --- a/tests/kms_color.c
> +++ b/tests/kms_color.c
> @@ -816,6 +816,10 @@ static void test_setup(data_t *data, enum pipe p)
>   					  data->primary->pipe->pipe,
>   					  IGT_PIPE_CRC_SOURCE_AUTO);
>   
> +	igt_display_require_output_on_pipe(&data->display, p);
> +	data->output = igt_get_single_output_for_pipe(&data->display, p);
> +	igt_require(data->output);
> +


As I understand this was done to avoid going through all pipe and output 
combinations for the plane subtests. It should then be within the helper 
below (within for_each_pipe) instead of adding it to the test_setup 
shared by all subtests.

With that,
Reviewed-by: Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com>

>   	igt_display_reset(&data->display);
>   }
>   
> @@ -909,6 +913,40 @@ run_ctm_tests_for_pipe(data_t *data, enum pipe p,
>   	test_cleanup(data);
>   }
>   
> +__maybe_unused
> +static void run_plane_color_tests(data_t *data,
> +				  const color_t *fb_colors,
> +				  const color_t *exp_colors,
> +				  kms_colorop_t *colorops[])
> +{
> +	enum pipe pipe;
> +
> +	data->color_depth = 8;
> +	data->drm_format = DRM_FORMAT_XRGB8888;
> +
> +	for_each_pipe(&data->display, pipe) {
> +		test_setup(data, pipe);
> +
> +		data->mode = igt_output_get_mode(data->output);
> +
> +		if (!pipe_output_combo_valid(data, pipe)){
> +			test_cleanup(data);
> +			continue;
> +		}
> +
> +		 /* TODO: extend the test to multiple planes (HDR & SDR) */
> +		if (!igt_plane_has_prop(data->primary, IGT_PLANE_COLOR_PIPELINE))
> +			continue;
> +
> +		igt_dynamic_f("pipe-%s-%s",
> +			      kmstest_pipe_name(pipe),
> +			      igt_output_name(data->output))
> +			igt_assert(test_plane_colorops(data, fb_colors, exp_colors, colorops));
> +	}
> +
> +	test_cleanup(data);
> +}
> +
>   static void
>   run_deep_color_tests_for_pipe(data_t *data, enum pipe p)
>   {