From: Arnd Bergmann <arnd@arndb.de>
To: Tomasz Nowicki <tomasz.nowicki@linaro.org>
Cc: linaro-acpi@lists.linaro.org, catalin.marinas@arm.com,
will.deacon@arm.com, bhelgaas@google.com, Liviu.Dudau@arm.com,
tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
rjw@rjwysocki.net, linux-pci@vger.kernel.org, x86@kernel.org,
linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [Linaro-acpi] [RFC PATCH 3/4] arm64, acpi, pci: Add arch specific functions for mmconfig driver.
Date: Fri, 07 Nov 2014 15:54:09 +0100 [thread overview]
Message-ID: <2483899.fnsktEmYFO@wuerfel> (raw)
In-Reply-To: <545CD9A4.3080900@linaro.org>
On Friday 07 November 2014 15:39:32 Tomasz Nowicki wrote:
> On 07.11.2014 15:12, Arnd Bergmann wrote:
> > On Friday 07 November 2014 14:27:55 Tomasz Nowicki wrote:
> >> These calls allow to map/unmap PCI config space ranges (which are specified in
> >> MMCFG ACPI table).
> >>
> >> Signed-off-by: Tomasz Nowicki <tomasz.nowicki@linaro.org>
> >>
> >
> > Nothing in this patch looks arm64 specific, and most of it looks like a
> > copy of the x86 code.
>
> Yes, most of the logic was borrowed from mmconfig_64.c file,
> mmconfig_32.c looks differently, though. It is not simple to merge them
> both. IMO, we have two choices:
> 1. Refactor and move mmconfig_64.c out of x86 to e.g. drivers/acpi/ and
> let it be default.
> 2. Stay with solution presented in this patch.
> 3. Thoughts ?
If the code is generic, it should be shared with as many architectures as
possible. Moving the x86-64 implementation to drivers/acpi/ would immediately
let you share it with two out of the four architectures (x86-64 and arm64,
but not x86-32 and ia64) as well as any potential other architectures that
might implement ACPI in the future.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [Linaro-acpi] [RFC PATCH 3/4] arm64, acpi, pci: Add arch specific functions for mmconfig driver.
Date: Fri, 07 Nov 2014 15:54:09 +0100 [thread overview]
Message-ID: <2483899.fnsktEmYFO@wuerfel> (raw)
In-Reply-To: <545CD9A4.3080900@linaro.org>
On Friday 07 November 2014 15:39:32 Tomasz Nowicki wrote:
> On 07.11.2014 15:12, Arnd Bergmann wrote:
> > On Friday 07 November 2014 14:27:55 Tomasz Nowicki wrote:
> >> These calls allow to map/unmap PCI config space ranges (which are specified in
> >> MMCFG ACPI table).
> >>
> >> Signed-off-by: Tomasz Nowicki <tomasz.nowicki@linaro.org>
> >>
> >
> > Nothing in this patch looks arm64 specific, and most of it looks like a
> > copy of the x86 code.
>
> Yes, most of the logic was borrowed from mmconfig_64.c file,
> mmconfig_32.c looks differently, though. It is not simple to merge them
> both. IMO, we have two choices:
> 1. Refactor and move mmconfig_64.c out of x86 to e.g. drivers/acpi/ and
> let it be default.
> 2. Stay with solution presented in this patch.
> 3. Thoughts ?
If the code is generic, it should be shared with as many architectures as
possible. Moving the x86-64 implementation to drivers/acpi/ would immediately
let you share it with two out of the four architectures (x86-64 and arm64,
but not x86-32 and ia64) as well as any potential other architectures that
might implement ACPI in the future.
Arnd
next prev parent reply other threads:[~2014-11-07 14:54 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-07 13:27 [RFC PATCH 0/4] MMCFG refactoring + PCI ACPI probing for ARM64 Tomasz Nowicki
2014-11-07 13:27 ` Tomasz Nowicki
2014-11-07 13:27 ` [RFC PATCH 1/4] x86, acpi, pci: Move arch-agnostic MMCFG code out of arch/x86/ directory Tomasz Nowicki
2014-11-07 13:27 ` Tomasz Nowicki
2014-11-07 13:27 ` [RFC PATCH 2/4] x86, acpi, pci: Isolate new PCI mmconfig entry insertion Tomasz Nowicki
2014-11-07 13:27 ` Tomasz Nowicki
2014-11-07 14:09 ` Arnd Bergmann
2014-11-07 14:09 ` Arnd Bergmann
2014-11-07 14:43 ` Tomasz Nowicki
2014-11-07 14:43 ` Tomasz Nowicki
2014-11-07 13:27 ` [RFC PATCH 3/4] arm64, acpi, pci: Add arch specific functions for mmconfig driver Tomasz Nowicki
2014-11-07 13:27 ` Tomasz Nowicki
2014-11-07 14:12 ` [Linaro-acpi] " Arnd Bergmann
2014-11-07 14:12 ` Arnd Bergmann
2014-11-07 14:39 ` Tomasz Nowicki
2014-11-07 14:39 ` Tomasz Nowicki
2014-11-07 14:54 ` Arnd Bergmann [this message]
2014-11-07 14:54 ` Arnd Bergmann
2014-11-07 13:27 ` [RFC PATCH 4/4] arm64, acpi, pci: Provide arch-specific calls for PCI host bridge dirver (PNP0A03) Tomasz Nowicki
2014-11-07 13:27 ` Tomasz Nowicki
2014-11-07 14:24 ` Arnd Bergmann
2014-11-07 14:24 ` Arnd Bergmann
2014-11-14 14:10 ` Tomasz Nowicki
2014-11-14 14:10 ` Tomasz Nowicki
2014-11-14 14:53 ` [Linaro-acpi] " Arnd Bergmann
2014-11-14 14:53 ` Arnd Bergmann
2014-11-18 10:17 ` Tomasz Nowicki
2014-11-18 10:17 ` Tomasz Nowicki
2014-11-18 10:35 ` Arnd Bergmann
2014-11-18 10:35 ` Arnd Bergmann
2014-11-07 14:55 ` Liviu Dudau
2014-11-07 14:55 ` Liviu Dudau
2014-11-07 14:55 ` Liviu Dudau
2014-11-12 8:47 ` Tomasz Nowicki
2014-11-12 8:47 ` Tomasz Nowicki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2483899.fnsktEmYFO@wuerfel \
--to=arnd@arndb.de \
--cc=Liviu.Dudau@arm.com \
--cc=bhelgaas@google.com \
--cc=catalin.marinas@arm.com \
--cc=hpa@zytor.com \
--cc=linaro-acpi@lists.linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rjw@rjwysocki.net \
--cc=tglx@linutronix.de \
--cc=tomasz.nowicki@linaro.org \
--cc=will.deacon@arm.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.