From: Tomasz Nowicki <tomasz.nowicki@linaro.org>
To: Arnd Bergmann <arnd@arndb.de>, linux-arm-kernel@lists.infradead.org
Cc: catalin.marinas@arm.com, will.deacon@arm.com,
bhelgaas@google.com, Liviu.Dudau@arm.com, tglx@linutronix.de,
mingo@redhat.com, hpa@zytor.com, rjw@rjwysocki.net,
linaro-acpi@lists.linaro.org, linux-pci@vger.kernel.org,
x86@kernel.org, linux-kernel@vger.kernel.org,
linux-acpi@vger.kernel.org
Subject: Re: [RFC PATCH 2/4] x86, acpi, pci: Isolate new PCI mmconfig entry insertion.
Date: Fri, 07 Nov 2014 15:43:19 +0100 [thread overview]
Message-ID: <545CDA87.2040701@linaro.org> (raw)
In-Reply-To: <1927317.6tJuq4S5Om@wuerfel>
On 07.11.2014 15:09, Arnd Bergmann wrote:
> On Friday 07 November 2014 14:27:54 Tomasz Nowicki wrote:
>> Add special pci_mmcfg_insert_lock mutex since pci_mmcfg_lock was moved
>> to common file. No functional changes.
>>
>> Signed-off-by: Tomasz Nowicki <tomasz.nowicki@linaro.org>
>>
>
> What is the new lock protecting against? You no longer have a mutual
> exclusion with the other code, which looks like it is a functional
> change, and also incorrect.
>
> It also sounds like the code was broken after the first patch and
> you need this one to make it compile again. You can't do that, and
> instead need to change the locking rules first.
Oh, that's right! Sorry I will take a look again.
Tomasz
WARNING: multiple messages have this Message-ID (diff)
From: tomasz.nowicki@linaro.org (Tomasz Nowicki)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH 2/4] x86, acpi, pci: Isolate new PCI mmconfig entry insertion.
Date: Fri, 07 Nov 2014 15:43:19 +0100 [thread overview]
Message-ID: <545CDA87.2040701@linaro.org> (raw)
In-Reply-To: <1927317.6tJuq4S5Om@wuerfel>
On 07.11.2014 15:09, Arnd Bergmann wrote:
> On Friday 07 November 2014 14:27:54 Tomasz Nowicki wrote:
>> Add special pci_mmcfg_insert_lock mutex since pci_mmcfg_lock was moved
>> to common file. No functional changes.
>>
>> Signed-off-by: Tomasz Nowicki <tomasz.nowicki@linaro.org>
>>
>
> What is the new lock protecting against? You no longer have a mutual
> exclusion with the other code, which looks like it is a functional
> change, and also incorrect.
>
> It also sounds like the code was broken after the first patch and
> you need this one to make it compile again. You can't do that, and
> instead need to change the locking rules first.
Oh, that's right! Sorry I will take a look again.
Tomasz
next prev parent reply other threads:[~2014-11-07 14:43 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-07 13:27 [RFC PATCH 0/4] MMCFG refactoring + PCI ACPI probing for ARM64 Tomasz Nowicki
2014-11-07 13:27 ` Tomasz Nowicki
2014-11-07 13:27 ` [RFC PATCH 1/4] x86, acpi, pci: Move arch-agnostic MMCFG code out of arch/x86/ directory Tomasz Nowicki
2014-11-07 13:27 ` Tomasz Nowicki
2014-11-07 13:27 ` [RFC PATCH 2/4] x86, acpi, pci: Isolate new PCI mmconfig entry insertion Tomasz Nowicki
2014-11-07 13:27 ` Tomasz Nowicki
2014-11-07 14:09 ` Arnd Bergmann
2014-11-07 14:09 ` Arnd Bergmann
2014-11-07 14:43 ` Tomasz Nowicki [this message]
2014-11-07 14:43 ` Tomasz Nowicki
2014-11-07 13:27 ` [RFC PATCH 3/4] arm64, acpi, pci: Add arch specific functions for mmconfig driver Tomasz Nowicki
2014-11-07 13:27 ` Tomasz Nowicki
2014-11-07 14:12 ` [Linaro-acpi] " Arnd Bergmann
2014-11-07 14:12 ` Arnd Bergmann
2014-11-07 14:39 ` Tomasz Nowicki
2014-11-07 14:39 ` Tomasz Nowicki
2014-11-07 14:54 ` Arnd Bergmann
2014-11-07 14:54 ` Arnd Bergmann
2014-11-07 13:27 ` [RFC PATCH 4/4] arm64, acpi, pci: Provide arch-specific calls for PCI host bridge dirver (PNP0A03) Tomasz Nowicki
2014-11-07 13:27 ` Tomasz Nowicki
2014-11-07 14:24 ` Arnd Bergmann
2014-11-07 14:24 ` Arnd Bergmann
2014-11-14 14:10 ` Tomasz Nowicki
2014-11-14 14:10 ` Tomasz Nowicki
2014-11-14 14:53 ` [Linaro-acpi] " Arnd Bergmann
2014-11-14 14:53 ` Arnd Bergmann
2014-11-18 10:17 ` Tomasz Nowicki
2014-11-18 10:17 ` Tomasz Nowicki
2014-11-18 10:35 ` Arnd Bergmann
2014-11-18 10:35 ` Arnd Bergmann
2014-11-07 14:55 ` Liviu Dudau
2014-11-07 14:55 ` Liviu Dudau
2014-11-07 14:55 ` Liviu Dudau
2014-11-12 8:47 ` Tomasz Nowicki
2014-11-12 8:47 ` Tomasz Nowicki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=545CDA87.2040701@linaro.org \
--to=tomasz.nowicki@linaro.org \
--cc=Liviu.Dudau@arm.com \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=catalin.marinas@arm.com \
--cc=hpa@zytor.com \
--cc=linaro-acpi@lists.linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rjw@rjwysocki.net \
--cc=tglx@linutronix.de \
--cc=will.deacon@arm.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.