From: Tomasz Figa <tomasz.figa@gmail.com>
To: Vikas Sajjan <vikas.sajjan@linaro.org>
Cc: yadi.brar01@gmail.com, linux-samsung-soc@vger.kernel.org,
dianders@chromium.org, linux-arm-kernel@lists.infradead.org,
kgene.kim@samsung.com, mturquette@linaro.org,
thomas.abraham@linaro.org
Subject: Re: [RESEND PATCH 4/5] clk: samsung: Add set_rate() clk_ops for PLL36xx
Date: Sat, 25 May 2013 00:20:05 +0200 [thread overview]
Message-ID: <2497806.WgtiTKYQrX@flatron> (raw)
In-Reply-To: <1369391478-7665-5-git-send-email-vikas.sajjan@linaro.org>
Hi,
On Friday 24 of May 2013 16:01:17 Vikas Sajjan wrote:
> This patch adds set_rate and round_rate clk_ops for PLL36xx
> The round_rate() implementation as of now is dummy, it returns the same
> rate which is passed as input.
>
> Signed-off-by: Vikas Sajjan <vikas.sajjan@linaro.org>
> ---
> drivers/clk/samsung/clk-pll.c | 67
> +++++++++++++++++++++++++++++++++++++++++ 1 file changed, 67
> insertions(+)
>
I have exactly the same comments for this patch as for patch 3/5.
Best regards,
Tomasz
WARNING: multiple messages have this Message-ID (diff)
From: tomasz.figa@gmail.com (Tomasz Figa)
To: linux-arm-kernel@lists.infradead.org
Subject: [RESEND PATCH 4/5] clk: samsung: Add set_rate() clk_ops for PLL36xx
Date: Sat, 25 May 2013 00:20:05 +0200 [thread overview]
Message-ID: <2497806.WgtiTKYQrX@flatron> (raw)
In-Reply-To: <1369391478-7665-5-git-send-email-vikas.sajjan@linaro.org>
Hi,
On Friday 24 of May 2013 16:01:17 Vikas Sajjan wrote:
> This patch adds set_rate and round_rate clk_ops for PLL36xx
> The round_rate() implementation as of now is dummy, it returns the same
> rate which is passed as input.
>
> Signed-off-by: Vikas Sajjan <vikas.sajjan@linaro.org>
> ---
> drivers/clk/samsung/clk-pll.c | 67
> +++++++++++++++++++++++++++++++++++++++++ 1 file changed, 67
> insertions(+)
>
I have exactly the same comments for this patch as for patch 3/5.
Best regards,
Tomasz
next prev parent reply other threads:[~2013-05-24 22:20 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-24 10:31 [RESEND PATCH 0/5] Add generic set_rate clk_ops for PLL35XX and PLL36XX for samsung SoCs Vikas Sajjan
2013-05-24 10:31 ` Vikas Sajjan
2013-05-24 10:31 ` [RESEND PATCH 1/5] clk: samsung: Use clk->base instead of directly using clk->con0 for PLL3xxx Vikas Sajjan
2013-05-24 10:31 ` Vikas Sajjan
2013-05-24 21:55 ` Tomasz Figa
2013-05-24 21:55 ` Tomasz Figa
2013-05-24 10:31 ` [RESEND PATCH 2/5] clk: samsung: Add support to register rate_table " Vikas Sajjan
2013-05-24 10:31 ` Vikas Sajjan
2013-05-24 22:04 ` Tomasz Figa
2013-05-24 22:04 ` Tomasz Figa
2013-05-27 6:35 ` Yadwinder Singh Brar
2013-05-27 6:35 ` Yadwinder Singh Brar
2013-05-24 10:31 ` [RESEND PATCH 3/5] clk: samsung: Add set_rate() clk_ops for PLL35xx Vikas Sajjan
2013-05-24 10:31 ` Vikas Sajjan
2013-05-24 22:19 ` Tomasz Figa
2013-05-24 22:19 ` Tomasz Figa
2013-05-27 6:36 ` Yadwinder Singh Brar
2013-05-27 6:36 ` Yadwinder Singh Brar
2013-05-24 10:31 ` [RESEND PATCH 4/5] clk: samsung: Add set_rate() clk_ops for PLL36xx Vikas Sajjan
2013-05-24 10:31 ` Vikas Sajjan
2013-05-24 22:20 ` Tomasz Figa [this message]
2013-05-24 22:20 ` Tomasz Figa
2013-05-24 10:31 ` [RESEND PATCH 5/5] clk: samsung: Add EPLL and VPLL freq table for exynos5250 SoC Vikas Sajjan
2013-05-24 10:31 ` Vikas Sajjan
-- strict thread matches above, loose matches on Subject: below --
2013-05-24 5:55 [RESEND PATCH 0/5] Add generic set_rate clk_ops for PLL35XX and PLL36XX for samsung SoCs Vikas Sajjan
2013-05-24 5:55 ` [RESEND PATCH 4/5] clk: samsung: Add set_rate() clk_ops for PLL36xx Vikas Sajjan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2497806.WgtiTKYQrX@flatron \
--to=tomasz.figa@gmail.com \
--cc=dianders@chromium.org \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mturquette@linaro.org \
--cc=thomas.abraham@linaro.org \
--cc=vikas.sajjan@linaro.org \
--cc=yadi.brar01@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.