All of lore.kernel.org
 help / color / mirror / Atom feed
From: Milan Broz <gmazyland@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@intel.com>,
	Mikulas Patocka <mpatocka@redhat.com>
Cc: Andy Shevchenko <andy@kernel.org>,
	Mike Snitzer <msnitzer@redhat.com>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Mimi Zohar <zohar@linux.ibm.com>,
	device-mapper development <dm-devel@redhat.com>,
	Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
	Jason@zx2c4.com, Stafford Horne <shorne@gmail.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	"David S. Miller" <davem@davemloft.net>
Subject: Re: [dm-devel] [PATCH v2] hex2bin: make the function hex_to_bin constant-time
Date: Wed, 4 May 2022 11:47:52 +0200	[thread overview]
Message-ID: <24c9a856-be10-e9b3-b26d-e6ced9e13c63@gmail.com> (raw)
In-Reply-To: <YnJFViBFIgYOl7/2@smile.fi.intel.com>

On 04/05/2022 11:20, Andy Shevchenko wrote:
> On Wed, May 04, 2022 at 04:57:35AM -0400, Mikulas Patocka wrote:
>> On Wed, 4 May 2022, Stafford Horne wrote:
>>> On Mon, Apr 25, 2022 at 08:07:48AM -0400, Mikulas Patocka wrote:
> 
> ...
> 
>>> Just a heads up it seems this patch is causing some instability with crypto self
>>> tests on OpenRISC when using a PREEMPT kernel (no SMP).
>>>
>>> This was reported by Jason A. Donenfeld as it came up in wireguard testing.
>>>
>>> I am trying to figure out if this is an OpenRISC PREEMPT issue or something
>>> else.
> 
>> That patch is so simple that I can't imagine how could it break the
>> curve25519 test. Are you sure that you bisected it correctly?
> 
> Can you provide a test cases for hex_to_bin()?

BTW we use exactly the same code from Mikulas in cryptsetup now (actually the report
was initiated from here :) and I added some tests for this code,
you can probably adapt it (we just use generic wrapper around it):

https://gitlab.com/cryptsetup/cryptsetup/-/commit/2d8cdb2e356d187658efa6efc7bfa146be5d3f60#d9c94cde02e4509f6d12c3edd40f8a9138696807_0_176

(it calls this: https://gitlab.com/cryptsetup/cryptsetup/-/commit/ff14c17de794fe85299d90e34e12a677e6148b71 )

I do not have OpenRISC available, but it would be interesting to run cryptsetup/tests/vectors-test there...

Milan

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel


WARNING: multiple messages have this Message-ID (diff)
From: Milan Broz <gmazyland@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@intel.com>,
	Mikulas Patocka <mpatocka@redhat.com>
Cc: Stafford Horne <shorne@gmail.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Andy Shevchenko <andy@kernel.org>,
	device-mapper development <dm-devel@redhat.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	"David S. Miller" <davem@davemloft.net>,
	Mike Snitzer <msnitzer@redhat.com>,
	Mimi Zohar <zohar@linux.ibm.com>,
	Jason@zx2c4.com
Subject: Re: [PATCH v2] hex2bin: make the function hex_to_bin constant-time
Date: Wed, 4 May 2022 11:47:52 +0200	[thread overview]
Message-ID: <24c9a856-be10-e9b3-b26d-e6ced9e13c63@gmail.com> (raw)
In-Reply-To: <YnJFViBFIgYOl7/2@smile.fi.intel.com>

On 04/05/2022 11:20, Andy Shevchenko wrote:
> On Wed, May 04, 2022 at 04:57:35AM -0400, Mikulas Patocka wrote:
>> On Wed, 4 May 2022, Stafford Horne wrote:
>>> On Mon, Apr 25, 2022 at 08:07:48AM -0400, Mikulas Patocka wrote:
> 
> ...
> 
>>> Just a heads up it seems this patch is causing some instability with crypto self
>>> tests on OpenRISC when using a PREEMPT kernel (no SMP).
>>>
>>> This was reported by Jason A. Donenfeld as it came up in wireguard testing.
>>>
>>> I am trying to figure out if this is an OpenRISC PREEMPT issue or something
>>> else.
> 
>> That patch is so simple that I can't imagine how could it break the
>> curve25519 test. Are you sure that you bisected it correctly?
> 
> Can you provide a test cases for hex_to_bin()?

BTW we use exactly the same code from Mikulas in cryptsetup now (actually the report
was initiated from here :) and I added some tests for this code,
you can probably adapt it (we just use generic wrapper around it):

https://gitlab.com/cryptsetup/cryptsetup/-/commit/2d8cdb2e356d187658efa6efc7bfa146be5d3f60#d9c94cde02e4509f6d12c3edd40f8a9138696807_0_176

(it calls this: https://gitlab.com/cryptsetup/cryptsetup/-/commit/ff14c17de794fe85299d90e34e12a677e6148b71 )

I do not have OpenRISC available, but it would be interesting to run cryptsetup/tests/vectors-test there...

Milan

  reply	other threads:[~2022-05-04  9:48 UTC|newest]

Thread overview: 66+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-24 20:54 [dm-devel] [PATCH] hex2bin: make the function hex_to_bin constant-time Mikulas Patocka
2022-04-24 20:54 ` Mikulas Patocka
2022-04-24 21:30 ` [dm-devel] " Joe Perches
2022-04-24 21:30   ` Joe Perches
2022-04-24 21:37 ` [dm-devel] " Linus Torvalds
2022-04-24 21:37   ` Linus Torvalds
2022-04-24 21:42   ` [dm-devel] " Linus Torvalds
2022-04-24 21:42     ` Linus Torvalds
2022-04-25  9:37     ` [dm-devel] " David Laight
2022-04-25  9:37       ` David Laight
2022-04-25 11:04       ` [dm-devel] " Mikulas Patocka
2022-04-25 11:04         ` Mikulas Patocka
2022-04-25 12:59         ` [dm-devel] " David Laight
2022-04-25 12:59           ` David Laight
2022-04-25 13:33           ` [dm-devel] " Mikulas Patocka
2022-04-25 13:33             ` Mikulas Patocka
2022-04-25 12:07   ` [dm-devel] [PATCH v2] " Mikulas Patocka
2022-04-25 12:07     ` Mikulas Patocka
2022-04-25 17:53     ` [dm-devel] " Linus Torvalds
2022-04-25 17:53       ` Linus Torvalds
2022-05-04  8:38     ` [dm-devel] " Stafford Horne
2022-05-04  8:38       ` Stafford Horne
2022-05-04  8:57       ` [dm-devel] " Mikulas Patocka
2022-05-04  8:57         ` Mikulas Patocka
2022-05-04  9:20         ` [dm-devel] " Andy Shevchenko
2022-05-04  9:20           ` Andy Shevchenko
2022-05-04  9:47           ` Milan Broz [this message]
2022-05-04  9:47             ` Milan Broz
2022-05-04  9:50             ` [dm-devel] " Jason A. Donenfeld
2022-05-04  9:50               ` Jason A. Donenfeld
2022-05-04 11:54           ` [dm-devel] " Mikulas Patocka
2022-05-04 11:54             ` Mikulas Patocka
2022-05-04  9:42       ` [dm-devel] " Jason A. Donenfeld
2022-05-04  9:42         ` Jason A. Donenfeld
2022-05-04  9:44         ` [dm-devel] " Jason A. Donenfeld
2022-05-04  9:44           ` Jason A. Donenfeld
2022-05-04  9:57         ` [dm-devel] " Jason A. Donenfeld
2022-05-04  9:57           ` Jason A. Donenfeld
2022-05-04 10:07           ` [dm-devel] " Andy Shevchenko
2022-05-04 10:07             ` Andy Shevchenko
2022-05-04 10:15             ` [dm-devel] " Jason A. Donenfeld
2022-05-04 10:15               ` Jason A. Donenfeld
2022-05-04 18:00               ` [dm-devel] " Linus Torvalds
2022-05-04 18:00                 ` Linus Torvalds
2022-05-04 19:42                 ` [dm-devel] " Jason A. Donenfeld
2022-05-04 19:42                   ` Jason A. Donenfeld
2022-05-04 19:51                   ` [dm-devel] " Linus Torvalds
2022-05-04 19:51                     ` Linus Torvalds
2022-05-04 20:00                     ` [dm-devel] " Linus Torvalds
2022-05-04 20:00                       ` Linus Torvalds
2022-05-04 20:12                       ` [dm-devel] " Stafford Horne
2022-05-04 20:12                         ` Stafford Horne
2022-05-04 20:26                         ` [dm-devel] " Linus Torvalds
2022-05-04 20:26                           ` Linus Torvalds
2022-05-04 21:24                           ` [dm-devel] " Linus Torvalds
2022-05-04 21:24                             ` Linus Torvalds
2022-05-04 19:57                   ` [dm-devel] " Stafford Horne
2022-05-04 19:57                     ` Stafford Horne
2022-05-04 20:10                     ` [dm-devel] " Linus Torvalds
2022-05-04 20:10                       ` Linus Torvalds
2022-05-04 20:38                       ` [dm-devel] " Stafford Horne
2022-05-04 20:38                         ` Stafford Horne
2022-05-08  0:37                         ` [dm-devel] " Stafford Horne
2022-05-08  0:37                           ` Stafford Horne
2022-05-11 12:17                           ` [dm-devel] " Stafford Horne
2022-05-11 12:17                             ` Stafford Horne

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=24c9a856-be10-e9b3-b26d-e6ced9e13c63@gmail.com \
    --to=gmazyland@gmail.com \
    --cc=Jason@zx2c4.com \
    --cc=andriy.shevchenko@intel.com \
    --cc=andy@kernel.org \
    --cc=davem@davemloft.net \
    --cc=dm-devel@redhat.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mpatocka@redhat.com \
    --cc=msnitzer@redhat.com \
    --cc=shorne@gmail.com \
    --cc=torvalds@linux-foundation.org \
    --cc=zohar@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.